public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	 nadavh@marvell.com, Neta Zur Hershkovits <neta@marvell.com>,
	 Kostya Porotchkin <kostap@marvell.com>,
	Hua Jing <jinghua@marvell.com>, Alexander Graf <agraf@suse.de>,
	semihalf-dabros-jan <jsd@semihalf.com>
Subject: Re: [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements
Date: Thu, 5 Oct 2017 16:54:26 +0200	[thread overview]
Message-ID: <CAPv3WKeSwM_JWp1Jiv2rqbf_02=jrWmBAwB5O_K6msuBpZ=9YA@mail.gmail.com> (raw)
In-Reply-To: <CAPv3WKdPe9sdWR5hsKXBB1_=EOvqM86=UpuXsZ81ZrhAb8fw0w@mail.gmail.com>

Leif,

2017-10-05 15:37 GMT+02:00 Marcin Wojtas <mw@semihalf.com>:
> Hi Leif,
>
> 2017-10-05 15:30 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
>>
>> On Mon, Sep 25, 2017 at 03:51:49AM +0200, Marcin Wojtas wrote:
>> > Hi,
>> >
>> > Finally I found time to respin SPI patchset. As agreed, I extracted
>> > style fixes from dynamic flash detection patch, but its main part
>> > is kept aside for now until FlashId table (and additionally both SPI
>> > protocols land in the edk2 mainline). A lot of minor fixes were
>> > implemented, details can be found in the commit logs and changelog
>> > below.
>> >
>> > Patches are available in the github:
>> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925
>> >
>> > I'm looking forward to the comments or remarks.
>>
>> If the two minor changes I have suggested are acceptable - for the series:
>> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>>
>> As mentioned, I can fold these in before pushing. Let me know.
>>

Here:
https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20171005

you can find rebased commits, with 2 modifications you pointed (%a and
use BaseLib size types). Added RB's everywhere and tested - working
fine.

Best regards,
Marcin


  reply	other threads:[~2017-10-05 14:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25  1:51 [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements Marcin Wojtas
2017-09-25  1:51 ` [platforms: PATCH 01/10] Silicon/Marvell: Refactor Documentation Marcin Wojtas
2017-09-25  1:51 ` [platforms: PATCH 02/10] Marvell/Drivers: MvSpiDxe: Log and return correct error Marcin Wojtas
2017-10-05 13:14   ` Leif Lindholm
2017-09-25  1:51 ` [platforms: PATCH 03/10] Marvell/Drivers: MvSpiDxe: Fix write bug Marcin Wojtas
2017-09-25  1:51 ` [platforms: PATCH 04/10] Marvell/Applications/SpiTool: Enable configurable CS and SCLK mode Marcin Wojtas
2017-09-25  1:51 ` [platforms: PATCH 05/10] Platform/Marvell/Armada70x0: set CS and SCLK Mode for SPI flash Marcin Wojtas
2017-09-25  1:51 ` [platforms: PATCH 06/10] Marvell/Applications/SpiTool: Fix bug in error test Marcin Wojtas
2017-09-25  1:51 ` [platforms: PATCH 07/10] Marvell/Applications/FirmwareUpdate: Fix 32-bit issues Marcin Wojtas
2017-09-25  1:51 ` [platforms: PATCH 08/10] Marvell/Applications/SpiTool: " Marcin Wojtas
2017-09-25  1:51 ` [platforms: PATCH 09/10] Marvell/Drivers: MvSpiFlash: Fix usage of erase size parameter Marcin Wojtas
2017-10-05 13:28   ` Leif Lindholm
2017-09-25  1:51 ` [platforms: PATCH 10/10] Marvell/Drivers: MvSpiFlash: Minor style fix Marcin Wojtas
2017-10-05 13:30 ` [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements Leif Lindholm
2017-10-05 13:37   ` Marcin Wojtas
2017-10-05 14:54     ` Marcin Wojtas [this message]
2017-10-05 15:50       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPv3WKeSwM_JWp1Jiv2rqbf_02=jrWmBAwB5O_K6msuBpZ=9YA@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox