From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::231; helo=mail-it0-x231.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D95C22095B080 for ; Thu, 5 Oct 2017 07:51:04 -0700 (PDT) Received: by mail-it0-x231.google.com with SMTP id p138so1617366itp.2 for ; Thu, 05 Oct 2017 07:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=srqKj4nUaIh2wmkRmokXkjfmsHHBbLbAWhz5bbfLYVg=; b=2DdnYCQZ1c66lakKVjmBKP7epsGO/o8iarK5ReM50dePsqfeXLi/3cI4bHzGk6yESg jztoaEHn9odnA0zj9DnAzBiotC4OLt6HtvjJaC4KZjPEFq5aS7MnEIvzg3Lxs6CNxMIX /lD1bRHy9o9yvpNJhRidocqimQfbcwUKgolqnXuLEoqpdzoPFd5a8RMWHT48ppsYo41M r10Nd79E9RpnAdIdBDQZgygimJip65AgIS78ZmKwwSnp6RF0mUoXQF29vFrtuIL2tNwa amV55sfic4PMT9hNuG5WF9q2WMTOFx+S+xsdK/tNf6bTqg+bqSw/mHkrLds8Q0qft0x1 C+fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=srqKj4nUaIh2wmkRmokXkjfmsHHBbLbAWhz5bbfLYVg=; b=Cu6TP/Ps33Q4xz0Edozrh785jhbmXPEyxWJRWcfPoMIf+vt8DkIN0d3I64vo/Q49tK L6fiKDm6t4RZUVV09D9KAEM4QsoPyEoDz3n2W4KBZzvwSTWLqL9CS5D7GLaFDhBkhdUm 1yXcoI86OAcUSMxSnZRKQ8tUxBkWKnUDWo5+fY6gZN9rC7wUT4khYGWmbdOnhd3+KZAD WMuoe79Iqda2Tn6vfGaiv7TQ973E38w0tfNUI4WN+RRreoHbSaYrI6+uC2wjLnSHxI6s 3qVVMrk5GC8t2z+/JYdqlF3khQpbSF/O/C6ECyg6ZI6g5g99eFDDGraWdSjxKFH6r792 99qw== X-Gm-Message-State: AMCzsaUsgskL6DYbLvCWPghCSyW40ocKgxdIR5TUTG76CPcxVohxR/IP Nz9KEeZhbYODR/Cg8B5pytqytX7W+lthMMaC2WZZhg== X-Google-Smtp-Source: AOwi7QAmVnQxjbWEZEib1SeH1g41p+y2Yw/6Uq+AKBf4Qro7UwMT27iI3Y2TtAU/cEH3jTkiLZSFtmsp22kbns275tU= X-Received: by 10.36.57.18 with SMTP id l18mr8681629ita.138.1507215266796; Thu, 05 Oct 2017 07:54:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.157.141 with HTTP; Thu, 5 Oct 2017 07:54:26 -0700 (PDT) In-Reply-To: References: <1506304319-8620-1-git-send-email-mw@semihalf.com> <20171005133023.xiffuuabakeeyywf@bivouac.eciton.net> From: Marcin Wojtas Date: Thu, 5 Oct 2017 16:54:26 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , Alexander Graf , semihalf-dabros-jan Subject: Re: [platforms: PATCH 00/10] Armada 70x0/80x0 SPI improvements X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Oct 2017 14:51:05 -0000 Content-Type: text/plain; charset="UTF-8" Leif, 2017-10-05 15:37 GMT+02:00 Marcin Wojtas : > Hi Leif, > > 2017-10-05 15:30 GMT+02:00 Leif Lindholm : >> >> On Mon, Sep 25, 2017 at 03:51:49AM +0200, Marcin Wojtas wrote: >> > Hi, >> > >> > Finally I found time to respin SPI patchset. As agreed, I extracted >> > style fixes from dynamic flash detection patch, but its main part >> > is kept aside for now until FlashId table (and additionally both SPI >> > protocols land in the edk2 mainline). A lot of minor fixes were >> > implemented, details can be found in the commit logs and changelog >> > below. >> > >> > Patches are available in the github: >> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20170925 >> > >> > I'm looking forward to the comments or remarks. >> >> If the two minor changes I have suggested are acceptable - for the series: >> Reviewed-by: Leif Lindholm >> >> As mentioned, I can fold these in before pushing. Let me know. >> Here: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/spi-upstream-r20171005 you can find rebased commits, with 2 modifications you pointed (%a and use BaseLib size types). Added RB's everywhere and tested - working fine. Best regards, Marcin