Re: [edk2-devel] [edk2-platforms: PATCH v2 10/10] Marvell/Drivers: SmbiosPlatformDxe: Use more generic board name

["Marcin Wojtas" <mw@semihalf.com>]

Hi Leif,

pt., 16 sie 2019 o 19:41 Leif Lindholm <leif.lindholm@linaro.org> napisał(a):
>
> On Thu, Aug 15, 2019 at 04:54:14AM +0200, Marcin Wojtas wrote:
> > SmbiosPlatformDxe is used both by Armada 7k8k and CN913x platforms.
> > Replace board name placeholder in order to avoid confusion.
>
> Stupid/lazy question - do we already specify the actual platform name
> elsewhere?

No. My plan is to enable SMBIOS customization via board description
library / protocol. I just came up on an easy idea to use PCD for
platform name. If that's ok for you, I'll refactor to it in v2.

Thanks,
Marcin

>
> /
>     Leif
>
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> >  Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > index 08f4fa7..cdacd90 100644
> > --- a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > +++ b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > @@ -102,7 +102,7 @@ STATIC SMBIOS_TABLE_TYPE1 mArmadaDefaultType1 = {
> >
> >  STATIC CHAR8 CONST *mArmadaDefaultType1Strings[] = {
> >    "Marvell                        \0",/* Manufacturer */
> > -  "Armada 7k/8k Family Board      \0",/* Product Name placeholder*/
> > +  "Marvell Development Board      \0",/* Product Name placeholder*/
> >    "Revision unknown               \0",/* Version placeholder */
> >    "                               \0",/* 32 character buffer */
> >    NULL
> > @@ -130,7 +130,7 @@ STATIC SMBIOS_TABLE_TYPE2 mArmadaDefaultType2 = {
> >
> >  STATIC CHAR8 CONST *mArmadaDefaultType2Strings[] = {
> >    "Marvell                        \0",/* Manufacturer */
> > -  "Armada 7k/8k Family Board      \0",/* Product Name placeholder*/
> > +  "Marvell Development Board      \0",/* Product Name placeholder*/
> >    "Revision unknown               \0",/* Version placeholder */
> >    "Serial Not Set                 \0",/* Serial */
> >    "Base of Chassis                \0",/* Board location */
> > --
> > 2.7.4
> >
> >
> > 
> >