From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=yW51y/ak;
 spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.193, mailfrom: mw@semihalf.com)
Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193])
 by groups.io with SMTP; Fri, 16 Aug 2019 13:57:32 -0700
Received: by mail-qt1-f193.google.com with SMTP id z4so7575476qtc.3
        for <devel@edk2.groups.io>; Fri, 16 Aug 2019 13:57:32 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=semihalf-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=dEYe7sSGwGtQ4lwMCEnTt/+JlzkXaNweAIdTwSMoHuE=;
        b=yW51y/akB0u0qx4f4JbV3lZkpiDgPCB/xxEjeUdwMfPl6Qe+I3U0r7mJcDiI2e3uIE
         r6zzopGxp4IpWuo96W2ZaYNPgN6C+30jVJlxtIAIvHNHP4JyCERWZL6abXMvmMXXkvyJ
         /t3y+yzf3iYwlX9tJ10YkcYmnyob14hMlRuHbYX5SJm8VtJHcwUaHBTzDjHd8Ys3/muF
         /KSlgFWrEs+uKdSNV2jpoq6vfER/Mnmtk4uIaZffDbG/s+p3ladg/I0oxLor7Xdv0V5+
         T7r8haCxK3pRngHiwj7t978MMUL1Fb6SbFjAsoO4sEA7vk+1N7qB8Glo30DHrHQjKeYE
         fM/w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=dEYe7sSGwGtQ4lwMCEnTt/+JlzkXaNweAIdTwSMoHuE=;
        b=O/X2DuRWfezYgbMAy+rqKLZUCX2xQwPLfIwmnmHxL1RUApSMEl1f07w+hLW31gzQls
         YAd2GqbDRFVF//8jwY7LiXt1KIqdzT7YFxgbNgBesV+DeS9SKy0RAHdj7xqauQiNm0j+
         q7GcnD5+p0oOGPhBdHlJk6BuQnDv1qi7BT0Cl6w3B4dsJ0pNvdrB5lczsEJRjyyS5Tem
         AlFj8FHkXexETTOslIDDEUO7UKhb6rK8uxNpozfVFPPF7KsyzNUbWHOjoYu163hhJFNJ
         2VBsjf4S2ELM6jzDIqUH6U1LPvtILiAF7MHvLOsuMSzpnOH4K89Mf5ptOwsW2ws9eSKR
         DZqg==
X-Gm-Message-State: APjAAAVpJRlba25Qox3mo4tkl++NTAIt4CSjRg4uZJnoa2Se0MbwEUUi
	dDi5QOzHLFO5qCuMb3aXTXel0Zb/hFbRgChFlPFALQ==
X-Google-Smtp-Source: APXvYqwZD6FRoBUWb7yKl5RFWqsMXfs19+nxPQnY/G9+nsT21l6yjyefoHcFj6dUen8y8ncFf8WLtyNH16nQEBJBXyg=
X-Received: by 2002:aed:35b4:: with SMTP id c49mr10087348qte.313.1565989051674;
 Fri, 16 Aug 2019 13:57:31 -0700 (PDT)
MIME-Version: 1.0
References: <1565837654-13258-1-git-send-email-mw@semihalf.com>
 <1565837654-13258-11-git-send-email-mw@semihalf.com> <20190816174153.GC29255@bivouac.eciton.net>
In-Reply-To: <20190816174153.GC29255@bivouac.eciton.net>
From: "Marcin Wojtas" <mw@semihalf.com>
Date: Fri, 16 Aug 2019 22:57:22 +0200
Message-ID: <CAPv3WKe_ocg2Ac7sWOLjar_WimgP4nzu2ZdfZmv++BoKs+cQpg@mail.gmail.com>
Subject: Re: [edk2-devel] [edk2-platforms: PATCH v2 10/10] Marvell/Drivers: SmbiosPlatformDxe: Use more generic board name
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, 
	"jsd@semihalf.com" <jsd@semihalf.com>, Grzegorz Jaszczyk <jaz@semihalf.com>, 
	Kostya Porotchkin <kostap@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Leif,

pt., 16 sie 2019 o 19:41 Leif Lindholm <leif.lindholm@linaro.org> napisa=
=C5=82(a):
>
> On Thu, Aug 15, 2019 at 04:54:14AM +0200, Marcin Wojtas wrote:
> > SmbiosPlatformDxe is used both by Armada 7k8k and CN913x platforms.
> > Replace board name placeholder in order to avoid confusion.
>
> Stupid/lazy question - do we already specify the actual platform name
> elsewhere?

No. My plan is to enable SMBIOS customization via board description
library / protocol. I just came up on an easy idea to use PCD for
platform name. If that's ok for you, I'll refactor to it in v2.

Thanks,
Marcin

>
> /
>     Leif
>
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> >  Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 4 ++-=
-
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformD=
xe.c b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > index 08f4fa7..cdacd90 100644
> > --- a/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > +++ b/Silicon/Marvell/Drivers/SmbiosPlatformDxe/SmbiosPlatformDxe.c
> > @@ -102,7 +102,7 @@ STATIC SMBIOS_TABLE_TYPE1 mArmadaDefaultType1 =3D =
{
> >
> >  STATIC CHAR8 CONST *mArmadaDefaultType1Strings[] =3D {
> >    "Marvell                        \0",/* Manufacturer */
> > -  "Armada 7k/8k Family Board      \0",/* Product Name placeholder*/
> > +  "Marvell Development Board      \0",/* Product Name placeholder*/
> >    "Revision unknown               \0",/* Version placeholder */
> >    "                               \0",/* 32 character buffer */
> >    NULL
> > @@ -130,7 +130,7 @@ STATIC SMBIOS_TABLE_TYPE2 mArmadaDefaultType2 =3D =
{
> >
> >  STATIC CHAR8 CONST *mArmadaDefaultType2Strings[] =3D {
> >    "Marvell                        \0",/* Manufacturer */
> > -  "Armada 7k/8k Family Board      \0",/* Product Name placeholder*/
> > +  "Marvell Development Board      \0",/* Product Name placeholder*/
> >    "Revision unknown               \0",/* Version placeholder */
> >    "Serial Not Set                 \0",/* Serial */
> >    "Base of Chassis                \0",/* Board location */
> > --
> > 2.7.4
> >
> >
> >=20
> >