From: Marcin Wojtas <mw@semihalf.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
nadavh@marvell.com, Neta Zur Hershkovits <neta@marvell.com>,
Kostya Porotchkin <kostap@marvell.com>,
Hua Jing <jinghua@marvell.com>,
semihalf-dabros-jan <jsd@semihalf.com>
Subject: Re: [platforms: PATCH 2/4] Marvell/Armada: Fix watchdog control base
Date: Fri, 1 Dec 2017 14:57:55 +0100 [thread overview]
Message-ID: <CAPv3WKecCcyVYrMt_sp=VZu7VNX0bd-zRR_bstAAcJEyXjwqXQ@mail.gmail.com> (raw)
In-Reply-To: <20171201131952.4xalq43sehniptdr@bivouac.eciton.net>
2017-12-01 14:19 GMT+01:00 Leif Lindholm <leif.lindholm@linaro.org>:
> On Fri, Dec 01, 2017 at 03:28:52AM +0100, Marcin Wojtas wrote:
>> Proper watchdog control base is 0xf0610000, so fix the
>> incorrect value.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>> ---
>> Platform/Marvell/Armada/Armada.dsc.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc
>> index 1b68ef3..cf81615 100644
>> --- a/Platform/Marvell/Armada/Armada.dsc.inc
>> +++ b/Platform/Marvell/Armada/Armada.dsc.inc
>> @@ -269,7 +269,7 @@
>> gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000
>>
>> # ARM SBSA Watchdog
>> - gArmTokenSpaceGuid.PcdGenericWatchdogControlBase|0xF0620000
>> + gArmTokenSpaceGuid.PcdGenericWatchdogControlBase|0xF0610000
>
> Hmm, do we never start the watchdog, or how did we not notice this?
> I can confirm against the docs that the fix is correct, so:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
The problem was noticed when running SBSA test suite on a branch
already equipped with ACPI support.
Marcin
next prev parent reply other threads:[~2017-12-01 13:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 2:28 [platforms: PATCH 0/4] Armada 7k/8k - misc improvements pt.3 Marcin Wojtas
2017-12-01 2:28 ` [platforms: PATCH 1/4] Marvell/Armada: Switch to dynamic tftp command Marcin Wojtas
2017-12-01 13:04 ` Leif Lindholm
2017-12-01 13:56 ` Marcin Wojtas
2017-12-01 2:28 ` [platforms: PATCH 2/4] Marvell/Armada: Fix watchdog control base Marcin Wojtas
2017-12-01 13:19 ` Leif Lindholm
2017-12-01 13:57 ` Marcin Wojtas [this message]
2017-12-01 2:28 ` [platforms: PATCH 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information Marcin Wojtas
2017-12-01 13:27 ` Leif Lindholm
2017-12-01 15:00 ` Marcin Wojtas
2017-12-01 2:28 ` [platforms: PATCH 4/4] Marvell/Drivers: MvPhyDxe: Cleanup the header Marcin Wojtas
2017-12-01 13:09 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPv3WKecCcyVYrMt_sp=VZu7VNX0bd-zRR_bstAAcJEyXjwqXQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox