From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2B17022183C63 for ; Fri, 1 Dec 2017 05:53:30 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id o130so4303046itg.0 for ; Fri, 01 Dec 2017 05:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=En+c9ioONeuDIwtUOyOCF6seBlPVvvMSZS07VLXLXBs=; b=aI+0jRA00GO8NlQ9y+jcoV6bX4ldj874viDGwCKwg2givytlVPYg1JRsiBUptr7ld0 8M5BBu2P5U7y9bs8eVB7Mo65UJJh1KI8No0Ep+tZ4ky4NJGyB/GVtMOKzqahzBLlhf7A QYUC7fg7vsj3hLTgsF85eKIBMRLu3jRyhs5q3snzvb/SXvLFe0ggAaLhV37B1D3p6mDX HPpQM6HMpPOGbUybTz4hTEDayfEZ66CJL0yuWRCBemghHtuQe6CyExvacwy9Onmq8H+O xAQo25jCAO3Omk33EUeAuUAA3xojb891x/Fs8v0IWRx62uxTn6wPTFDJt+137P3gO6JA KZKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=En+c9ioONeuDIwtUOyOCF6seBlPVvvMSZS07VLXLXBs=; b=YWRjpgCoD4o2HXMu2EQYXQR3i/NemnOs/2A0NuXTaRe/SoLZpoAOJ7qWxaCZDGNWwR uy8P6k/0NGKYzMnL2RgrfThK1TbNhgv8n4Tl1tFF6LFSn+9QeVcIzLZF359Lmuqkuru+ +H3He3Au1wHFJj2Q37lO6Bwjdl35sf27s73tB/pbGPnIaFN/fTLgZS0bXAXZD1tGzaDg 4soug0j/ZtI8OyGUrXMglur6MEmr7r80J0UklHh3A9nOn19RF7aebiXB26SIEKcj5aGo +W4mbt2jqjNwePaHX9UqITSxxYpXgkkWBNkTHtdgc7z0z9L2/LGJjfj7AFI5lDsQ8/HJ lhIw== X-Gm-Message-State: AKGB3mJw4GjlnblF1jDYekRXdWcIdxVstN2EXNKahJjT2GLmCcOlDBEV PM4YcGMJQHrZioLDFwEWmLF3pa+jn74PGWr0vZzqiw== X-Google-Smtp-Source: AGs4zMbX2suscJxzwphw9AyS3RKYeBGdujq3yKv9fXOEgUCpis//9OhjHwu+ZHvl9ZcBPb9UW+gYC33gsV9NBYyADPM= X-Received: by 10.36.238.73 with SMTP id b70mr1780933iti.127.1512136676089; Fri, 01 Dec 2017 05:57:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.132.164 with HTTP; Fri, 1 Dec 2017 05:57:55 -0800 (PST) In-Reply-To: <20171201131952.4xalq43sehniptdr@bivouac.eciton.net> References: <1512095334-20345-1-git-send-email-mw@semihalf.com> <1512095334-20345-3-git-send-email-mw@semihalf.com> <20171201131952.4xalq43sehniptdr@bivouac.eciton.net> From: Marcin Wojtas Date: Fri, 1 Dec 2017 14:57:55 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 2/4] Marvell/Armada: Fix watchdog control base X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 13:53:30 -0000 Content-Type: text/plain; charset="UTF-8" 2017-12-01 14:19 GMT+01:00 Leif Lindholm : > On Fri, Dec 01, 2017 at 03:28:52AM +0100, Marcin Wojtas wrote: >> Proper watchdog control base is 0xf0610000, so fix the >> incorrect value. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas >> --- >> Platform/Marvell/Armada/Armada.dsc.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc >> index 1b68ef3..cf81615 100644 >> --- a/Platform/Marvell/Armada/Armada.dsc.inc >> +++ b/Platform/Marvell/Armada/Armada.dsc.inc >> @@ -269,7 +269,7 @@ >> gEmbeddedTokenSpaceGuid.PcdMetronomeTickPeriod|1000 >> >> # ARM SBSA Watchdog >> - gArmTokenSpaceGuid.PcdGenericWatchdogControlBase|0xF0620000 >> + gArmTokenSpaceGuid.PcdGenericWatchdogControlBase|0xF0610000 > > Hmm, do we never start the watchdog, or how did we not notice this? > I can confirm against the docs that the fix is correct, so: > Reviewed-by: Leif Lindholm > The problem was noticed when running SBSA test suite on a branch already equipped with ACPI support. Marcin