From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ACC0421B02822 for ; Tue, 20 Nov 2018 17:26:36 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id m15so6625824itl.4 for ; Tue, 20 Nov 2018 17:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hT3J7L/+4lAoqTzI3BdBlUkVShyB6fyTD+FlCCOm6QM=; b=EtCp4LI7Dn7mETwS0sd0TbUkSLNjGOe/R26iUnW1Fb6D583yS9mhqOExMvLIUJGLO+ ChXadX+tc6MBVyoN32hM7721L7XYpWDZn2wiJP0Vsq/d5jcYKZjCSaRK1FxQ3c6hL1dY LCjjJFxG8X1NRZ+Nz2pM4yTXi+fYuOgNA9ouNTOSs+r3y7fFutkd9fVJZgy/n0z1d72W JmVcRi43Y3GHoJKzootW9aqBgSBwm/iqrsA2zmV/iAhpVpDqe2Hoft+4OCO98morYN9f jaDfVfhVWO3ByQfAal9i2pUvhY1zjEmj/daDWRJbcFjR3gcSYlScz5GvfFnrHGdCG3Q4 CBrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hT3J7L/+4lAoqTzI3BdBlUkVShyB6fyTD+FlCCOm6QM=; b=bNIfnZJg4pArWzdfmAt/cdcEGK2TeJQnAw6eEQqJMHsDj1M8qt5E48a7npp7jKvTsg 4Hn00WjTVW803Hjr7EocRfUcXksiqmRBphSDRqIpGTa4Rkxaa2RMC00u3kyorubg6W0j U8OP83mDmwDGpTnnA7vmombwcrkk7xvj6aZZoLCNoa3wAY/51/nuw3UBeJfep9X1RrMU LMEiBsjFJlOYGi3T1SiHL1+ohffe6h2zTi9+nAXMd3upWWtUpyKXgfntwcxqNJJM+vuZ zZIMHyKiz0QPmJAG4aNHbrIJTzlWy7Kawo3bb+4rhROeo4Z66fO1X+hMx4fb8HhZpXAu Kj7w== X-Gm-Message-State: AGRZ1gLMCz7DXifsJUDa52lQPeIDbl4o8z9hYnhAl4y4dEDAtmj5sXvv HvvBsaz3918ZPSlUI6zHxeKfxSuDTIvpMeizw96PUQ== X-Google-Smtp-Source: AFSGD/UpIk2KgrDMhCh0cgfcJ2W614zpBPcFHYYRJbEUox8XlGfvDXSq7Jx/KfJUD06/pXRiFQ9JP36WNFpw6qjLea0= X-Received: by 2002:a02:7696:: with SMTP id z144mr3807767jab.102.1542763595233; Tue, 20 Nov 2018 17:26:35 -0800 (PST) MIME-Version: 1.0 References: <1540000661-1956-1-git-send-email-mw@semihalf.com> <1540000661-1956-2-git-send-email-mw@semihalf.com> <20181114011044.inajftqy7qmfq7n3@bivouac.eciton.net> <20181114173339.edjjmygvmrirtzvc@bivouac.eciton.net> In-Reply-To: <20181114173339.edjjmygvmrirtzvc@bivouac.eciton.net> From: Marcin Wojtas Date: Wed, 21 Nov 2018 02:26:23 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Subject: Re: [platforms: PATCH 01/12] Marvell/Library: ArmadaSoCDescLib: Add GPIO information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 01:26:36 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Leif, =C5=9Br., 14 lis 2018 o 18:33 Leif Lindholm napi= sa=C5=82(a): > > On Wed, Nov 14, 2018 at 07:05:01AM +0100, Marcin Wojtas wrote: > > > I think all of my comments on this patch can be summarised as "what i= s > > > an AP in this context"? > > > > > > The term either needs explicit documenting, or expansion in the macro > > > names such that documentation is not required. > > > > Isn't a glossary on top of this file: > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8f= f9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/A= rmada7k8kSoCDescLib/Armada7k8kSoCDescLib.h#L13 > > and C file: > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/blob/8f= f9b13675a401588d3cc999aef9891838047b18/Silicon/Marvell/Armada7k8k/Library/A= rmada7k8kSoCDescLib/Armada7k8kSoCDescLib.c#L13 > > sufficient? > > I will confess I missed that. But that also clearly shows the problem. > > The glossary in is sufficient according to the coding style. > But it gets confusing, specifically for the abbreviation "AP", since > this has a specific (and different) meaning in PI. > Xenon is in, so we can focus on the GPIO ;) I will use AP806 in order to avoid confusion. Please don't mind my ignorance - what is the default 'AP' meaning? BoardDesc library patches will be affected when rebasing onto latest merged patches - should I resend v2 or wait for more remarks? Thanks, Marcin