From: Marcin Wojtas <mw@semihalf.com>
To: "Carsey, Jaben" <jaben.carsey@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Tian, Feng" <feng.tian@intel.com>,
"leif.lindholm@linaro.org" <leif.lindholm@linaro.org>,
"Gao, Liming" <liming.gao@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 2/2] ShellPkg/Ifconfig: Enable setting MAC address
Date: Mon, 7 Nov 2016 12:54:34 +0100 [thread overview]
Message-ID: <CAPv3WKeg6gYsxY9EVm7+z+=OKjw19fF=6u6Bf3mpyMnNA1GFcA@mail.gmail.com> (raw)
In-Reply-To: <CB6E33457884FA40993F35157061515C54ABDA19@FMSMSX103.amr.corp.intel.com>
Hi Jaben,
2016-11-04 21:38 GMT+01:00 Carsey, Jaben <jaben.carsey@intel.com>:
> I think this is a good idea. But I see 2 issues.
> 1 - ifconfig standard parameters are controlled by the UEFI Shell Specification. If you want to extend the parameters you need to use parameters that start with underscore. I do not quite know how to so this under the "-s" set of functions for this command. Maybe just add this separate from "-s", using something like "-_mac"?
No, problem. Since this will be an additional parameter in
mIfConfig[6]CheckList, and all consist of single letter, I propose
"-_m". Is it ok?
> 2 - whatever change is done here should also be done to the ipv6 version of the command.
>
Ok, I can see it should be not much than simple copy-paste.
Best regards,
Marcin
next prev parent reply other threads:[~2016-11-07 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 18:28 [PATCH 0/2] MAC address configuration from Shell Marcin Wojtas
2016-11-04 18:28 ` [PATCH 1/2] MdeModulePkg: NetLib: introduce MAC address handling helper routines Marcin Wojtas
2016-11-04 18:28 ` [PATCH 2/2] ShellPkg/Ifconfig: Enable setting MAC address Marcin Wojtas
2016-11-04 20:38 ` Carsey, Jaben
2016-11-07 11:54 ` Marcin Wojtas [this message]
2016-11-07 18:16 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPv3WKeg6gYsxY9EVm7+z+=OKjw19fF=6u6Bf3mpyMnNA1GFcA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox