From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1F61581DBD for ; Mon, 7 Nov 2016 03:54:33 -0800 (PST) Received: by mail-it0-x231.google.com with SMTP id u205so123157417itc.0 for ; Mon, 07 Nov 2016 03:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AM17ConPkPt5Xv1bISKxE3u7SujtWyzxiIKb16NEqUQ=; b=YILgMK+WuA83/ywDeSHWgqhkym5muyuK7T/iaV97l4eyBsBG1UiujYAY6TUEZJ9p4j gamBsDvX9tHf3MqwUTdnfr959Z42XLKE3efvsAtJ+jqqHrTeoFRMh37rVcryJNJbqNzh OJamzCpO9NzfiDeAw/+Ki6iWBbtlUrpNAS7kLrV6RH1mwKXXZdBL5vzIzfFmXW3YQBcx PSTfeWyGeo+jSSasd/8BPcQdwjs3BGrCMj5T6ZRCcYEYm7vPHTSOpcr3PyEkbErtcOfP NCMKyBMQTXrnPRbVwfF+3vkRylRy/vOHhfUP9Kl0TMUKP90bFu6tRHcYxIhcoBcSDqP4 n+Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AM17ConPkPt5Xv1bISKxE3u7SujtWyzxiIKb16NEqUQ=; b=BeUroqWZNz34jg4R22uKKD4PpNx2w/oWoewO9S6fSVY6Oc6OfphFW2wzHo6DOJ5/i9 HNqKRld/D9qf35ZffXd+YRuro+vohb0NqYgMOR8zaFP9S3yCVS+6tKFJKwsjFFoTwUgl J/hAbRttsmG/bzpTF9MqVGiqzY88tmMwEOwSdNoRYnEy9cnpqMsIZD6WlQoobc15Gl/0 pYiy4KKItPUKeEQGVbh39Ra5uJ94yRznMyFNHCqMnbnJUG9EYNh+k8xoksciAJJUh6eh Hw14ZFjfoF8n6nEIg0abrGNDvomVDcI0MlK3CfM1ugD6+yN3+cLHEg/pJYf0fET5voDY f/Uw== X-Gm-Message-State: ABUngvcCc3kGWQ/gnhvEIQr0h/uOTMynbvx8HGQm43omVhTiMq8y7cRrs3jn6ShehEBCUGGnmfe41apVZ+5WjQ== X-Received: by 10.36.58.68 with SMTP id m65mr4032657itm.45.1478519675296; Mon, 07 Nov 2016 03:54:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.25.140 with HTTP; Mon, 7 Nov 2016 03:54:34 -0800 (PST) In-Reply-To: References: <1478284123-4355-1-git-send-email-mw@semihalf.com> <1478284123-4355-3-git-send-email-mw@semihalf.com> From: Marcin Wojtas Date: Mon, 7 Nov 2016 12:54:34 +0100 Message-ID: To: "Carsey, Jaben" Cc: "edk2-devel@lists.01.org" , "Tian, Feng" , "leif.lindholm@linaro.org" , "Gao, Liming" , "Kinney, Michael D" Subject: Re: [PATCH 2/2] ShellPkg/Ifconfig: Enable setting MAC address X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 11:54:33 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Jaben, 2016-11-04 21:38 GMT+01:00 Carsey, Jaben : > I think this is a good idea. But I see 2 issues. > 1 - ifconfig standard parameters are controlled by the UEFI Shell Specifi= cation. If you want to extend the parameters you need to use parameters th= at start with underscore. I do not quite know how to so this under the "-s= " set of functions for this command. Maybe just add this separate from "-s= ", using something like "-_mac"? No, problem. Since this will be an additional parameter in mIfConfig[6]CheckList, and all consist of single letter, I propose "-_m". Is it ok? > 2 - whatever change is done here should also be done to the ipv6 version = of the command. > Ok, I can see it should be not much than simple copy-paste. Best regards, Marcin