From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::d2f; helo=mail-io1-xd2f.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 33DCA2116747F for ; Thu, 11 Oct 2018 22:33:38 -0700 (PDT) Received: by mail-io1-xd2f.google.com with SMTP id y10-v6so8376704ioa.10 for ; Thu, 11 Oct 2018 22:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=8M1NAaGi8PRR+XLy6EndY8haUr7KjPF3PVRAFn1XrRw=; b=e4bEJPn9JDY1zEfFBEgOtqmZY5XjQ4METSjhqy2rDB9fuTaSHybVygP/9tPNl3qqiY JYUNnOPjlExlF/P+1pVSm24GC6Z/STu00CXJ1/Ck4Lh8ZI1H7q7AKO9iJLIO64sIuZt+ cThvG/MPzsBKB0keu035Tp9s8YvBxe4yCFWSkivc6PaBFyhFL9Ld0cIriR2B50e6FEdI +hP0T+DD1RE6QUKWpz+J9N326bNnHn/XfwMlrJvvqY+PbZk01gljAMQYOaHEonZT1gGE fqwl6a9JUiRk6m3+QANTngpBCaQxtQM6fPiFNA48ZANbnuvKG4L+VpNT5YNtKXNWNvOv pdoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=8M1NAaGi8PRR+XLy6EndY8haUr7KjPF3PVRAFn1XrRw=; b=fvcGod0RiHDh+Pb8KepZA1Qv+if3Jl+z8eEAn9D5D4Ni1lXhTiXPR6ROuoN5ZHaR15 SG0mrN4vGUuQrFMGR348qfuAdjUhkGWIYZ7w15mZ5wCW2hOWvOe6vCijG+CDIgrL2jdo giUNRjy/Rap9Mo5o/sni8wkeMk+LYMzqyt/ioaAjyUNuV1o79vXM8tqvDUxPFG40CqEO Eo7EXp9OgyL4ey/3ZqEMlEpiK8PmtBIcRX3X2iRqL4CmDzkZ30PO92ZpXFNrIdh2yvF5 WRl56mg/ctCIJqF4XLGYr10QsDM/AOvPTKzE0K5rSTuGXItkTGpAck8rb0SJZycT4yE0 on6Q== X-Gm-Message-State: ABuFfohfD20pA/00NLXf8ZRU1x1HBN0VnhCzj5lBhJlYQo+XQAAIisUi dzta1oIDhrHBRCq6vARweq3QKmR6S4EPAYu3OV/oiA== X-Google-Smtp-Source: ACcGV63Sq7KE5OFFRu65Lmzf4LVlQb18uL9t9ow4HGGTyz/MgaHwLKxW49Oounw9UQvY1r2Cg6InhX+XlMncz4wgNnE= X-Received: by 2002:a6b:7e0c:: with SMTP id i12-v6mr3397577iom.221.1539322417396; Thu, 11 Oct 2018 22:33:37 -0700 (PDT) MIME-Version: 1.0 References: <1538745911-22484-1-git-send-email-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Fri, 12 Oct 2018 07:33:26 +0200 Message-ID: To: hao.a.wu@intel.com Cc: edk2-devel-01 , "Tian, Feng" , "Kinney, Michael D" , "Gao, Liming" , Leif Lindholm , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Tomasz Michalec Subject: Re: [PATCH v2 0/4] SdMmcOverride extension X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Oct 2018 05:33:38 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Hao, pt., 12 pa=C5=BA 2018 o 07:25 Wu, Hao A napisa=C5=82(a= ): > > Hi Marcin, > > Please grant me some time for this series. > > Since I found that the extension of the SdMmc override protocol (mainly > the 3rd and 4th patch of the series) may have something overlaps with a > (internal) request to configure the driver strength parameter and operati= ng > clock frequency of the SD/EMMC devices. > > For the (driver strength/operating freq) customize, we already have a > proposal on the way. So I am wondering if you could grant me some time to > investigate whether both the cases can be addressed together based on you= r > proposed patch. > Sure. I'm only wondering if it's not best to collect all remarks and maybe update to v3 both edk2 and edk2-platforms sides (so far the issues have been not critical, such as typos, parameters' names, etc.). In the meantime you would be able to validate if the solution is sufficient for you as well. What do you think? When do you expect to be able to look at it vs your internal requirements more deeply? Best regards, Marcin > Thanks in advance. > > Best Regards, > Hao Wu > > > > -----Original Message----- > > From: Marcin Wojtas [mailto:mw@semihalf.com] > > Sent: Friday, October 05, 2018 9:25 PM > > To: edk2-devel@lists.01.org > > Cc: Tian, Feng; Kinney, Michael D; Gao, Liming; leif.lindholm@linaro.or= g; Wu, > > Hao A; ard.biesheuvel@linaro.org; nadavh@marvell.com; > > mw@semihalf.com; jsd@semihalf.com; tm@semihalf.com > > Subject: [PATCH v2 0/4] SdMmcOverride extension > > > > Hi, > > > > This is the second version of the patchset. Initial one was > > interleaved with the fixes, which after split got already merged. > > The biggest change is - resigning from the new callbacks > > and extending parameter lists of both NotifyPhase and Capability > > routines. > > > > Patches are available in the github: > > https://github.com/MarvellEmbeddedProcessors/edk2-open- > > platform/commits/sdmmc-override-upstream-r20181005 > > > > Please note that extending SdMmcOverride protocol was impacting > > so far the only user of it (Synquacer controller). In paralel > > edk2-platforms patchset, a patch can be found: > > ("Silicon/SynQuacer/PlatformDxe: adjust to updated SdMmcOverride") > > which immunizes for above and future extensions of the protocol: > > https://github.com/MarvellEmbeddedProcessors/edk2-open- > > platform/commits/xenon-upstream-r20181005 > > > > I'm looking forward to the comments and remarks. > > > > Best regards, > > Marcin > > > > Changelog: > > v1 -> v2 > > * Rebase onto newest master > > * 1/4 [new patch] - preparation for extending NotifyPhase > > * 2/4 - UhsSignaling as a part of NotifyPhase > > * 3/4 - SwitchClockFreqPost as a part of NotifyPhase > > * 4/4 - Allow updating BaseClkFreq via Capability instead of the > > independent callback. > > > > Marcin Wojtas (2): > > MdeModulePkg/SdMmcPciHcDxe: Add an optional parameter in > > NotifyPhase > > MdeModulePkg/SdMmcPciHcDxe: Allow overriding base clock frequency > > > > Tomasz Michalec (2): > > MdeModulePkg/SdMmcPciHcDxe: Add UhsSignaling to SdMmcOverride > > protocol > > MdeModulePkg/SdMmcPciHcDxe: Add SwitchClockFreqPost to > > SdMmcOverride > > > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 6 + > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h | 62 +++++- > > MdeModulePkg/Include/Protocol/SdMmcOverride.h | 12 +- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c | 215 > > ++++++++++++++------ > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c | 57 +++++- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 18 +- > > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 108 ++++++++- > > - > > 7 files changed, 383 insertions(+), 95 deletions(-) > > > > -- > > 2.7.4 >