* [PATCH edk2-platforms 1/1] Silicon/Marvell: Fix setting I2cStatus in MvI2cEnableConf
@ 2023-05-10 15:37 Rebecca Cran
2023-05-10 21:56 ` Marcin Wojtas
0 siblings, 1 reply; 3+ messages in thread
From: Rebecca Cran @ 2023-05-10 15:37 UTC (permalink / raw)
To: devel, Marcin Wojtas, Leif Lindholm; +Cc: Rebecca Cran
Fix setting I2cStatus in MvI2cEnableConf.
Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c b/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
index b4dda56bbd2f..a8ff722aab22 100755
--- a/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
+++ b/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
@@ -777,7 +777,7 @@ MvI2cEnableConf (
{
/* do nothing */
if (I2cStatus != NULL)
- I2cStatus = EFI_SUCCESS;
+ *I2cStatus = EFI_SUCCESS;
if (Event != NULL)
gBS->SignalEvent(Event);
return EFI_SUCCESS;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH edk2-platforms 1/1] Silicon/Marvell: Fix setting I2cStatus in MvI2cEnableConf
2023-05-10 15:37 [PATCH edk2-platforms 1/1] Silicon/Marvell: Fix setting I2cStatus in MvI2cEnableConf Rebecca Cran
@ 2023-05-10 21:56 ` Marcin Wojtas
2023-05-10 22:37 ` Rebecca Cran
0 siblings, 1 reply; 3+ messages in thread
From: Marcin Wojtas @ 2023-05-10 21:56 UTC (permalink / raw)
To: Rebecca Cran; +Cc: devel, Leif Lindholm
śr., 10 maj 2023 o 17:38 Rebecca Cran <rebecca@bsdio.com> napisał(a):
>
> Fix setting I2cStatus in MvI2cEnableConf.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c b/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
> index b4dda56bbd2f..a8ff722aab22 100755
> --- a/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
> +++ b/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
> @@ -777,7 +777,7 @@ MvI2cEnableConf (
> {
> /* do nothing */
> if (I2cStatus != NULL)
> - I2cStatus = EFI_SUCCESS;
> + *I2cStatus = EFI_SUCCESS;
> if (Event != NULL)
> gBS->SignalEvent(Event);
> return EFI_SUCCESS;
> --
> 2.39.2
>
Reviewed-by: Marcin Wojtas <mw@semihalf.com>
Thanks!
Marcin
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH edk2-platforms 1/1] Silicon/Marvell: Fix setting I2cStatus in MvI2cEnableConf
2023-05-10 21:56 ` Marcin Wojtas
@ 2023-05-10 22:37 ` Rebecca Cran
0 siblings, 0 replies; 3+ messages in thread
From: Rebecca Cran @ 2023-05-10 22:37 UTC (permalink / raw)
To: Marcin Wojtas; +Cc: devel, Leif Lindholm
Pushed as 1f8ff3b1c03fab1fc5af285c2d939904e560c1c2.
On 5/10/23 15:56, Marcin Wojtas wrote:
> śr., 10 maj 2023 o 17:38 Rebecca Cran <rebecca@bsdio.com> napisał(a):
>> Fix setting I2cStatus in MvI2cEnableConf.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
>> ---
>> Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c b/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
>> index b4dda56bbd2f..a8ff722aab22 100755
>> --- a/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
>> +++ b/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
>> @@ -777,7 +777,7 @@ MvI2cEnableConf (
>> {
>> /* do nothing */
>> if (I2cStatus != NULL)
>> - I2cStatus = EFI_SUCCESS;
>> + *I2cStatus = EFI_SUCCESS;
>> if (Event != NULL)
>> gBS->SignalEvent(Event);
>> return EFI_SUCCESS;
>> --
>> 2.39.2
>>
> Reviewed-by: Marcin Wojtas <mw@semihalf.com>
>
> Thanks!
> Marcin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-10 22:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-10 15:37 [PATCH edk2-platforms 1/1] Silicon/Marvell: Fix setting I2cStatus in MvI2cEnableConf Rebecca Cran
2023-05-10 21:56 ` Marcin Wojtas
2023-05-10 22:37 ` Rebecca Cran
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox