From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::844; helo=mail-qt1-x844.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 62A96211BA46B for ; Thu, 31 Jan 2019 04:06:30 -0800 (PST) Received: by mail-qt1-x844.google.com with SMTP id u47so3130699qtj.6 for ; Thu, 31 Jan 2019 04:06:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4mSp/YhTaUeYRqAn92NtFBTHef4M7UL7uFSzpzVFXPk=; b=GdioJnw4GvYrR6VIBYzNiDyMAEAqblToygUd3OrIBYszIuUPZAoQ6T0d/AF58WPIy2 1z7XJ5jJESHQ/LJL2SAwbQAkbryuyhemv1Z0i33gSLdm6DlLw0IFBIPZH6fVNoBb/Orb SO2f65rAmba61qk3NdZjOpEGi2WMxPVmokdyyzZWtRT6bMLu2smyeRaubWrfh/jsSS4j OlNvoq60iIOOTIcS08hM7QVcOfevFSHUCSA4knAsgFyqwlH7IxGgwxU1aJxDTmHyBPX2 9SubdB8Bb+VvbORL/Phb+Q6Qi70WRcWuudnpJ0KE5X7Tb4ijZnQp6K+NfyR69Ghaj0Jc fdPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4mSp/YhTaUeYRqAn92NtFBTHef4M7UL7uFSzpzVFXPk=; b=nQpJJCM2LIcx6Aie0nwekcDQeHWxksz9ypJuvUgQbSHKLqsiCkxE/7MjKNNXM4qA/K +WeeTVcK1o+PZjFbXfmXq25KM10xEugb4k69sY1Of3IigG9TmTA+rjlCGWKf+BxKRuJE oP+Rk+d9K/pDl212wc+NpCDUre4DyAdy7RPU+b5vApm7KNPnfx15AUB+CUISkgOQqD+o TzQp3TLiFPOdlPul/m4CtA8mnKQQAzsPWNC0DToVH3ruh71YQwKjbc/TaT9dVqUwVoOG 1IUhF/6yp3AbNHrpN1gIR6ow4OYGVD/xB4/8waiwFkcs7vqq9X6YoDeCRVD0WV61+B7y xW8g== X-Gm-Message-State: AJcUukcM+wqvGjNxM0IVnP3vqO7BDJCR2RW+1eOhCSWuYZIIW15o1ZRb geafILFuz4EeFzmVzups0zQQfaObQ8WhtR2+WwPgoA== X-Google-Smtp-Source: ALg8bN7sRj+ecMmHj4gh1txrgCHS/OSrl/rgRIN0p5HYOLg81PVJJQV/p8HWOvvpKz+kJbJrqNDacq6haasuVwLm+jw= X-Received: by 2002:a0c:80a8:: with SMTP id 37mr32845967qvb.191.1548936388996; Thu, 31 Jan 2019 04:06:28 -0800 (PST) MIME-Version: 1.0 References: <1548668715-15042-1-git-send-email-mw@semihalf.com> <20190130164737.glko5nprvhfcy7ap@bivouac.eciton.net> <20190131102759.fsww3vevkktmxse7@bivouac.eciton.net> In-Reply-To: <20190131102759.fsww3vevkktmxse7@bivouac.eciton.net> From: Marcin Wojtas Date: Thu, 31 Jan 2019 13:06:15 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Subject: Re: [platforms: PATCH v3 0/5] Armada7k8k memory handling update X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jan 2019 12:06:30 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable czw., 31 sty 2019 o 11:28 Leif Lindholm napisa= =C5=82(a): > > On Thu, Jan 31, 2019 at 08:01:08AM +0100, Marcin Wojtas wrote: > > Hi Leif, > > > > Thanks a lot. While at it - do you think ArmPkg/Include/Library/ArmLib.= h > > / ArmPkg/Library/ArmLib/ArmLib.c would be a proper place for it? > > As good a place as any. While not ARM-architecture specific, I feel > it's probably ARM-platform specific. > > I mean, hopefully we'll some day we'll get a sane reporting mechanism > of Secure-reserved regions by ARM-TF and we can drop this juggling in > Non-secure firmware. > Agree on ARM-TF dependency, but the code is IMO pretty generic itself. In the merged version I also used this routine to cut out a hole in the HoB for the reason not related to NS region - therefore I think even MdePkg/Library would be good to go :) Marcin > > Best regards, > > Marcin > > > > =C5=9Br., 30 sty 2019 o 17:47 Leif Lindholm > > napisa=C5=82(a): > > > > > Thanks for the rework. > > > > > > (We should probably move that broken-out function to ArmPkg at some p= oint.) > > > > > > For the series: > > > Reviewed-by: Leif Lindholm > > > > > > Pushed as b0bb325f20..0a7d8e7d93. > > > > > > On Mon, Jan 28, 2019 at 10:45:10AM +0100, Marcin Wojtas wrote: > > > > Hi, > > > > > > > > The third version of the patchset moves the new common > > > > header for Marvell SMC ID's to the IndustryStandard directory. > > > > What is more important, now 3 regions (described by new PCDs) > > > > are reserved separately. For that purpose a preparation > > > > patch was added, which extract existing reservation code > > > > into a new subroutine. More details can be found in > > > > the changelog below and the commit messages. > > > > > > > > Patches are available in the github: > > > > > > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commi= ts/dram-upstream-r20190128 > > > > > > > > I'm looking forward to the comments and remarks. > > > > > > > > Best regards, > > > > Marcin > > > > > > > > Changelog: > > > > v2 -> v3 > > > > * 1/5 > > > > - New patch - extract memory reservation to a separate routine > > > > > > > > * 2/2 > > > > - Add new PCDs and reserve 3 regions (ARM-TF, PEI stack, OP-TEE) > > > > separately > > > > - Update commit message accordingly > > > > > > > > * 3/5 > > > > - Move MvSmc.h to Include/IndustryStandard > > > > > > > > * 4,5/5 > > > > - Add Leif's RB > > > > > > > > v1 -> v2: > > > > * 1/4 > > > > - Improve commit log - mention single area size and new PEI stack= base > > > > > > > > * 2/4 (new patch) > > > > - Add common header for Marvell SMC ID's > > > > > > > > * 3/4 > > > > - Add function description comment > > > > - Define and use ARMADA7K8K_AP806_INDEX > > > > - Change function argument to EFI_PHYSICAL_ADDRESS > > > > > > > > * 4/4 > > > > - Move new SMC ID to MvSmc.h > > > > - Include ArmadaSoCDescLib.h directly (instead indirectly via > > > BoardDesc.h) > > > > - Remove ARMADA7K8K_AP806_INDEX macro > > > > > > > > Grzegorz Jaszczyk (2): > > > > Marvell/Library: ArmadaSoCDescLib: Add North Bridge description > > > > Marvell/Armada7k8k: Read DRAM settings from ARM-TF > > > > > > > > Marcin Wojtas (3): > > > > Marvell/Armada7k8k: Refactor reserving memory regions > > > > Marvell/Armada7k8k: Shift PEI stack base and extend memory reserv= ation > > > > Marvell/Library: Introduce common header for the SMC ID's > > > > > > > > Silicon/Marvell/Marvell.dec > > > | 8 +- > > > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > > > | 16 ++- > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf > > > | 3 + > > > > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kMemoryInitPeiLib/Armada7= k8kMemoryInitPeiLib.inf > > > | 8 +- > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.= h > > > | 25 ----- > > > > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoC= DescLib.h > > > | 6 ++ > > > > Silicon/Marvell/Include/IndustryStandard/MvSmc.h > > > | 24 +++++ > > > > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h > > > | 28 +++++ > > > > Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h > > > | 8 +- > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLibMem.= c > > > | 60 ++++------- > > > > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kMemoryInitPeiLib/Armada7= k8kMemoryInitPeiLib.c > > > | 107 +++++++++++++------- > > > > > > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoC= DescLib.c > > > | 34 +++++++ > > > > Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c > > > | 14 +-- > > > > 13 files changed, 220 insertions(+), 121 deletions(-) > > > > create mode 100644 Silicon/Marvell/Include/IndustryStandard/MvSmc.= h > > > > > > > > -- > > > > 2.7.4 > > > > > > >