From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=wb2HU/84; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.195, mailfrom: mw@semihalf.com) Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by groups.io with SMTP; Thu, 08 Aug 2019 10:05:41 -0700 Received: by mail-qt1-f195.google.com with SMTP id f7so27631qtq.12 for ; Thu, 08 Aug 2019 10:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=TmAd2xVLH/crNSfajzUMkXkurFS793rJnn5ppI6pnIE=; b=wb2HU/84k9JhfOY6HAPJAYXsQwYwUNcGDRy2IyQeWAuHEg5y4zo64LAdjel3QBHvw3 MI4Y53fGakx7XKSeqF/WKHaoeeUYHeFbbweFY4MGfzKCTzQS+J38h10k+xmd+m5lhF0e ywGYvToqbeb4vuM4Sspp2jdqbwddp6BUcKFoj5LpqkmBmvCwnG0Pg/KHqbdZUNYK4O77 iq1sdaasXqtL5y2cVcTevvGpw/L7MwEuuwX0BcjymZEg7UD0CQKUSaV4F67750pvd17t 0ut48T8C1vDF4aBdvGr+QYTK+3s2eL3WHdoCjA/FAwJzgchF3jaKJsI7hDqf8PVzZbpj cXAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=TmAd2xVLH/crNSfajzUMkXkurFS793rJnn5ppI6pnIE=; b=LtGcEcJGCWXXNpwkxYIS1aZgtF/ryzXQCKYb8AqHNgk8nkWeQgY11OK765VoYH/rj7 gSTKRizkEaa0VUOKrxCW8ttr2b9wjmA0RgVoMiUSJ9HhAlw0n4vfuAB8oEr0ow/Uc9kF y5oQKr2mQfiFEFLJy33ybIq2ubtsviVUZl8tq+K3zUyw2UVav6R8xsE8G+kzjYvJ/u95 WzexDOzqv8gJu5BS9u7lwHsCaiJQOIGUZOJMK87/RYDPmZl65VOA/r1mN+n2jJ/u7Z+S P//Q2NIooGRSWOCYpNLVBAbkdTu59dZN7BRhZTQwIKnourOU0KgQm+Ly8XYmggZrXZVv CjUA== X-Gm-Message-State: APjAAAWd9QWdad/WAT9Z9X7zh3EIM2amUNjx0GlU3c/eXZXW1p1Z2K6M gU/J5YKxkwHSKgD3lErosJ7+CaipOH1dd5DtMok+kQ== X-Google-Smtp-Source: APXvYqycdCM8iv6x+MvQJidaPBmLk9h17/3alhKdCmuS0z4cOCunsvctVGFtKMbuoAoY+tBzvroOkto13WVE8zcPpDA= X-Received: by 2002:ac8:6684:: with SMTP id d4mr9075911qtp.204.1565283940277; Thu, 08 Aug 2019 10:05:40 -0700 (PDT) MIME-Version: 1.0 References: <1565220630-1653-1-git-send-email-mw@semihalf.com> <20190808115153.GX25813@bivouac.eciton.net> <20190808164822.GE25813@bivouac.eciton.net> In-Reply-To: <20190808164822.GE25813@bivouac.eciton.net> From: "Marcin Wojtas" Date: Thu, 8 Aug 2019 19:05:29 +0200 Message-ID: Subject: Re: [edk2-platforms: PATCH 0/9] Marvell Octeon CN913X SoC family support To: Leif Lindholm Cc: edk2-devel-groups-io , Ard Biesheuvel , "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable czw., 8 sie 2019 o 18:48 Leif Lindholm napisa=C5= =82(a): > > Hi Marcin. > > On Thu, Aug 08, 2019 at 03:51:15PM +0200, Marcin Wojtas wrote: > > > > This patchset adds all necessary components (.dsc/.fdf, > > > > libraries, ACPI, DT) to support all 3 variants, which > > > > are available on a modular CN913x Development Board. > > > > > > Thanks for this contribution. > > > Do you have any further information on this SoC/Devboard? > > > Searching only gets me the CN8xxx SoCs. > > > > Indeed :/ I guess there should be some public information soon, > > unfortunately I'm not in charge of it. > > > > FYI, 2 days ago the support for it was submitted to the Linux lists: > > https://www.spinics.net/lists/arm-kernel/msg746208.html > > Ah, good to know, thanks. > > > In high level this SoC is successor of Armada - enhanced modularity, > > more interfaces, higher freq, new DDR controller and so on. > > OK. Yes, I see now these platforms are implemented as overlays on top > of existing Armada DB. > > > > This does not affect Cn9132DbA, since that one does not include the > > > ACPI module. Is this intenional? > > > > > > > Maybe I should've mention this explicitly - yes, as for now we do not > > support ACPI on triple-CP115 variant. The reason is following - > > currently we have a static configuration of the ICU (CP115 interrupt > > controller) to GIC. Thanks to that, we can assign GIC interrupts in > > static ACPI tables. Unfortunately dual CP115/CP110 setup uses all > > available GIC IRQs for this. We need to create mapping only for the > > used devices and pass it to the ACPI tables. > > > > What is needed to fix it properly: > > - create ICU-GIC dynamic mapping > > - dynamically fill this information in DSDT/SSDT. > > > > > Which version of iasl has this been tested with? > > > > > > > I built it successfully with iasl versions: 20180105 and 20160108-2. > > > > Anyway, in v2 I'll shorten OEM table ID to 8 characters ( "CN9130DBA" > > is 9 character). > > OK. Working around this manually (shortening the name), the 9130 > builds fine. The 9131 needs an identical change to Ssdt.aml. > > However, all platforms still fail when I try building for ARM (which > is supported according to the .dsc files). > It seems the build fails from the missing PcdDramRemapTarget > definition, in the build of > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/ARM/ArmPlatformHelper.S > > Moreover, this also affects existing Armada70x0/80x0 platforms. > Could you look into this issue separately? Thanks for the notice, I will take a look. > > On a higher level, I confess to not being entirely convinced about the > triplicate .dsc/.dsc.inc/.fdf.inc setup. (Of the three, the .dsc.inc > is the one I object the least to.) > For the .dscs, I understand the desire to separate the build > directories, but could this be achieved with -D build flags instead? > Certainly the differences in .fdf.inc could be handled via > conditional statements determined in a single .dsc. > > If (and this is a possibility) the 3 different .dscs is the right way > forward, I still think everything other than the [defines] section > should be kept in a common .dsc.inc. > I will try the -D option. How about: - single .dsc / .fdf.inc - triple .dsc.inc (they overlap in really minimal way and show pretty good the differences between 3 variants) ? > (This quite possibly concludes my commentary on v1. Don't hold back a > v2 waiting for more.) > Ok, thanks! Marcin > Best Regards, > > Leif