From: "Marcin Wojtas" <mw@semihalf.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Leif Lindholm <leif@nuviainc.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>,
Grzegorz Jaszczyk <jaz@semihalf.com>
Subject: Re: [platforms: PATCH v2] SolidRun/Armada80x0McBin: Introduce SD/MMC ACPI description
Date: Fri, 18 Dec 2020 02:46:27 +0100 [thread overview]
Message-ID: <CAPv3WKenxmvaM798N8QTs5dpijjeFhtTt1s5M0uAtmjpFZcHwg@mail.gmail.com> (raw)
In-Reply-To: <20201120031112.24266-1-mw@semihalf.com>
Hi,
pt., 20 lis 2020 o 04:11 Marcin Wojtas <mw@semihalf.com> napisał(a):
>
> This patch adds a new description of the board's SD/MMC
> interfaces in DSDT table that can work with the newly
> introduced support in Linux.
> Remaining Armada7k8k / CN913x platforms will follow
> after this binding is accepted.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> ---
> Changelog:
> v1->v2
> * Drop 'compatible' property from MMC0 node
> * Use dedicated _HID for each variant
>
> Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 59 ++++++++++++++++++++
> 1 file changed, 59 insertions(+)
>
> diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> index 7e9e361988..9e771afc98 100644
> --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> @@ -86,6 +86,65 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> })
> }
>
> + Device (MMC0)
> + {
> + Name (_HID, "MRVL0002") // _HID: Hardware ID
> + Name (_UID, 0x00) // _UID: Unique ID
> + Name (_CCA, 0x01) // _CCA: Cache Coherency Attribute
> +
> + Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> + {
> + Memory32Fixed (ReadWrite,
> + 0xF06E0000, // Address Base (MMIO)
> + 0x00000300, // Address Length
> + )
> + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
> + {
> + 48
> + }
> + })
> + Name (_DSD, Package () {
> + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> + Package () {
> + Package () { "clock-frequency", 400000000 },
> + Package () { "bus-width", 8 },
> + Package () { "marvell,xenon-phy-slow-mode", 0x1 },
> + Package () { "no-1-8-v", 0x1 },
> + Package () { "no-sd", 0x1 },
> + Package () { "no-sdio", 0x1 },
> + Package () { "non-removable", 0x1 },
> + }
> + })
> + }
> +
> + Device (MMC1)
> + {
> + Name (_HID, "MRVL0004") // _HID: Hardware ID
> + Name (_UID, 0x01) // _UID: Unique ID
> + Name (_CCA, 0x01) // _CCA: Cache Coherency Attribute
> +
> + Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings
> + {
> + Memory32Fixed (ReadWrite,
> + 0xF2780000, // Address Base (MMIO)
> + 0x00000300, // Address Length
> + )
> + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
> + {
> + CP_GIC_SPI_CP0_SDMMC
> + }
> + })
> + Name (_DSD, Package () {
> + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> + Package () {
> + Package () { "clock-frequency", 400000000 },
> + Package () { "bus-width", 4 },
> + Package () { "broken-cd", 0x1 },
> + Package () { "no-1-8-v", 0x1 },
> + }
> + })
> + }
> +
> Device (XHC0)
> {
> Name (_HID, "PNP0D10") // _HID: Hardware ID
> --
> 2.29.0
>
The Linux part got merged. Do you have any more comments/remarks to this patch?
Best regards,
Marcin
next prev parent reply other threads:[~2020-12-18 1:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 3:11 [platforms: PATCH v2] SolidRun/Armada80x0McBin: Introduce SD/MMC ACPI description Marcin Wojtas
2020-12-18 1:46 ` Marcin Wojtas [this message]
2021-01-04 17:40 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPv3WKenxmvaM798N8QTs5dpijjeFhtTt1s5M0uAtmjpFZcHwg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox