From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::233; helo=mail-it0-x233.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4B03C21F3C18F for ; Tue, 10 Oct 2017 08:03:17 -0700 (PDT) Received: by mail-it0-x233.google.com with SMTP id f187so2903648itb.1 for ; Tue, 10 Oct 2017 08:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ctaGztGmhfbljDv6Vce1KeUjkYTSof+x7ZEhlGBCSZE=; b=WcILx5u/Ta7omnJ82s5+/GkiXg0yehyPFJ1aVVFI8OXfIq5ySMpHOibb781wTRmSrB rXiANm4z8lo21kCbTNkJPeux+JtJpTVC7+0b5FSfRFgBeFihoefJD5/bwieRGUIs0Ifj bIKnbDwkM01L/4yvlWR5UvF1q4+Ql6CKBodu3JDcNkb66FTZGfLMfZY+q35R955w+mSe epS+ybFzTV4vZTxLd41QZixFt/kvihDEQ/tscvALAlcDYRRis9YzrJKx8YO3YD3d2ixm hNMDQaVBcPrQLV5DUC6AaSdpfDwkgOa8flz4CdWENxyppwiRgopp/wYvSatQAa2lC1tm UUmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ctaGztGmhfbljDv6Vce1KeUjkYTSof+x7ZEhlGBCSZE=; b=bVrBZpZO9sJDzZtzU60qYj0YeOAhsJ6MqNASfIhaa48anwb3lohs5jFrnvCrWVdGm0 37rfd8k2KHh2H9dkuIjZ+xRfI2KicsPl6gQty46Ih0qNo1FmiG2/FrOij8MmBxzSVEG5 Pnu63zI6eAIXPQQiZUzKOgXLxE1Ee1VgRqKzsQNCMizuDlOVWA7cVnV+jvjA4DmShG69 q5d49SlBpQ28z4AplpyUngk4ekV6RmOM5FwQG0FkNaYHpf3jcO1bPlUk0lpFTQrEShFJ odJJlJOTavub6oI/3nqsydqjJeedmKQ0V3u0Z+mCoryRzjZelFN5383oddef8Kazj7PM ti4A== X-Gm-Message-State: AMCzsaV8GhqRbW+6rV+d/EFktJ90gFEN6L5IhVsJFafthCKZE0KZn0ei iJA4spb6CcPI1u4XTvfbDqvLSOvsz6sm/W8g9ynaEg== X-Google-Smtp-Source: AOwi7QA7ECvpPdH0crRWNJ8MffkDSdKYbjEup06EhvDlOj8IQb5MWjwvLtmzCQvwsFljVgEJ8shwT5uij2V6ddTypzw= X-Received: by 10.36.29.208 with SMTP id 199mr19189435itj.40.1507648003453; Tue, 10 Oct 2017 08:06:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.157.141 with HTTP; Tue, 10 Oct 2017 08:06:42 -0700 (PDT) In-Reply-To: <20171010150327.43zpe5x6gjo4umrx@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-2-git-send-email-mw@semihalf.com> <20171010143715.w4glyje3pw24kvsm@bivouac.eciton.net> <20171010150327.43zpe5x6gjo4umrx@bivouac.eciton.net> From: Marcin Wojtas Date: Tue, 10 Oct 2017 17:06:42 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 15:03:17 -0000 Content-Type: text/plain; charset="UTF-8" 2017-10-10 17:03 GMT+02:00 Leif Lindholm : > On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: >> Hi Leif, >> >> 2017-10-10 16:37 GMT+02:00 Leif Lindholm : >> > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: >> >> In order to enable modification of dynamic PCD's for the libraries >> >> and DXE drivers, this patch introduces new driver. It is >> >> executed prior to other drivers. Mpp, ComPhy and Utmi libraries >> >> initialization were moved from PrePi stage to DXE. >> >> >> >> To force the correct driver dispatch sequence, introduce a protocol GUID >> >> and install the protocol as a NULL protocol when PlatInitDxe executes. >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> Signed-off-by: Marcin Wojtas >> >> Signed-off-by: Ard Biesheuvel >> > >> > What does Ard's Signed-off-by signify here? >> > (I know the authorship on some of these is a bit blurred, since you've >> > been working together, but I'd like to be clear.) >> >> These were the lines, introducing/installing protocol GUID stuff. It >> was in a small separate patch, but I squashed it into bigger one. > > Personally, I would in this instance do: > > Ard > > > It's verbose, but reasonably clear. > How about: In order to enable modification of dynamic PCD's for the libraries and DXE drivers, this patch introduces new driver. It is executed prior to other drivers. Mpp, ComPhy and Utmi libraries initialization were moved from PrePi stage to DXE. Signed-off-by: Marcin Wojtas To force the correct driver dispatch sequence, introduce a protocol GUID and install the protocol as a NULL protocol when PlatInitDxe executes. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel Signed-off-by: Marcin Wojtas ? Was that, what you meant? >> > >> >> --- >> >> Platform/Marvell/Armada/Armada.dsc.inc | 3 ++ >> >> Platform/Marvell/Armada/Armada70x0.fdf | 5 +++ >> >> Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c | 44 ++++++++++++++++++++ >> >> Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf | 44 ++++++++++++++++++++ >> >> Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c | 11 ----- >> >> Platform/Marvell/Marvell.dec | 5 +++ >> >> 6 files changed, 101 insertions(+), 11 deletions(-) >> >> >> >> diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc >> >> index 89fb7e7..417bb0c 100644 >> >> --- a/Platform/Marvell/Armada/Armada.dsc.inc >> >> +++ b/Platform/Marvell/Armada/Armada.dsc.inc >> >> @@ -378,6 +378,9 @@ >> >> ArmPkg/Drivers/TimerDxe/TimerDxe.inf >> >> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf >> >> >> >> + # Platform Initialization >> >> + Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf >> >> + >> >> # Platform drivers >> >> Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf >> >> MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.inf >> >> diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf >> >> index c861e78..763d76a 100644 >> >> --- a/Platform/Marvell/Armada/Armada70x0.fdf >> >> +++ b/Platform/Marvell/Armada/Armada70x0.fdf >> >> @@ -89,6 +89,11 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c >> >> >> >> INF MdeModulePkg/Core/Dxe/DxeMain.inf >> >> >> >> + # >> >> + # Platform Initialization >> >> + # >> >> + INF Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf >> >> + >> >> # PI DXE Drivers producing Architectural Protocols (EFI Services) >> >> INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> >> INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> >> diff --git a/Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c b/Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c >> >> new file mode 100644 >> >> index 0000000..919454b >> >> --- /dev/null >> >> +++ b/Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c >> >> @@ -0,0 +1,44 @@ >> >> +/** @file >> >> + Copyright (C) Marvell International Ltd. and its affiliates >> > >> > We normally need a year here as well. >> > If Ard has co-authored parts, I guess we should have Linaro copyright >> > notice on affected files as well. >> >> I have no problem with that, if you find it appropriate, given my >> explanation above. > > Personally I dont mind much, but I think it would be more correct. > Ok, will add it in v2.