From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DD7B4210D852E for ; Thu, 21 Jun 2018 10:06:49 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id f1-v6so3646512ioh.6 for ; Thu, 21 Jun 2018 10:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Y4HyTTj0W2j0BQh3BMrHZZrkZDT2Wvcg6iap+XDd8ao=; b=VOmfuAZTXVkZT6Vi1PwQ1FiQeLNnkAo+k0ZkWzTzCBRfTvqaTJGGNgCjHo/bJWQVck UPIlTjA3MKWoSt8+cfHJbOAqSAjo8FuhVL1EloevPMQQTB/Kd1ukh0IJN/fWVPpv1xIU URjh+c8/iCH4ePYLqcY0zNUEfk0RRr1JHzk8a+WWwoLA6lTIzwfyxFrrAkZpe8mNZzId qqBN3ZCO30udXMgFzIAk1BJs5XabiT01SNFPSWD7ziAaSVSxKZHyCF9pK08IMPlMh0jz qm6+yLtOfvk9sPpNmgbeEmXeCumaMaxG5opOs2t0sHrZrwVacSRei8RwM3xOO32d2I4E 6lcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Y4HyTTj0W2j0BQh3BMrHZZrkZDT2Wvcg6iap+XDd8ao=; b=SjXj3vChxOspBzD2qPaoM3wx4DBSZUHKXOkLNucqHx2SN/homqCVYwte8D5q9uBVSI udW4BH/MjjraDUGeBYQfomIcyv512pPQs32YubfsquXD+3eZeaL4xryd2k5r9zFQtUc7 I4Vf5YdAMhqz6CMb7ZtXezCaGa0voA77EYG1X7UPkR+gYRgsCteOXfbP1F+rXuaIgh9w yNKhPxXL5KskCx6+EpYSTGTbALlPAjfPc5yQAGepR/PKd62otDja6FuoSUtfeZKg40a6 YZWEpl1hxWHhPpLIPh1Og9rXDvoU+XSx4a4Ab7iu6MuQ8s8AK3T5vFFVGDFpfLrnsDkH U0hg== X-Gm-Message-State: APt69E0Gj0Lhvaxovx24t/Uo2qtPwhim9ONAZQRXNrNP9fEXispmo5A/ B/Qmramltgkg7xMCuRY0GcIcCQIYPmmdA5hOEadJnA== X-Google-Smtp-Source: ADUXVKJT34kROYENbBr3XfEBeGTeJEQj0xUanwURadXIQ2klMlPbcCkguoyWaS2gpdpcppqyJch9jRGQbPMkm0TGWPI= X-Received: by 2002:a6b:9403:: with SMTP id w3-v6mr22491253iod.108.1529600809103; Thu, 21 Jun 2018 10:06:49 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:c6cc:0:0:0:0:0 with HTTP; Thu, 21 Jun 2018 10:06:48 -0700 (PDT) In-Reply-To: <20180621150612.ycpse3i2h6bq67n4@bivouac.eciton.net> References: <1529362724-9244-1-git-send-email-mw@semihalf.com> <20180621150612.ycpse3i2h6bq67n4@bivouac.eciton.net> From: Marcin Wojtas Date: Thu, 21 Jun 2018 19:06:48 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Hua Jing , semihalf-dabros-jan , Grzegorz Jaszczyk Subject: Re: [platforms: PATCH v3 00/25] Armada hardware description rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 17:06:50 -0000 Content-Type: text/plain; charset="UTF-8" 2018-06-21 17:06 GMT+02:00 Leif Lindholm : > > On Tue, Jun 19, 2018 at 12:58:19AM +0200, Marcin Wojtas wrote: > > Hi, > > > > The third version of the patchset comes with the single Signed-off-by, > > Reviewed-by's and corrected double parentheses in one of the headers. > > For the details, please check the changelog below. > > > > The patches are available in the github: > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/boarddesc-upstream-r20180619 > > > > I'm looking forward to review and any comments/remarks. > > Looks good. > Pushed as 070938aa96..5e43d10d55. Thank you, this was a huge patchset. Now only smaller will come. Thanks, Marcin > > / > Leif > > > Best regards, > > Marcin > > > > Changelog: > > v2 -> v3 > > * 1,3,4,5 > > - remove additional Signed-off-by > > > > * 1,4,8,9,10,11,12,14,15,16,17,18,19,22,23,24,25 > > - add Leif's RBs > > > > * 8,11,15,18 > > - remove double parentheses in Armada7k8kSoCDescLib.h > > > > v1 -> v2 > > * All > > - rebase on top of the master branch > > - remove internal review residues from the commit logs > > - increase all files version to 0x1A > > - use UINTN, where applicable > > - add Armada7k8kSoCDescLib definitions to a local header > > - remove assignments from variables declarations > > > > * 2,3,5-7,13,20-21 > > - Add Leif's RBs > > > > * 1 > > - add parentheses in macros > > - simplify loop and values assignments > > > > * 4 > > - add parentheses in if's > > - rename table and remove usage of MVHW_DEV_ENABLED > > - remove redundant NULL check in MvBoardDescFree () > > - add comments about using UINT8 * arrays, remove casting > > - use MV prefix in the signature > > - sort PCDs > > > > * 9 > > - drop TODO comment > > - rename table and remove usage of MVHW_DEV_ENABLED > > - add comments about using UINT8 * arrays, remove casting > > > > * 11 > > - simplify ArmadaSoCDescXhciGet > > > > * 12 > > - remove TODO in comment > > - sort variables, PCDs and assignments > > - add comments about UINT8 arrays, remove casting > > - rename table and remove usage of MVHW_DEV_ENABLED > > > > * 16 > > - remove TODO in comment > > - sort variables, PCDs and assignments > > - add comments about UINT8 arrays, remove casting > > - rename table and remove usage of MVHW_DEV_ENABLED > > > > * 22 > > - simplify loop and values assignments > > > > *23 > > - remove TODO in comment > > - sort variables, PCDs and assignments > > - add comments about UINT8 arrays, remove casting > > - rename table and remove usage of MVHW_DEV_ENABLED > > > > *25 > > - add parentheses in if condition > > > > Marcin Wojtas (21): > > Marvell/Library: Introduce ArmadaBoardDescLib class > > Marvell/Library: UtmiPhyLib: Switch to use MARVELL_BOARD_DESC protocol > > Marvell/Library: RealTimeClockLib: Simplify obtaining base address > > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with PP2 information > > Marvell/Drivers: MvBoardDesc: Extend protocol with PP2 support > > Marvell/Drivers: Pp2Dxe: Switch to use MARVELL_BOARD_DESC protocol > > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with AHCI/SDMMC/XHCI > > Marvell/Drivers: MvBoardDesc: Extend protocol with AHCI/SDMMC/XHCI > > Marvell/Drivers: NonDiscoverable: Switch to use MARVELL_BOARD_DESC > > Marvell/Library: ComPhyLib: Get AHCI data with MARVELL_BOARD_DESC > > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with ComPhy information > > Marvell/Drivers: MvBoardDesc: Extend protocol with ComPhy support > > Marvell/Library: ComPhyLib: Switch library to use MARVELL_BOARD_DESC > > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information > > Marvell/Drivers: MvBoardDesc: Extend protocol with MDIO support > > Marvell/Drivers: MvMdioDxe: Enable 64bit addressing > > Marvell/Drivers: MvMdioDxe: Switch driver to use MARVELL_BOARD_DESC > > Marvell/Armada7k8k: Extend ArmadaSoCDescLib with I2C information > > Marvell/Drivers: MvBoardDesc: Extend protocol with I2C support > > Marvell/Drivers: MvI2cDxe: Switch driver to use MARVELL_BOARD_DESC > > Marvell/Drivers: MvPhyDxe: Remove MvHwDescLib.h dependency > > > > jinghua (4): > > Marvell/Library: Introduce ArmadaSoCDescLib class > > Marvell: Introduce MARVELL_BOARD_DESC_PROTOCOL > > Marvell/Drivers: MvBoardDesc: Introduce board description driver > > Marvell/Armada7k8k: Enable board description driver compilation > > > > Silicon/Marvell/Marvell.dec | 8 +- > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 + > > Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 +- > > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc | 2 +- > > Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc | 2 +- > > Silicon/Marvell/Armada7k8k/Armada7k8k.fdf | 1 + > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf | 2 - > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf | 37 ++ > > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf | 2 +- > > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 70 +++ > > Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf | 1 + > > Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.inf | 1 + > > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 2 +- > > Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.inf | 6 +- > > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf | 6 +- > > Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 9 +- > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h | 79 +++ > > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h | 57 ++ > > Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 87 +++ > > Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 146 +++++ > > Silicon/Marvell/Include/Library/MvHwDescLib.h | 290 ---------- > > Silicon/Marvell/Include/Library/UtmiPhyLib.h | 2 + > > Silicon/Marvell/Include/Protocol/BoardDesc.h | 118 ++++ > > Silicon/Marvell/Include/Protocol/Mdio.h | 4 +- > > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h | 4 + > > Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 5 + > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 279 +++++++++ > > Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 29 +- > > Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 597 ++++++++++++++++++++ > > Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 37 +- > > Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.c | 41 +- > > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 4 +- > > Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 43 +- > > Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.c | 100 ++-- > > Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 50 +- > > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c | 74 ++- > > Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 65 +-- > > 37 files changed, 1727 insertions(+), 537 deletions(-) > > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf > > create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf > > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.h > > create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h > > create mode 100644 Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h > > create mode 100644 Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h > > delete mode 100644 Silicon/Marvell/Include/Library/MvHwDescLib.h > > create mode 100644 Silicon/Marvell/Include/Protocol/BoardDesc.h > > create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c > > create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c > > > > -- > > 2.7.4 > >