From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8B0C721A00AC9 for ; Tue, 4 Jul 2017 04:49:55 -0700 (PDT) Received: by mail-io0-x230.google.com with SMTP id z62so70345320ioi.3 for ; Tue, 04 Jul 2017 04:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=tDUaDislC4yZuaToHgn1ku+8xuLADgRItD0jwUGEnr0=; b=C2mKoF1bLmDHUHRPufNQ5a8TwxE0jlA5Zoc8t8h1SGla6noznKRIndAol/o/bihErr rjCyfcCYC6xyxPNMrD56mdUIiaBHpUh/odwjONHKGBrB1XlP8X5Mon5KNkEcp4t1JLH6 0xbU4TCgsjhhlN5rnEFg7HysgHa9YhBHEM4inTpbJy8raFwcudHHQB8vkEdzsxBDVu1M JWd/fjilQLgt7mr7sMm/wRFNI0bIHMh71RUjEyUclRXbW/nOQdyq9YCtkxueEmBDakW5 5LbS8xF0QN2zjY2MG4sc0WcvxspyoO6qDN40vDjf8CB12oLUejCRe9Kb712fDqG8dTYt lJGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=tDUaDislC4yZuaToHgn1ku+8xuLADgRItD0jwUGEnr0=; b=ObjRxIDdWnXX9so0UQ6fUtk8JvMP5HXOgr/02jBWodCAtLKpoxSWVlf64hMVHzcLBf UZLgTqj2t8TICv1zIMHmxUjOO7B0Ia/BKgFjtwufjb4w32LzX72Y2vyv1j7wH2s/kc9+ iDaRierBbsMKL9O8PY2eTqJFssm9FnZ6NjhTmdZqnCZ+12QhIuIpS5OkeLSyUasOcFwE hyg0dxAf+HV9CW7RogXO0AMkEx0ilq2XAqdDXsSLfD5jlFm+qEQMiSquZ5ZAXwk6aaRc V/knyO2yDb4JAW5qRLUxxdEMURypFu9mrc4PtBFnbn3w56KkmSKA1x+Coc6VqnDYYd8C XX7g== X-Gm-Message-State: AKS2vOzZknqWnt7w8nBCZuHTOwINfgfZQ+vq9l8c6/Wl5TdndUfsCvax ZNR0yWNhHoPsLM/JlOmuexUNIZjyIUen X-Received: by 10.107.20.72 with SMTP id 69mr38857672iou.176.1499169093110; Tue, 04 Jul 2017 04:51:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.151.16 with HTTP; Tue, 4 Jul 2017 04:51:32 -0700 (PDT) In-Reply-To: References: <20170704110017.32042-1-ard.biesheuvel@linaro.org> <20170704114126.GN26676@bivouac.eciton.net> From: Marcin Wojtas Date: Tue, 4 Jul 2017 13:51:32 +0200 Message-ID: To: Ard Biesheuvel Cc: Leif Lindholm , edk2-devel-01 Subject: Re: [PATCH] Platforms/Marvell: switch to generic ResetSystemRuntimeDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 11:49:55 -0000 Content-Type: text/plain; charset="UTF-8" 2017-07-04 13:49 GMT+02:00 Ard Biesheuvel : > On 4 July 2017 at 12:47, Marcin Wojtas wrote: >> 2017-07-04 13:41 GMT+02:00 Leif Lindholm : >>> On Tue, Jul 04, 2017 at 01:19:10PM +0200, Marcin Wojtas wrote: >>>> 2017-07-04 13:10 GMT+02:00 Ard Biesheuvel : >>>> > On 4 July 2017 at 12:04, Marcin Wojtas wrote: >>>> >> Hi, >>>> >> >>>> >> 2017-07-04 13:00 GMT+02:00 Ard Biesheuvel : >>>> >>> Switch to the generic implementation of the ResetSystem() runtime >>>> >>> service call, which is preferred over the one in EmbeddedPkg. This >>>> >>> involves selecting another DXE runtime driver, and morphing the >>>> >>> existing EfiResetSystemLib implementation into a ResetSystemLib one >>>> >>> (which is what the generic driver depends on for platform glue) >>>> >>> >>>> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>> >>> Signed-off-by: Ard Biesheuvel >>>> >>> --- >>>> >>> Platforms/Marvell/Armada/Armada.dsc.inc | 4 +- >>>> >>> Platforms/Marvell/Armada/Armada70x0.fdf | 2 +- >>>> >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.c | 110 ++++++++++++++------ >>>> >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf | 7 +- >>>> >>> 4 files changed, 87 insertions(+), 36 deletions(-) >>>> >>> >>>> >>> diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc >>>> >>> index 475fc6d05379..32eaa2942564 100644 >>>> >>> --- a/Platforms/Marvell/Armada/Armada.dsc.inc >>>> >>> +++ b/Platforms/Marvell/Armada/Armada.dsc.inc >>>> >>> @@ -94,7 +94,7 @@ >>>> >>> # Reset and Time libraries >>>> >>> EfiTimeBaseLib|OpenPlatformPkg/Library/EfiTimeBaseLib/EfiTimeBaseLib.inf >>>> >>> RealTimeClockLib|OpenPlatformPkg/Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.inf >>>> >>> - EfiResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf >>>> >>> + ResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf >>>> >> >>>> >> Isn't it better to switch to generic PSCI: >>>> >> EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf >>>> >> and remove MvResetSystemLib whatsoever? >>>> >> >>>> > >>>> > Yes. But Leif tells me that 7040 does not support PSCI? >>>> >>>> Leif, where do you have this information from? >>> >>> From the source code in OpenPlatformPkg, which does not use it and the >>> documentation that does not mention it. >> >> Ok, long time ago in early SoC revision, we PSCI was indeed broken and >> later, we were not aware of the ArmPsciResetSystemLib existence:) >> On the WIP branch, we have a replacement commit: >> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commit/b3fe877fe7207475ba293a1fc9b0a5c8f873d2c9 >> which will be submitted of course. >> > > OK. But EfiSystemResetLib and EmbeddedPkg/ResetRuntimeDxe are going > away, so this commit cannot be merged as-is. I understand, I wasn't aware of those plans. Thanks, Marcin > > But since you are saying 7040 should use PSCI, I can update the patch > and drop MvResetSystemLib entirely.