From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by mx.groups.io with SMTP id smtpd.web10.18038.1621822886101808898 for ; Sun, 23 May 2021 19:21:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=CoiMulMT; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.222.181, mailfrom: mw@semihalf.com) Received: by mail-qk1-f181.google.com with SMTP id o27so25698994qkj.9 for ; Sun, 23 May 2021 19:21:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=1+SNEDGzg8y6x6QJ94fWTLqaoBbKd/zSMHlBzA6SyLg=; b=CoiMulMTj/dzHP55TOnWMleTj4ErCi5f23cdobobYGr3xUCQ+6ZD9IGPbITidIgq8+ g0vcynB8Fd6ihtKP3gSC1ZFXccr8/S5EginA0zlDt0hXc/R0LqCL7jtVCUF8IZqMeqgf DD/kbxavDUQDQWKQHqo7T32XGiwgusopH7nRwxQbqUj5lt8djwC8AMYIBAccAE42LLJM wGYvgimrbZLOS5+bXEpuhCcETx3y3qBwYiRBDdqgkQwiXdYmlDqhHOV5ACDndmEmUDDi C+heKjue73QWVogZhS0FDwtnvw0vALZGu20gn6UpoTnmSJ2LjIXqLW1EttKfd6OQ5rbK l6Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=1+SNEDGzg8y6x6QJ94fWTLqaoBbKd/zSMHlBzA6SyLg=; b=fXQF/TZQL0y+Ul99ycf5Lh2PcTw/Euf0EASNAi5JVP71Q1tqUORpUuS0NuKLhZNwCI gVUGauKo2t1OWGUB8/OiMbeHAAycgeSL3+EDztl6S/yz4yDoK8Il+OXNlfvHScxHsuQ2 PBkpTOExYF8ovnA51N21sTM5wRKTp5E/q/NHYQZfVy+Q//xkCJysXusR/9JldpGcs8Nf cUmZ9M7DRzTZICcdMg3/A2KgtuwQXiEbEfynwzLsMD6FiSemP5aKWcWSqXgZBFBxdrVS C4J+qzeyimU2jgrnHJHH80G7NPgvM4KmL1LxtC4QNESee0GFau4UAa2g8FcVAlOwFWQ5 8uZw== X-Gm-Message-State: AOAM532KHhkTNxVxM5zPZTKk1AfQcSSOSGgGX0jqpws5h573xtfcOWbO YAb5kTvRPwRruuJiCeVe5ZflhOHzFtQQBAcEUWxdxA== X-Google-Smtp-Source: ABdhPJz5g11gtGJ8dTPzfVcHOFJ6bL0U2yAGHUMWyvQ1vUkllI4vnBi6cjMwvRBe1C1KA3vSfD+v1CySk4OB1oq49pY= X-Received: by 2002:a05:620a:f94:: with SMTP id b20mr27683070qkn.300.1621822885244; Sun, 23 May 2021 19:21:25 -0700 (PDT) MIME-Version: 1.0 References: <20210523091512.2348586-1-mw@semihalf.com> In-Reply-To: From: "Marcin Wojtas" Date: Mon, 24 May 2021 04:21:14 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 To: Sunny Wang Cc: "devel@edk2.groups.io" , "michael.d.kinney@intel.com" , "leif@nuviainc.com" , "ardb+tianocore@kernel.org" , Samer El-Haj-Mahmoud , "gjb@semihalf.com" , "upstream@semihalf.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Sunny, pon., 24 maj 2021 o 04:09 Sunny Wang napisa=C5=82(a): > > Looks good, Marcin. > However, it looks like something wrong with the line-ending. Could you ch= eck if your line-ending setting is CR/LF? Did you use /edk2/BaseTools/Scrip= ts/PatchCheck.py tool to check your patch? If not, could you use it? I expe= ct this tool can catch the line-ending problem. The line endings are fine in my repo, I generated and sent the patch as usu= al. And of course prior to sending I ran PatchCheck.py - it complains only about too long URL line in the commit message, but the line-endings are ok. $ python3 /home/mw/git/edk2-workspace/edk2/BaseTools/Scripts/PatchCheck.py = -1 Checking git commit: HEAD MdePkg: Add new 16550-compatible Serial Port Subtypes to DBG2 WARNING - Line 9 of commit message is too long (91 >=3D 76). [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-= debug-port-table The commit message format passed all checks. The code passed all checks. Do you check the line endings in a different way? Best regards, Marcin > > Best Regards, > Sunny Wang > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Marcin Woj= tas via groups.io > Sent: Sunday, May 23, 2021 5:15 PM > To: devel@edk2.groups.io > Cc: liming.gao@intel.com; michael.d.kinney@intel.com; leif@nuviainc.com; = ardb+tianocore@kernel.org; Samer El-Haj-Mahmoud ; Sunny Wang ; gjb@semihalf.com; upstream@semihalf.c= om; Marcin Wojtas > Subject: [edk2-devel] [PATCH 1/1] MdePkg: Add new 16550-compatible Serial= Port Subtypes to DBG2 > > The Microsoft Debug Port Table 2 (DBG2) specification revision May 31, 20= 17 adds support for 16550-compatible Serial Port Subtype with parameters de= fined in Generic Address Structure (GAS) [1] > > Reflect that in the EDK2 headers. > > [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acp= i-debug-port-table > > Signed-off-by: Marcin Wojtas > --- > MdePkg/Include/IndustryStandard/DebugPort2Table.h | 1 = + > MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h | 5 = +++++ > 2 files changed, 6 insertions(+) > > diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h b/MdePkg/I= nclude/IndustryStandard/DebugPort2Table.h > index 3faa30b76a..9ccfc1b1ee 100644 > --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h > +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h > @@ -47,6 +47,7 @@ typedef struct { > #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART = 0x000e #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_DCC = 0x000f #define EFI_ACPI_DBG2_PORT_SUBTY= PE_SERIAL_BCM2835_UART 0x0010+#define EFI_A= CPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS 0x0= 012 #define EFI_ACPI_DBG2_PORT_TYPE_1394 = 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD = 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_U= SB 0x8002diff --git a/Md= ePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h b/MdePkg/= Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > index 2066c7895e..7796796afe 100644 > --- a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable.h > +++ b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable. > +++ h > @@ -100,6 +100,11 @@ typedef struct { > /// #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_INTERFACE_TYP= E_BCM2835_UART 0x10 +///+/// 16550-compatible with parameters = defined in Generic Address Structure+///+#define EFI_ACPI_SERIAL_PORT_CONSO= LE_REDIRECTION_TABLE_INTERFACE_TYPE_16550_WITH_GAS 0x12+ // // I= nterrupt Type //-- > 2.29.0 > > > > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#75464): https://edk2.groups.io/g/devel/message/75464 > Mute This Topic: https://groups.io/mt/83024903/5985097 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com] -= =3D-=3D-=3D-=3D-=3D-=3D > > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you.