Re: [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node

["Marcin Wojtas" <mw@semihalf.com>]

Hi Ard,

pt., 7 cze 2019 o 12:52 Ard Biesheuvel <ard.biesheuvel@linaro.org> napisał(a):
>
> On Wed, 5 Jun 2019 at 01:52, Marcin Wojtas <mw@semihalf.com> wrote:
> >
> > Linux FWTS test of the ARM SBSA compliance suite
> > fail on using unsupported _CID in UART node. Remove it.
> >
>
> It would be better to assign a MRVL _HID here, and use the HISI one as _CID.

Thanks for the hint - it works. Submitting v2 now.

Best regards,
Marcin

>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > ---
> >  Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl    | 1 -
> >  Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl    | 1 -
> >  Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 1 -
> >  3 files changed, 3 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> > index 90b191b..d0cb52a 100644
> > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl
> > @@ -103,7 +103,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA7K", 3)
> >          Device (COM1)
> >          {
> >              Name (_HID, "HISI0031")                             // _HID: Hardware ID
> > -            Name (_CID, "8250dw")                               // _CID: Compatible ID
> >              Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase))   // _ADR: Address
> >              Name (_CRS, ResourceTemplate ()                     // _CRS: Current Resource Settings
> >              {
> > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> > index 5c060a3..143368b 100644
> > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl
> > @@ -147,7 +147,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> >          Device (COM1)
> >          {
> >              Name (_HID, "HISI0031")                             // _HID: Hardware ID
> > -            Name (_CID, "8250dw")                               // _CID: Compatible ID
> >              Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase))   // _ADR: Address
> >              Name (_CRS, ResourceTemplate ()                     // _CRS: Current Resource Settings
> >              {
> > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> > index f7cffb9..117419c 100644
> > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl
> > @@ -146,7 +146,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "ARMADA8K", 3)
> >          Device (COM1)
> >          {
> >              Name (_HID, "HISI0031")                             // _HID: Hardware ID
> > -            Name (_CID, "8250dw")                               // _CID: Compatible ID
> >              Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase))   // _ADR: Address
> >              Name (_CRS, ResourceTemplate ()                     // _CRS: Current Resource Settings
> >              {
> > --
> > 2.7.4
> >