From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=kMrvgfiq; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.193, mailfrom: mw@semihalf.com) Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) by groups.io with SMTP; Fri, 07 Jun 2019 06:08:01 -0700 Received: by mail-qt1-f193.google.com with SMTP id u12so2135423qth.3 for ; Fri, 07 Jun 2019 06:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=SFtSiYUgY6xI4Ybvbhtg31k9Jv8FD/QF9AGEZ6+5geI=; b=kMrvgfiqq07KENLZZBLCX/bmx+L7LLsDnJ7OoNUBFsFPEgmUNUdLPIYIVhvx5hkNCQ OySI3Gjgw1JgVGLBHNlBfm0JjwuBDFJfbNIxnYmtIXz3qOopTLyoMUF9IqbYPsrV7sHe rM6vagF5svQh4ktfi4qgSBi/fD+y7Lu5LKJyD4DyQZx5vsquGIRYsqQ2qAyRzauyVqiS bpAkrOcI1WJHV6M6HeH8GweCkLDKidAVb2m2F7kXkWf1fEyDTEDjvpXfcEUJz6IuuImB tK3jcKImQc4l6dt9NhHwlJ4fwPpztGDsQbBwrlsocvv1WPsmc3C3l66xHrKITQjzuiFD odCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SFtSiYUgY6xI4Ybvbhtg31k9Jv8FD/QF9AGEZ6+5geI=; b=h8z6q+CdKfom4E1UlveVTz/ZzbAxJ4b+ZKM3eZu8h/L8/vxtUmOA7ZOUMDG/hLa8yu FNxpp9yfdSi1DBy1+sAWVtOTvjcsBAUjESE7Zt1aZ31MLEJNrlnTkYHuIR7curyTUYVi kHIu07wKFWVtzbFTo8zmZatZi32OnnCjuGh05H1Ppffoi+FnUhA/0Ku7SboThtwqqOdw GirM10fITpw1LrLlc+AQjmQk6QYJdfDbnIEbf+9axBkj+vavkIcU+kaIaBbaywTaOxG/ 9gwOsBMQ2whe+f8jom11/pk635y5g6YOXCt0olR5paKXHmXJEiHMYTgBOiUZd4pqCoBW u4Dw== X-Gm-Message-State: APjAAAWMOGKpoWatZwhmgFspAmtP1A4OPDEtXHGdvWabib3X6GyPy2vY H3Bgg+8mu46SN7ZHK/J+D6HKKItG7askhXy3KFtwpw== X-Google-Smtp-Source: APXvYqzptqkurxTK6BZ3TW536eegIzMZcV6VtemgJPYxUpVRNj39/9oPUUTRHG7VeqmgqWASedzFVGoQGAD+GP4lMQ8= X-Received: by 2002:aed:3e7c:: with SMTP id m57mr40735411qtf.204.1559912880375; Fri, 07 Jun 2019 06:08:00 -0700 (PDT) MIME-Version: 1.0 References: <1559692364-452-1-git-send-email-mw@semihalf.com> In-Reply-To: From: "Marcin Wojtas" Date: Fri, 7 Jun 2019 15:07:49 +0200 Message-ID: Subject: Re: [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node To: Ard Biesheuvel Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Kostya Porotchkin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ard, pt., 7 cze 2019 o 12:52 Ard Biesheuvel napisa= =C5=82(a): > > On Wed, 5 Jun 2019 at 01:52, Marcin Wojtas wrote: > > > > Linux FWTS test of the ARM SBSA compliance suite > > fail on using unsupported _CID in UART node. Remove it. > > > > It would be better to assign a MRVL _HID here, and use the HISI one as _C= ID. Thanks for the hint - it works. Submitting v2 now. Best regards, Marcin > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Marcin Wojtas > > --- > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl | 1 - > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl | 1 - > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl | 1 - > > 3 files changed, 3 deletions(-) > > > > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.as= l b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl > > index 90b191b..d0cb52a 100644 > > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl > > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl > > @@ -103,7 +103,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "= ARMADA7K", 3) > > Device (COM1) > > { > > Name (_HID, "HISI0031") // _HI= D: Hardware ID > > - Name (_CID, "8250dw") // _CI= D: Compatible ID > > Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _AD= R: Address > > Name (_CRS, ResourceTemplate () // _CR= S: Current Resource Settings > > { > > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.as= l b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl > > index 5c060a3..143368b 100644 > > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl > > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db/Dsdt.asl > > @@ -147,7 +147,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "= ARMADA8K", 3) > > Device (COM1) > > { > > Name (_HID, "HISI0031") // _HI= D: Hardware ID > > - Name (_CID, "8250dw") // _CI= D: Compatible ID > > Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _AD= R: Address > > Name (_CRS, ResourceTemplate () // _CR= S: Current Resource Settings > > { > > diff --git a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt= .asl b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl > > index f7cffb9..117419c 100644 > > --- a/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl > > +++ b/Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin/Dsdt.asl > > @@ -146,7 +146,6 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "MVEBU ", "= ARMADA8K", 3) > > Device (COM1) > > { > > Name (_HID, "HISI0031") // _HI= D: Hardware ID > > - Name (_CID, "8250dw") // _CI= D: Compatible ID > > Name (_ADR, FixedPcdGet64(PcdSerialRegisterBase)) // _AD= R: Address > > Name (_CRS, ResourceTemplate () // _CR= S: Current Resource Settings > > { > > -- > > 2.7.4 > >