public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Marcin Wojtas <mw@semihalf.com>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	 nadavh@marvell.com, Neta Zur Hershkovits <neta@marvell.com>,
	 Kostya Porotchkin <kostap@marvell.com>,
	Hua Jing <jinghua@marvell.com>,
	 semihalf-dabros-jan <jsd@semihalf.com>
Subject: Re: [platforms: PATCH 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information
Date: Fri, 1 Dec 2017 16:00:32 +0100	[thread overview]
Message-ID: <CAPv3WKf0yh9f8_YO8xuVPpEbFE_KC9-Cg=y4GGr6WUm2b-U=Jw@mail.gmail.com> (raw)
In-Reply-To: <20171201132726.b76ag53qxkukswxj@bivouac.eciton.net>

2017-12-01 14:27 GMT+01:00 Leif Lindholm <leif.lindholm@linaro.org>:
> On Fri, Dec 01, 2017 at 03:28:53AM +0100, Marcin Wojtas wrote:
>> fupdate command's usage information referred to a deprecated
>> flag in 'examples' section. Fix this and replace damaged
>> FUpdate.uni file with its proper text version.
>
> Mention which flag?

The '-f' flag was removed from the function after your review a really
long time ago. Someone just noticed it still is in the 'help'. I will
be more verbose in the commit log.

>
> Also, it's called .uni because it's unicode.
> Technically, it ought to be UCS-2, but I don't complain about UTF-8.
> I don't see any issues with the existing version, it only happens to
> be UTF-16 (according to 'file' - I guess it may be misidentified
> UCS-2). Emacs doesn't have any issues editing it.
>

I use vim, but will try emacs for this file then.

Marcin

> /
>     Leif
>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>> ---
>>  Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni | Bin 5146 -> 2300 bytes
>>  1 file changed, 0 insertions(+), 0 deletions(-)
>>
>> diff --git a/Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni b/Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni
>> index 9d52e590c6d239621d226a240a3f9755210f52fe..293ae6650b92d04bcc977193ea4390e3d938a15f 100644
>> GIT binary patch
>> literal 2300
>> zcmb_dU2mf}6n*DcTxDLS6>VqdVIMlXD-m!KO9WU9O(Ts|Q9fErfFmHS^6&T9fixNI
>> zXr<NUCC0u!_uO-j?Yrw=`?FlNJ9P5pb)e7g6@C5k+wZi_y0@~fiMK=9wb>w5o7LnG
>> z#jRycYjfd|FY~hPOA2>7#Ikrr2eqfJ%uD%J7Bsxdo))q$sp?cS!P+LM$quA;0}YDy
>> zeQ9G;A^V||&-<aItS#<TXEmyj)!__g-xg(uZvd*gR`0TXq1uqpBam(STPyxR0xONB
>> zGmvblSNkqE==3bxtUCY(TWorl!z-!I{Hy&yCb7&-<+hb|CGCJMhXF<HI`t+CQ(Xr7
>> z7hH1H7E)``lit*n!@XtE_`9Y{W<9BDqLixw;ro7o4nqd28aI1ZZzbiY{<La9t@a6!
>> zj>^=~O+%e0N6nYaAZ}h~vMD?C@aK$>`AnIK5lSxh5bj?{ov?^TdjE@*?heq;&<d6B
>> zo3b5D4@N_fLQF?ZhEB_@?mv2A8mQ@=OoS#}R2r1%@o1hlYf7!y<mDEv*PHdc>53eB
>> zE$7jWs_T*RK+os&;3!C}sB8<Y1Fh3!8U^zn)dB*%YL0<1zc~xNs)l#%49yotJFB<f
>> zmAR~Bj_p!AvD0pAkG|{sV>QW&3liZX**GyHjH5Vw;2!g6zNKWv$PJ@y%$KW#R-x~)
>> zSdbHVm<^Jc&(kEt#LN-cInxW46Ksh+MllnD!kG9v@;ShO9y>w8nXrimuAh25SlR>t
>> z3c`eZzUB$SlF&9u$8FZfHVPNCX0f{hiZkavPqv20f+vB_wLmh5A}3C`oBB>nQ5r{~
>> zV1%+Pj|<m#_?mgQ$c~J}9$1i&SUJA`LzUqsV6motQR19|qciuJPGpMoc+A{HSMxD)
>> zAsp!WHi?M2To2eIg9J{zwMR_B{!S5uMe>}rvt+{h{2z*-C2ktCwWbUiL^>A<Ptt_Z
>> zG7LSVvtaQ9cbWKR`Jq;RL8)LiG9->k3<xMCzG)KkRB)pi4-yu~X_W9VxI%k3Pz7~6
>> z*y<T^!@!gZ8-(#zgK7<o_BL%+4D;x4a8%0CVhEVR)$KfmAs;-FoYhDHTl##-0+(qv
>> zp+?zo!LHCM4rWUYscp1zkP`+$UTs9MIu5z8Cc{EsG?Ms&9Pa@b-V}`13qIP!Nan6a
>> zxp9Jj?Q3^^XIXcDezL4jb=JNVWreG-Y;RJWi?V&eP5L^+ntq4yo<N|dB}<-G%#WTH
>> zX@mx`>FOjh2>a}%oB(Fl>^50Zwci!Epy&(D7P4#1aUZ90)iijHX5YK-t&SEe3Y;|?
>> zKTpx=5x_l0p9PC;5JrNFaf-(ODdQi$%ClO(w^25{{xz;%OwtYQu%>UWS_e}#QIw4?
>> zrNZVP&^1es2{-1(d*dp5bZ}JI{rEXj{y;mvU?SpF)mi^~d|@>@RsGj{Gk0TB-r~I(
>> KL8dx>8u1U73A2&_
>>
>> literal 5146
>> zcmd6r+fN%;5XR@ZQvZh)c}b%HX&?GPFOo4PK{A+nZD^!ODA<@-!Zx){5&wMK?{|h_
>> zFE$rNsuWrFo;^Ef=9_OW=dAzzXWQO<)1U9{J8Rm^uI<j|HnvOqVoS^HwPt_N^(T90
>> zKibb49olC}{B0L@rB7xDHkIUs=B9eG)Y@4Z@vN=;p=}x3`PSF&T5fwuZfpbTnA$?W
>> znRSFCG{xEj8|lfNwBP7DmmDj`3CU11OCcU>eP;W*UL`#v$<1t{xvJ&2nh8x4p}x~S
>> zzT@#yqf9nHf*h8HN%K<Uv7PG~{$^S?)st<>&y#l(jgTBAee3Ytq!n=Gc+oP_Dwv$v
>> zt=3M(e5SjCkC=0gC&J}?cGu!^_5)k^ktNNU*23OAF;~c(r>8^}9>6mfXN%-LnD7LC
>> zKppq!fvv)45Et=(n;1bSK3?k=o#?_3;&rW=nW8t=ozGwg4Nr43&?<OGmwQXh!_q{$
>> zmbUYdahaZ#KW}vR6m#gBrA(`Gg;j9kF}VRsd|S#g5h^f$R)*jgvaG6C)KqgICwrZx
>> zGQJoW*+VY4J;(K!|8P>ESeI3v#RFv*m|<#Os?D$**OxHmp0CfJI#V9+q1eOo0_oFy
>> zQT>6ae66zR+PwPzU%sM}h|fjJvNEa|4;ABqJcVPrV^J4Tb>20|HP=LK(TTju#~NKJ
>> z>g%c`DzIR1wL5uT6n!^v#g*6|37gk;wI9*N!5wu_?VOqX@lN2lxp(=Za?r}1XKJ}?
>> zvXUp!bI+gP&^xf_G#wcx;S~*z4$eHQ=tAC;%UR|qs9O3q6^XWDPbg}PS|3Tnt$gv0
>> z6)bz7dn^kVsk05FeWdT;9uMq$uf(o*JUT?t1sC$69;2Rp&|aELF4z9IZ#_G;hI&;?
>> zGd_Q;yN;dcZcnp&n%}jL`eh|jO+7u<Oji=`HP_SJ2hFvUd^hQCDDJF8_DB-Q?pj}?
>> zj>cHukX5eO+|bomzyKrcwd_yX0a>0TS&96iX4|?tHb>u0t9ofRPdmziv@|8x7Y@en
>> z)2w44D?14{dJgsN-D?9MyK(qhwFbI%_BcuGYt^B&bY=C!J(`AmK1f)5$)jLpKUq9_
>> z@N7S^0tcCVBN}+p6!vzyW45o^W69-Og(SRy2k-LaX+t9r?5W$r(~*Ah6DCjeB@RR#
>> zbZvbKFV{u1BTqpH=g$1&vD}p$r?3NQ-qn>m_o*CDkb=4?9B>T6b#qNUA@jfsQe<=a
>> z&Ppu!4B64T&jr}{nB>YxVd@X@=9+wECe014YA7GbEAYKeNWMN-yk3YF-Vp(3+H)e;
>> zJm*g$+S8a!%VfQy&z|OkUC?$@)ipKB?U#hDEvd+UGOVw=R`L`-;0JcxYscZa#rl{h
>> z=kw%aR1(aCqpMF}%z}+N<pfS8pXwPIL+qQf;Z~{V$Y7+)vGsZZ2bJrdM?Mr40M=7k
>> zXvreKUeDxdkz0+2{D3q12KiECS5=#P?p>w#Xf&yVmN*9yai=p71z$}ka5SfS4!`g~
>> zPI2eGBkC!76J5YPC8FVRbPeaLJc}mys`p$NiR#1#F>WX?=)NF<b7wPjdk+9twYL=6
>> zM*peid9g!(+i!>4i6eO0w%_d4!`-WNmgJp<U6%JVKJ3(+DL2_oxVubmGz*=XHcD$b
>> z)v`nSJCA48S;~W+ou$aPRRd?@o?7s_B0E+;1&$l-;Fq#lN8xri)Pac?r+^#n$3sc`
>> zx#6AWHe_imM3d4vpkI;VL^DaJ7tSJETJcHppX5QIpFU1r)6H5d&#U@4HB{}zxr1{i
>> zrzH0UIo@cuR`hKt8?l!w>)BI|H6lanxU!X*Is?C|3OTiM@`MNM9VdRi*zYT=!!8!1
>> zOTEM@v3uN3M0QhBVViR<=Re+%9UalD^R|wy=Q#*3*t3Wi=NEeM^DFBsc2?Fr7wO_0
>> z8qvkCh5l*T(Uo^J>SeQ(2U~ixq*_+dt>*KlbbPJ8V1-?iow2LTIuSpd*<Qv@d1Y2v
>> zyUG(WCx=_o-&VD=FE`UZ;QMRjME%-JZ(zJn4U{2%n&$rrc=LCUiE5WDj(;5d3FrI2
>> xRQ(r{^CzoSRma5Xi9IP!qb*e}|6a^x=~g)6|0aL?;QiK5_}<y7U85Sk{{SUV_8R~I
>>
>> --
>> 2.7.4
>>


  reply	other threads:[~2017-12-01 14:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01  2:28 [platforms: PATCH 0/4] Armada 7k/8k - misc improvements pt.3 Marcin Wojtas
2017-12-01  2:28 ` [platforms: PATCH 1/4] Marvell/Armada: Switch to dynamic tftp command Marcin Wojtas
2017-12-01 13:04   ` Leif Lindholm
2017-12-01 13:56     ` Marcin Wojtas
2017-12-01  2:28 ` [platforms: PATCH 2/4] Marvell/Armada: Fix watchdog control base Marcin Wojtas
2017-12-01 13:19   ` Leif Lindholm
2017-12-01 13:57     ` Marcin Wojtas
2017-12-01  2:28 ` [platforms: PATCH 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information Marcin Wojtas
2017-12-01 13:27   ` Leif Lindholm
2017-12-01 15:00     ` Marcin Wojtas [this message]
2017-12-01  2:28 ` [platforms: PATCH 4/4] Marvell/Drivers: MvPhyDxe: Cleanup the header Marcin Wojtas
2017-12-01 13:09   ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPv3WKf0yh9f8_YO8xuVPpEbFE_KC9-Cg=y4GGr6WUm2b-U=Jw@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox