From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::233; helo=mail-it0-x233.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9823722183C6A for ; Fri, 1 Dec 2017 06:56:07 -0800 (PST) Received: by mail-it0-x233.google.com with SMTP id u62so2732358ita.2 for ; Fri, 01 Dec 2017 07:00:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MOQv7t3qK09fG5BYl7xWyEtOWLg907TDE9Nf+/3syIU=; b=qAQfRVXgqsL9RTMblxdQzgGt9fMPYXZRn9yqhVTsErZap4Tep2lngEr+Nvblm8IjLB umh4tKZM74bd5ZJbQhZMbwYHqU8uiAP8n0zEJBHUB5Whv44xOwu8zqFJavFCSZKl1XJF cmLT59DsH0MlgWFVmfk+ymQ+PvqMxo5kartRslpdnXZDo+mFvWpyljuY9hX2E7BCEGuy czr+r4EkNVOWOm37RYRD9jRmctO7IaFLx630vt7dEMXb08hRhNzyV8ZepW+yO2ZNWzu1 SZAKs32tJ0BbQ59GqwgitMUwTAIeY/hKV8Hvnd8cl5HHQlFHTtnN5Gqf36Ed6GOD8TTq 2H1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MOQv7t3qK09fG5BYl7xWyEtOWLg907TDE9Nf+/3syIU=; b=OgZT0AcUZFEreaAQfJ1aBiQ3W1LTFiuZ9FjqvBNtmnQ7WWrCqPyWOg5oFsIvhre4kf nhVbhpb0oGPa57rbo62p9mru1ABG7FqLieqlZQ2aL9kIfQ05bO+CVijOHkUk6W8O7ydx 3wGbaDhBuMfqHKwn1SO0U72dL0+DKXIWPFu1Uehc4/6i4kT6pkg9VZ2UF4MhjBPRqtna tLhhwnQ2n2hPX11iE3qvppRZjfel41sgVtaj4qr3LVOiUPpvF3+beApyKyr3E75XsBlI aiKiTHpzJrPQnGj0lfrd6PgJUyXtP41eYS0OguiiWlRvwQF3Uf0ulLocXIClLMfPP93f 3wmQ== X-Gm-Message-State: AKGB3mIT7gRDG2NkcbcWck6PjACXhNOJnHR2Bf5duGV2GPdvOh4Y4JTJ O3eLbx/FCdU4YvyBtUmDQUdkNpgwNrT0Hq1veUalPNP7 X-Google-Smtp-Source: AGs4zMYRTSdAQ+Y+81m8u7exAeSfBoqj75pfGv7yQIV6FrsQwpd/NG3V1uvj8KkNygoUeTXgShK6R4lZb7WWb+fn4pI= X-Received: by 10.36.238.73 with SMTP id b70mr2069546iti.127.1512140433153; Fri, 01 Dec 2017 07:00:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.132.164 with HTTP; Fri, 1 Dec 2017 07:00:32 -0800 (PST) In-Reply-To: <20171201132726.b76ag53qxkukswxj@bivouac.eciton.net> References: <1512095334-20345-1-git-send-email-mw@semihalf.com> <1512095334-20345-4-git-send-email-mw@semihalf.com> <20171201132726.b76ag53qxkukswxj@bivouac.eciton.net> From: Marcin Wojtas Date: Fri, 1 Dec 2017 16:00:32 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 3/4] Marvell/Applications: FirmwareUpdate: Fix usage information X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 14:56:07 -0000 Content-Type: text/plain; charset="UTF-8" 2017-12-01 14:27 GMT+01:00 Leif Lindholm : > On Fri, Dec 01, 2017 at 03:28:53AM +0100, Marcin Wojtas wrote: >> fupdate command's usage information referred to a deprecated >> flag in 'examples' section. Fix this and replace damaged >> FUpdate.uni file with its proper text version. > > Mention which flag? The '-f' flag was removed from the function after your review a really long time ago. Someone just noticed it still is in the 'help'. I will be more verbose in the commit log. > > Also, it's called .uni because it's unicode. > Technically, it ought to be UCS-2, but I don't complain about UTF-8. > I don't see any issues with the existing version, it only happens to > be UTF-16 (according to 'file' - I guess it may be misidentified > UCS-2). Emacs doesn't have any issues editing it. > I use vim, but will try emacs for this file then. Marcin > / > Leif > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas >> --- >> Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni | Bin 5146 -> 2300 bytes >> 1 file changed, 0 insertions(+), 0 deletions(-) >> >> diff --git a/Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni b/Platform/Marvell/Applications/FirmwareUpdate/FUpdate.uni >> index 9d52e590c6d239621d226a240a3f9755210f52fe..293ae6650b92d04bcc977193ea4390e3d938a15f 100644 >> GIT binary patch >> literal 2300 >> zcmb_dU2mf}6n*DcTxDLS6>VqdVIMlXD-m!KO9WU9O(Ts|Q9fErfFmHS^6&T9fixNI >> zXrw5o7LnG >> z#jRycYjfd|FY~hPOA2>7#Ikrr2eqfJ%uD%J7Bsxdo))q$sp?cS!P+LM$quA;0}YDy >> zeQ9G;A^V||&-> zGmvblSNkqE==3bxtUCY(TWorl!z-!I{Hy&yCb7&-<+hb|CGCJMhXF> z7hH1H7E)``lit*n!@XtE_`9Y{W<9BDqLixw;ro7o4nqd28aI1ZZzbiY{> zj>^=~O+%e0N6nYaAZ}h~vMD?C@aK$>`AnIK5lSxh5bj?{ov?^TdjE@*?heq;&> zo3b5D4@N_fLQF?ZhEB_@?mv2A8mQ@=OoS#}R2r1%@o1hlYf7!y53eB >> zE$7jWs_T*RK+os&;3!C}sB8> zmAR~Bj_p!AvD0pAkG|{sV>QW&3liZX**GyHjH5Vw;2!g6zNKWv$PJ@y%$KW#R-x~) >> zSdbHVm<^Jc&(kEt#LN-cInxW46Ksh+MllnD!kG9v@;ShO9y>w8nXrimuAh25SlR>t >> z3c`eZzUB$SlF&9u$8FZfHVPNCX0f{hiZkavPqv20f+vB_wLmh5A}3C`oBB>nQ5r{~ >> zV1%+Pj|> zAsp!WHi?M2To2eIg9J{zwMR_B{!S5uMe>}rvt+{h{2z*-C2ktCwWbUiL^>A> zG7LSVvtaQ9cbWKR`Jq;RL8)LiG9->k3> z*y> zp+?zo!LHCM4rWUYscp1zkP`+$UTs9MIu5z8Cc{EsG?Ms&9Pa@b-V}`13qIP!Nan6a >> zxp9Jj?Q3^^XIXcDezL4jb=JNVWreG-Y;RJWi?V&eP5L^+ntq4yo> zX@mx`>FOjh2>a}%oB(Fl>^50Zwci!Epy&(D7P4#1aUZ90)iijHX5YK-t&SEe3Y;|? >> zKTpx=5x_l0p9PC;5JrNFaf-(ODdQi$%ClO(w^25{{xz;%OwtYQu%>UWS_e}#QIw4? >> zrNZVP&^1es2{-1(d*dp5bZ}JI{rEXj{y;mvU?SpF)mi^~d|@>@RsGj{Gk0TB-r~I( >> KL8dx>8u1U73A2&_ >> >> literal 5146 >> zcmd6r+fN%;5XR@ZQvZh)c}b%HX&?GPFOo4PK{A+nZD^!ODA<@-!Zx){5&wMK?{|h_ >> zFE$rNsuWrFo;^Ef=9_OW=dAzzXWQO<)1U9{J8Rm^uI> zKibb49olC}{B0L@rB7xDHkIUs=B9eG)Y@4Z@vN=;p=}x3`PSF&T5fwuZfpbTnA$?W >> znRSFCG{xEj8|lfNwBP7DmmDj`3CU11OCcU>eP;W*UL`#v$<1t{xvJ&2nh8x4p}x~S >> zzT@#yqf9nHf*h8HN%K&y#l(jgTBAee3Ytq!n=Gc+oP_Dwv$v >> zt=3M(e5SjCkC=0gC&J}?cGu!^_5)k^ktNNU*23OAF;~c(r>8^}9>6mfXN%-LnD7LC >> zKppq!fvv)45Et=(n;1bSK3?k=o#?_3;&rW=nW8t=ozGwg4Nr43&?> zmbUYdahaZ#KW}vR6m#gBrA(`Gg;j9kF}VRsd|S#g5h^f$R)*jgvaG6C)KqgICwrZx >> zGQJoW*+VY4J;(K!|8P>ESeI3v#RFv*m|<#Os?D$**OxHmp0CfJI#V9+q1eOo0_oFy >> zQT>6ae66zR+PwPzU%sM}h|fjJvNEa|4;ABqJcVPrV^J4Tb>20|HP=LK(TTju#~NKJ >> z>g%c`DzIR1wL5uT6n!^v#g*6|37gk;wI9*N!5wu_?VOqX@lN2lxp(=Za?r}1XKJ}? >> zvXUp!bI+gP&^xf_G#wcx;S~*z4$eHQ=tAC;%UR|qs9O3q6^XWDPbg}PS|3Tnt$gv0 >> z6)bz7dn^kVsk05FeWdT;9uMq$uf(o*JUT?t1sC$69;2Rp&|aELF4z9IZ#_G;hI&;? >> zGd_Q;yN;dcZcnp&n%}jL`eh|jO+7u> zj>cHukX5eO+|bomzyKrcwd_yX0a>0TS&96iX4|?tHb>u0t9ofRPdmziv@|8x7Y@en >> z)2w44D?14{dJgsN-D?9MyK(qhwFbI%_BcuGYt^B&bY=C!J(`AmK1f)5$)jLpKUq9_ >> z@N7S^0tcCVBN}+p6!vzyW45o^W69-Og(SRy2k-LaX+t9r?5W$r(~*Ah6DCjeB@RR# >> zbZvbKFV{u1BTqpH=g$1&vD}p$r?3NQ-qn>m_o*CDkb=4?9B>T6b#qNUA@jfsQe<=a >> z&Ppu!4B64T&jr}{nB>YxVd@X@=9+wECe014YA7GbEAYKeNWMN-yk3YF-Vp(3+H)e; >> zJm*g$+S8a!%VfQy&z|OkUC?$@)ipKB?U#hDEvd+UGOVw=R`L`-;0JcxYscZa#rl{h >> z=kw%aR1(aCqpMF}%z}+N> zXvreKUeDxdkz0+2{D3q12KiECS5=#P?p>w#Xf&yVmN*9yai=p71z$}ka5SfS4!`g~ >> zPI2eGBkC!76J5YPC8FVRbPeaLJc}mys`p$NiR#1#F>WX?=)NF> zM*peid9g!(+i!>4i6eO0w%_d4!`-WNmgJp> z)v`nSJCA48S;~W+ou$aPRRd?@o?7s_B0E+;1&$l-;Fq#lN8xri)Pac?r+^#n$3sc` >> zx#6AWHe_imM3d4vpkI;VL^DaJ7tSJETJcHppX5QIpFU1r)6H5d&#U@4HB{}zxr1{i >> zrzH0UIo@cuR`hKt8?l!w>)BI|H6lanxU!X*Is?C|3OTiM@`MNM9VdRi*zYT=!!8!1 >> zOTEM@v3uN3M0QhBVViR<=Re+%9UalD^R|wy=Q#*3*t3Wi=NEeM^DFBsc2?Fr7wO_0 >> z8qvkCh5l*T(Uo^J>SeQ(2U~ixq*_+dt>*KlbbPJ8V1-?iow2LTIuSpd*> zyUG(WCx=_o-&VD=FE`UZ;QMRjME%-JZ(zJn4U{2%n&$rrc=LCUiE5WDj(;5d3FrI2 >> xRQ(r{^CzoSRma5Xi9IP!qb*e}|6a^x=~g)6|0aL?;QiK5_}> >> -- >> 2.7.4 >>