From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5A210220C1C3A for ; Thu, 30 Nov 2017 08:18:53 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id f143so9093400itb.0 for ; Thu, 30 Nov 2017 08:23:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1OwhQej6q9c+CnSnmhfr8DLSIpbnBX974tTknYzgOB0=; b=xxvej6mokk8d0uM/hPsi/yEfXhMotDNKPevPCY2ehYDi49/TixrlWOopiMlNRQq6tP 0DgJXwqLlAGhGYpUZd3de3kV5pOe2l7gSvQ8YuqBo9MroAPctVMg+bqeg7EkK0h2q2qu IbuXz019RORT7LigSZFmq2kvQXKaYzmKVrwa0P2KBuHuKdHj2ESi6vC+UENxmrlxEtF6 1+dT/vm9YdL+ucrYWwcufc0sRwW0HhP1xe4nVuPrvSMjVz00nI/8AUjViItfdo0TUKj4 BEZ/FnOS7N8LARygPmuch7oMtpM/gq0WTGPXIxliM5A42dXapqCXa9DPGpbX+oG38fdc uluQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1OwhQej6q9c+CnSnmhfr8DLSIpbnBX974tTknYzgOB0=; b=XtKC5NwyCgKhfzmslwD2VLTdj3Vf5KvZF+Wx5uk03vLhYX2gpWhfE+MxCTbdfXdPWI zH2pkHc66wraxQQIYSPrMF1u3/tNM0xrmyNjXBqeYQrzWPTQZ0ELXzKnUQZrT+zM0LTB MYdhmJrZeJ4o1+pmQtIelbTq1yL8H3+wa8YW3W4+Cw7fOwZMoGhVI+btEYoEI8HxoMk2 v0xo8BLFci2TB+dnnWcdhkVZpnSMphe1d2yuVbYG2cKGnVO5koAqMjGzPS7JDmebrOeU 6uH9gJ0YPGV1Lhq2DeoJYg2AEnhh+39ZJK7cS6/jzLC+nH+RmI5EYQ9A2LIhoakxbWPx aG+g== X-Gm-Message-State: AJaThX6OjDX3PrRQEfglBXdw3wcQ054Ej26K3kcSuqkBwtWsJTYwqvlF 6ibp31TYZRpVEjODUnxNqtsLezKdErEJk3cM69efYA== X-Google-Smtp-Source: AGs4zMamldcZCRea+QaeNrdULJ5yNHTHVAWjf8TwqM1IgVMU8sltFMqBsZZZHaQKKXk3Ea3hNB3wvCly9XTU2WkquoI= X-Received: by 10.36.131.200 with SMTP id d191mr3890829ite.97.1512058997919; Thu, 30 Nov 2017 08:23:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.132.164 with HTTP; Thu, 30 Nov 2017 08:23:17 -0800 (PST) In-Reply-To: <20171130155114.pjzemqpsbtem6oz5@bivouac.eciton.net> References: <1511857153-9266-1-git-send-email-mw@semihalf.com> <20171130155114.pjzemqpsbtem6oz5@bivouac.eciton.net> From: Marcin Wojtas Date: Thu, 30 Nov 2017 17:23:17 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH v3 0/4] Armada 7k/8k variable support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Nov 2017 16:18:53 -0000 Content-Type: text/plain; charset="UTF-8" 2017-11-30 16:51 GMT+01:00 Leif Lindholm : > On Tue, Nov 28, 2017 at 09:19:09AM +0100, Marcin Wojtas wrote: >> Hi, >> >> I submit v3 of the Armada variable support with the MvFvbDxe >> driver improved according to the recent review. The biggest >> changes are a proper implementation of Set/GetAttributes >> protocol callbacks. Details can be found in the changelog below. >> >> Patches are available in the github: >> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/var-upstream-r20171128 >> >> I'm looking forward to the comments or remarks. >> >> Best regards, >> Marcin > > This looks a lot better, thanks. > > For the series: Reviewed-by: Leif Lindholm > Pushed as 4fe276ea64..93f1d9689a. > Thanks a lot! Best regards, Marcin >> Changelog: >> v2 -> v3 >> * 2/4 - 4/4 >> - Add RBs >> >> * 1/4 >> - Fix line-breaking in MvFvbValidateFvHeader >> - Check actual WriteDisabled attributes MvFvbEraseBlocks >> - Rework MvFvbGetAttributes/MvFvbSetAttributes to properly >> support those features >> >> v1 -> v2: >> * Change patches order in order to safely apply related Depex modifications >> >> * 1/4: >> - Fix style (line breaking, openining brackets, alignment, typos) >> - Rework MvFvbSetAttributes - because it can return only EFI_SUCCESS / >> EFI_INVALID_PARAMETER and should return FVB attributes, >> add debug information, that operation is not supported and return >> default values via MvFvbGetAttributes. >> - Return EFI_SUCCESS, in case NumBytes == 0 in MvFvbRead. >> >> * 2/4: >> - Move Depex configuration from 4/4 >> >> * 3/4: >> - Move Depex configuration from 4/4 >> - Reword and break commit message. >> >> * 4/4: >> - Remove Depex configuration >> >> >> Marcin Wojtas (4): >> Platform/Marvell: Introduce MvFvbDxe variable support driver >> Marvell/Drivers: MvSpiFlash: Enable using driver in RT >> Marvell/Drivers: MvSpiDxe: Enable using driver in RT >> Marvell/Armada: Enable variables support >> >> Platform/Marvell/Armada/Armada.dsc.inc | 25 +- >> Platform/Marvell/Armada/Armada70x0.fdf | 6 +- >> Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.c | 58 +- >> Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.h | 1 + >> Platform/Marvell/Drivers/Spi/Devices/MvSpiFlash.inf | 11 +- >> Platform/Marvell/Drivers/Spi/MvSpiDxe.c | 50 +- >> Platform/Marvell/Drivers/Spi/MvSpiDxe.h | 2 + >> Platform/Marvell/Drivers/Spi/MvSpiDxe.inf | 9 +- >> Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.c | 1138 ++++++++++++++++++++ >> Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.h | 128 +++ >> Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.inf | 91 ++ >> Platform/Marvell/Include/Protocol/Spi.h | 7 + >> Platform/Marvell/Marvell.dec | 4 + >> 13 files changed, 1516 insertions(+), 14 deletions(-) >> create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.c >> create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.h >> create mode 100644 Platform/Marvell/Drivers/Spi/Variables/MvFvbDxe.inf >> >> -- >> 2.7.4 >>