Re: [platforms: PATCH 2/5] Marvell/Drivers: MvI2cDxe: Move devices description to MvHwDescLib

[Marcin Wojtas <mw@semihalf.com>]

2017-10-06 17:56 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
> On Fri, Oct 06, 2017 at 09:51:15AM +0200, Marcin Wojtas wrote:
>> This patch introduces I2c description, using the new structures
>> and template in MvHwDescLib. This change enables more flexible
>> addition of multiple I2c controllers and also allows for
>> removal of string PCD parsing. Update Armada 70x0 DB description
>> and PortingGuide accordingly.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>> ---
>>  Platform/Marvell/Armada/Armada70x0.dsc             |  2 +-
>>  Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c   | 42 +++++++++++---------
>>  Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf |  3 +-
>>  Platform/Marvell/Include/Library/MvHwDescLib.h     | 25 ++++++++++++
>>  Platform/Marvell/Marvell.dec                       |  2 +-
>>  Silicon/Marvell/Documentation/PortingGuide.txt     |  4 +-
>>  6 files changed, 54 insertions(+), 24 deletions(-)
>>
>> diff --git a/Platform/Marvell/Armada/Armada70x0.dsc b/Platform/Marvell/Armada/Armada70x0.dsc
>> index 7b03744..d9d126d 100644
>> --- a/Platform/Marvell/Armada/Armada70x0.dsc
>> +++ b/Platform/Marvell/Armada/Armada70x0.dsc
>> @@ -78,7 +78,7 @@
>>    # I2C
>>    gMarvellTokenSpaceGuid.PcdI2cSlaveAddresses|{ 0x50, 0x57, 0x60 }
>>    gMarvellTokenSpaceGuid.PcdI2cSlaveBuses|{ 0x0, 0x0, 0x0 }
>> -  gMarvellTokenSpaceGuid.PcdI2cBaseAddresses|L"0xF2701000;0xF2701100"
>> +  gMarvellTokenSpaceGuid.PcdI2cControllers|{ 0x1, 0x1 }
>
> Similarly to the previous patch, the above is a bit opaque.
> I guess in this case, this is simply a boolean array saying whether a
> specific controller is enabled or not?
> If my interpretation is correct, could the Pcd be renamed
> PcdI2cControllersEnabled?
>

Sure, no problem.

Thanks,
Marcin