From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22e; helo=mail-it0-x22e.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 754C321EA15D5 for ; Fri, 6 Oct 2017 12:20:57 -0700 (PDT) Received: by mail-it0-x22e.google.com with SMTP id y15so2392293ita.4 for ; Fri, 06 Oct 2017 12:24:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=z5JnJ0xnRO3BBBw99t7UUiGl3BQXlZnwM1RKjHUfySQ=; b=SproCkT6vSOrs/sYMHhVyBElpn0eZeQGneqzkFt9PYLzbo2Ah24uEwKlbmKcBMsk20 /YdgfEbaiDLozxvAqD38Skt5c8V0VNDJ7KXkgGva6rLub22snzLdCDkaoyNJMimGtPht Gg+klFEcPe0nH7atHN8tiuA9ADuNCC26k1SnFkSwlbvdjPR+QjT7s3Z0Kx6a4odH0oK+ AcGoZXcYwrxHVmEbbTh7j7pe2l09BXVZ9oVYwpiJwR45kfSqwkZtNjbyssCnUChyPUHx 71C9J0pMFjurdtgeWnVwhn/KwWE3rM/YRgH+xVwzDiuMKCkftQhnFXjteYASv4YjmCKX GapA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=z5JnJ0xnRO3BBBw99t7UUiGl3BQXlZnwM1RKjHUfySQ=; b=WsCnLkEoMQmGpDN0l4Zj6n2W9MAfAJK/cjl+J56dXEEIyLbMEefarvLT3CA7iiaLnT eYuuMprBKsoDlDb98vrCq4137sNuHUv0XVwT2BdttN5wpgJVwuUxsy4SB/FDEq2HdnD7 L6vhMNt09BcG681VxKnr/s0JX2TAZpFhRMRMYaaitgX/GyaymaamqX9cPw4sJFKzr5i8 Xd+tN1qWOX/MkExyF1aNUHc9npIIpQvF1FDgziSTmVK+LSsS1MXbzHZZxmrqxsOmwZvN r/q6Z4UyPEwtCba9OC6erY63pHCKcfev04BDZ3XlyVic9CHrOAHqP4iHEFYjpMBeHL8k /gPQ== X-Gm-Message-State: AMCzsaXEwBKqmNg6d/sHBiRxk8CPFh2oFQTfBuJ7tRuYSfMoLo0qnqKy GNMSx0yuTw3cHB8SRYYyFp2t5WLUCk1Jqnsk8Q73Rg== X-Google-Smtp-Source: AOwi7QDm2r4VzSz1kkIG2U6Lf5WSnufyQ6yjuPG5+xFRI+Xm86V7UmXGROMnbBIip0QOuRMOgq+edff1pwXyqEe7vcU= X-Received: by 10.36.177.9 with SMTP id o9mr4012133itf.44.1507317860920; Fri, 06 Oct 2017 12:24:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.157.141 with HTTP; Fri, 6 Oct 2017 12:24:20 -0700 (PDT) In-Reply-To: <20171006155611.ethg4wwts3zwmhsi@bivouac.eciton.net> References: <1507276278-3608-1-git-send-email-mw@semihalf.com> <1507276278-3608-3-git-send-email-mw@semihalf.com> <20171006155611.ethg4wwts3zwmhsi@bivouac.eciton.net> From: Marcin Wojtas Date: Fri, 6 Oct 2017 21:24:20 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 2/5] Marvell/Drivers: MvI2cDxe: Move devices description to MvHwDescLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 19:20:57 -0000 Content-Type: text/plain; charset="UTF-8" 2017-10-06 17:56 GMT+02:00 Leif Lindholm : > On Fri, Oct 06, 2017 at 09:51:15AM +0200, Marcin Wojtas wrote: >> This patch introduces I2c description, using the new structures >> and template in MvHwDescLib. This change enables more flexible >> addition of multiple I2c controllers and also allows for >> removal of string PCD parsing. Update Armada 70x0 DB description >> and PortingGuide accordingly. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas >> --- >> Platform/Marvell/Armada/Armada70x0.dsc | 2 +- >> Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 42 +++++++++++--------- >> Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf | 3 +- >> Platform/Marvell/Include/Library/MvHwDescLib.h | 25 ++++++++++++ >> Platform/Marvell/Marvell.dec | 2 +- >> Silicon/Marvell/Documentation/PortingGuide.txt | 4 +- >> 6 files changed, 54 insertions(+), 24 deletions(-) >> >> diff --git a/Platform/Marvell/Armada/Armada70x0.dsc b/Platform/Marvell/Armada/Armada70x0.dsc >> index 7b03744..d9d126d 100644 >> --- a/Platform/Marvell/Armada/Armada70x0.dsc >> +++ b/Platform/Marvell/Armada/Armada70x0.dsc >> @@ -78,7 +78,7 @@ >> # I2C >> gMarvellTokenSpaceGuid.PcdI2cSlaveAddresses|{ 0x50, 0x57, 0x60 } >> gMarvellTokenSpaceGuid.PcdI2cSlaveBuses|{ 0x0, 0x0, 0x0 } >> - gMarvellTokenSpaceGuid.PcdI2cBaseAddresses|L"0xF2701000;0xF2701100" >> + gMarvellTokenSpaceGuid.PcdI2cControllers|{ 0x1, 0x1 } > > Similarly to the previous patch, the above is a bit opaque. > I guess in this case, this is simply a boolean array saying whether a > specific controller is enabled or not? > If my interpretation is correct, could the Pcd be renamed > PcdI2cControllersEnabled? > Sure, no problem. Thanks, Marcin