From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B0F6521FCA298 for ; Wed, 1 Nov 2017 09:32:31 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id 189so7296984iow.10 for ; Wed, 01 Nov 2017 09:36:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Xr5qAOvR/5OfR8z2d+QD9TIU0g2ic+IxCPY9gN+wBgg=; b=hvQvIIzpmr4ND3OXNztpwRYX4833qViiyvlMiL9pkZTgFc4Dqn1kqdORIDBFKYUeti BxIH+Z2EgCexcbRi/x6eajWOao4viOA5R4RyusHFVKgM/lPgVca0ECLNgOAHL5O9vxHt W6SfWfyMYBYbRhalb9Hk042Pq+oWHoU8Tboo2foLYXuNmY8zNBYuQ3ESOjEAT8U5tpgM 6xv0MtbYcNRhm9AG9hzr4Mnz61TOXXqf1PrwB0MPs87SwMFNrntPNZCzHSgXLlYNudZF 4rsg5j92xQM3K0gwHt1jR24dexc18PaKIcTb9JvR4TP6aHmQeJJ1EHtR42I1bf4yisVQ BzYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Xr5qAOvR/5OfR8z2d+QD9TIU0g2ic+IxCPY9gN+wBgg=; b=ko+d3X3SSDFAVW7qxFVkkWMhg18hZIZnA+jXjvGDVVxRLxUvwbF3Q7KtLC5nHEpC+9 JQhCe7LNExqetWzXnvkODsGjSZrPNK2ssE9KYg/z47gLoWlz1jld7qZbCQoWW390rhOt SLpD6esLYnW/mS/EWzu3UvGR0ZrltHTN/Ys8BLI1s3/81rjRR0aNoKdNw8xTT55of6be yYejOTSOvUd0Z2nT1wCd6+DW1JpqudwgWW9fbNMi9ogxjR/391sPOMkwx/SyVgA2ihF0 vo1azRh8LeDxuiPNj61sbJmDF8rYsn+6SDz9I/560lBiu19Y3AO+qARN/IDbyml7KWOx PGAw== X-Gm-Message-State: AMCzsaUVVsHBInhoN7O0kwoUtXJDsnttSlQFSNTHSS+7p0Mr14eHL18u bPnu36qCQZNcyXk2SxVfGb0YjrJxPuAOSFHWvXy4PA== X-Google-Smtp-Source: ABhQp+TbDe7OCGHA12P6r6gSufjLR2/nxkrXGInm1bDtHJpKIOiOLHJ+iy3O7zNo1Si22BTTMji99nyjINSMYbA7A08= X-Received: by 10.107.11.27 with SMTP id v27mr534846ioi.179.1509554184212; Wed, 01 Nov 2017 09:36:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.167.208 with HTTP; Wed, 1 Nov 2017 09:36:23 -0700 (PDT) In-Reply-To: <20171101032745.ggi5b4cha3w4m7yz@bivouac.eciton.net> References: <1509422375-20198-1-git-send-email-mw@semihalf.com> <1509422375-20198-4-git-send-email-mw@semihalf.com> <20171101032745.ggi5b4cha3w4m7yz@bivouac.eciton.net> From: Marcin Wojtas Date: Wed, 1 Nov 2017 17:36:23 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 3/6] Marvell/Drivers: MvSpiFlash: Remove duplicated macros X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Nov 2017 16:32:31 -0000 Content-Type: text/plain; charset="UTF-8" 2017-11-01 4:27 GMT+01:00 Leif Lindholm : > On Tue, Oct 31, 2017 at 04:59:32AM +0100, Marcin Wojtas wrote: >> Flash commands macros are already defined locally, so >> remove them from the protocol header. > > Locally? > I have no issue with the patch, but the commit message can be a bit > more descriptive. > In a local header. I'll improve the message. Marcin > / > Leif > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas >> --- >> Platform/Marvell/Include/Protocol/SpiFlash.h | 11 ----------- >> 1 file changed, 11 deletions(-) >> >> diff --git a/Platform/Marvell/Include/Protocol/SpiFlash.h b/Platform/Marvell/Include/Protocol/SpiFlash.h >> index 4a3053e..4ba29ba 100644 >> --- a/Platform/Marvell/Include/Protocol/SpiFlash.h >> +++ b/Platform/Marvell/Include/Protocol/SpiFlash.h >> @@ -36,17 +36,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> >> #include >> >> -#define CMD_READ_ID 0x9f >> -#define READ_STATUS_REG_CMD 0x0b >> -#define CMD_WRITE_ENABLE 0x06 >> -#define CMD_FLAG_STATUS 0x70 >> -#define CMD_WRITE_STATUS_REG 0x01 >> -#define CMD_READ_ARRAY_FAST 0x0b >> -#define CMD_PAGE_PROGRAM 0x02 >> -#define CMD_BANK_WRITE 0xc5 >> -#define CMD_ERASE_64K 0xd8 >> -#define CMD_4B_ADDR_ENABLE 0xb7 >> - >> extern EFI_GUID gMarvellSpiFlashProtocolGuid; >> >> typedef struct _MARVELL_SPI_FLASH_PROTOCOL MARVELL_SPI_FLASH_PROTOCOL; >> -- >> 2.7.4 >>