From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by mx.groups.io with SMTP id smtpd.web11.1690.1610702860825168732 for ; Fri, 15 Jan 2021 01:27:41 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=QigSY862; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.182, mailfrom: mw@semihalf.com) Received: by mail-qt1-f182.google.com with SMTP id a6so5563464qtw.6 for ; Fri, 15 Jan 2021 01:27:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=58ZZS+IpZ6hL7gnuUohv+MHWEz2cgbJVBlfqTBzWbdo=; b=QigSY862HcgrV4CgwBAthbJlI3mJe1Th1N4LvU4wDK5AntOV6QGDs3mFuJxI0/YkIS GoKvZj5tewjV9+OB6TfCPq5kv6lq64U2RFyoMlrZutRHJu7a39bFLnkDudVeBGIRro9N c5uPQF96hpX81f4Lki11J0Ej+pZ5S5zIASoOARaQy+ZC5UxaXkF3oESbxsJoG1Wj3Ncf salNp5wW/II0AbtUseafxO9j2tasSJRuqvYT9UOtAcifWKWp7R5e4CRf3jpujLUJ7C1f HsnlToCW9b987KQp4RCYuB3nAk4fF1pdR0fU1ZNpabLECNwx4KMb0TwwFX711ml7F4WB HP9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=58ZZS+IpZ6hL7gnuUohv+MHWEz2cgbJVBlfqTBzWbdo=; b=MU6BrW2wliC6di41VhOVlnJ9GjZK2dhaXOCDUGgUyfh8AhST8+xI47UNqNgW7z55V4 /iKci96ejhJhPM3YymGJ7vaI/ilAXL4s2t+Qy7jYDB4StExwiRyuhjLT4j/I/IHcz9Vi AKgXIs17nz9C5kepIODh42xcJfTWyz/V4bdrP/eAcsM2F5y6ISAq5xZDOZiYenhkukrD iwaKijRQ5Grjx/evurk3WgFCb4ytO/X2NyRskiMr/X4WtChSq6jSvbsJYaPDicGnvS9D ioTSfvn9UGEuoR5akw+x4AnPK3XUgzKgSXPwwXeb0/79+RfXPXGN59Bfc62q0q6mvCFb 5Nwg== X-Gm-Message-State: AOAM530OSkawizrXxzB7JWD/grZr6y91xLlZfJpuK0Fwq3bc3W7IFhbB enFaKuCMbpEwFfxe5d7PrbMSMXgMGS711z1ayzNDSw== X-Google-Smtp-Source: ABdhPJxdlkN6FT866PqapvOExI9FI1QGSzv+copGxjtRHNIlc9jltZZ9yqLeUgWGGtYU3Hr0Np87wZo1dqUs+yk74Dc= X-Received: by 2002:ac8:6f69:: with SMTP id u9mr10619741qtv.16.1610702859892; Fri, 15 Jan 2021 01:27:39 -0800 (PST) MIME-Version: 1.0 References: <20210113082843.9095-1-lersek@redhat.com> <20210113082843.9095-3-lersek@redhat.com> In-Reply-To: <20210113082843.9095-3-lersek@redhat.com> From: "Marcin Wojtas" Date: Fri, 15 Jan 2021 10:27:28 +0100 Message-ID: Subject: Re: [edk2-platforms PATCH 2/3] ARM Silicon and Platforms: add OrderedCollectionLib class resolution To: Laszlo Ersek Cc: edk2-devel-groups-io , Ard Biesheuvel , Leif Lindholm , Meenakshi Aggarwal , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= , Thomas Abraham , Wenyi Xie Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =C5=9Br., 13 sty 2021 o 09:29 Laszlo Ersek napisa=C5=82= (a): > > The edk2 patch > > ShellPkg/ShellCommandLib: add ShellSortFileList > > for BZ#3151 will make the > > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf > > instance dependent on the OrderedCollectionLib class. Because the shell > binaries in the ARM silicon and platform DSCs consume the above > UefiShellCommandLib instance, resolve the OrderedCollectionLib class in > them. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Marcin Wojtas > Cc: Meenakshi Aggarwal > Cc: Philippe Mathieu-Daud=C3=A9 > Cc: Thomas Abraham > Cc: Wenyi Xie > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3151 > Signed-off-by: Laszlo Ersek > --- > Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 1 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + > Silicon/NXP/NxpQoriqLs.dsc.inc | 1 + > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 1 + > Platform/Hisilicon/D03/D03.dsc | 1 + > Platform/Hisilicon/HiKey/HiKey.dsc | 1 + > Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 + > Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + > Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 1 + > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 + > 12 files changed, 12 insertions(+) > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc b/Platform/ARM/= VExpressPkg/ArmVExpress.dsc.inc > index 274b2a297c3c..fee7cfcc2d40 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc > @@ -451,6 +451,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstal= l1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwor= k1CommandsLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleP= arsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackT= reeLib/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB= cfgCommandLib.inf > } > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marv= ell/Armada7k8k/Armada7k8k.dsc.inc > index e8e730044117..4cdafe8b1f62 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > @@ -584,6 +584,7 @@ [Components.common] > NULL|Silicon/Marvell/Applications/SpiTool/SpiFlashCmd.inf > NULL|Silicon/Marvell/Applications/FirmwareUpdate/FUpdate.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleP= arsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackT= reeLib/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB= cfgCommandLib.inf > > diff --git a/Silicon/NXP/NxpQoriqLs.dsc.inc b/Silicon/NXP/NxpQoriqLs.dsc.= inc > index 38aa1f22a49d..99a317aba7e6 100644 > --- a/Silicon/NXP/NxpQoriqLs.dsc.inc > +++ b/Silicon/NXP/NxpQoriqLs.dsc.inc > @@ -86,6 +86,7 @@ [LibraryClasses.common] > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsi= ngLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL= ib/BaseOrderedCollectionRedBlackTreeLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgC= ommandLib.inf > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasur= ementLibNull.inf > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableL= ibNull.inf > diff --git a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc b/Platform/AM= D/OverdriveBoard/OverdriveBoard.dsc > index 19102b2ef818..05d1b69c833a 100644 > --- a/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > +++ b/Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > @@ -700,6 +700,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwor= k1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiVie= wCommandLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleP= arsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackT= reeLib/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB= cfgCommandLib.inf > > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Pla= tform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > index 1725e5cad378..c5fc978c5fb7 100644 > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > @@ -482,6 +482,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstal= l1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwor= k1CommandsLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleP= arsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackT= reeLib/BaseOrderedCollectionRedBlackTreeLib.inf > NetLib|NetworkPkg/Library/DxeNetLib/DxeNetLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB= cfgCommandLib.inf > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.= dsc > index d4ec3be24336..5a2441dcd32e 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -502,6 +502,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstal= l1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwor= k1CommandsLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleP= arsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackT= reeLib/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB= cfgCommandLib.inf > !ifdef $(INCLUDE_DP) > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc b/Platform/Hisilicon/HiKe= y/HiKey.dsc > index 83c901cf470c..d84462514042 100644 > --- a/Platform/Hisilicon/HiKey/HiKey.dsc > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc > @@ -286,6 +286,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstal= l1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwor= k1CommandsLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleP= arsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackT= reeLib/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB= cfgCommandLib.inf > > diff --git a/Platform/Hisilicon/HiKey960/HiKey960.dsc b/Platform/Hisilico= n/HiKey960/HiKey960.dsc > index 151c6312f87f..bf9d51e0b73d 100644 > --- a/Platform/Hisilicon/HiKey960/HiKey960.dsc > +++ b/Platform/Hisilicon/HiKey960/HiKey960.dsc > @@ -265,6 +265,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstal= l1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwor= k1CommandsLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleP= arsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackT= reeLib/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB= cfgCommandLib.inf > > diff --git a/Platform/LeMaker/CelloBoard/CelloBoard.dsc b/Platform/LeMake= r/CelloBoard/CelloBoard.dsc > index d787f87c0b86..26bbbb24976b 100644 > --- a/Platform/LeMaker/CelloBoard/CelloBoard.dsc > +++ b/Platform/LeMaker/CelloBoard/CelloBoard.dsc > @@ -636,6 +636,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwor= k1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiVie= wCommandLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleP= arsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackT= reeLib/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB= cfgCommandLib.inf > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/= Socionext/DeveloperBox/DeveloperBox.dsc > index 0e6ab83a2495..0a11b796cca5 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -133,6 +133,7 @@ [LibraryClasses.common.UEFI_APPLICATION] > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.= inf > UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/Uef= iApplicationEntryPoint.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsi= ngLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL= ib/BaseOrderedCollectionRedBlackTreeLib.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BaseP= eCoffGetEntryPointLib.inf > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > diff --git a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc= b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > index 95643685e8aa..18accbfd5d89 100644 > --- a/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > +++ b/Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc > @@ -193,6 +193,7 @@ [LibraryClasses.common.UEFI_APPLICATION] > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.= inf > UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/Uef= iApplicationEntryPoint.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsi= ngLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackTreeL= ib/BaseOrderedCollectionRedBlackTreeLib.inf > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BaseP= eCoffGetEntryPointLib.inf > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc = b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > index d5f75cbba5e5..dd45b4142c77 100644 > --- a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > +++ b/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > @@ -633,6 +633,7 @@ [Components.common] > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwor= k1CommandsLib.inf > NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiVie= wCommandLib.inf > HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleP= arsingLib.inf > + OrderedCollectionLib|MdePkg/Library/BaseOrderedCollectionRedBlackT= reeLib/BaseOrderedCollectionRedBlackTreeLib.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellB= cfgCommandLib.inf > > -- > 2.19.1.3.g30247aa5d201 > > For Marvell platforms: Reviewed-by: Marcin Wojtas