From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C7F0C21110037 for ; Fri, 1 Jun 2018 09:20:26 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id l6-v6so2491205iti.2 for ; Fri, 01 Jun 2018 09:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xpli75Jxonw/CIJpC/z3f5goHrIIZ4hlpD7J2/+o9i0=; b=dGi9MabZ5FwnjYuyuTDWn32sDEheDYVGYW2Gi+VmzktKuRMzidFBA3xKpiOGnTyUAb u49Lvi2+j1sO/9n+O9Jh5MC0PIh+lDSImAJiTusfP+UiYjvB6wOwCFdCSdJ85hQxuuVb 0oGzMC2rnjn9Qh8M1X00j1qQRRvkWZ6L2Orx//HocZcAZCN+DKQnuQXhSmE3StK9LfI7 9G48Npb1hyoo4mFxvgldxAK2qUKnRXnmJ8T9LE2llLdWss6Zz+IQUQYr25MDk4Axdchg 825vzYBcZSIO+KTXlH061U6fjQKzQ73q46oaMG+d6lmEqfv165fwL0pdAhJY2UB7DmVa aC/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xpli75Jxonw/CIJpC/z3f5goHrIIZ4hlpD7J2/+o9i0=; b=LYuvKY3mkTGroeuQyBI78iNJ+eHN7fiRehC3ijMO5KB++2xf79BNMiAf+V/ESEEyMk 4Zdd/kSnJTFN9EQXeEQwgAa4qbigdlRfYX9yFZGYC5h0R+UFTKvKtfiMitHPUamAZfvL Nvv1q5Q+izwR+cYEINQTXZLWePc2di+Wirtr38B0D9KK2s7txdxHlZYlRtXnPWseiHyJ EmoKjY0ol1oS30eksM4/OcIwePyDKFTSdsIBXQLKyEm07BMkaiTnmIRpOCyFPobnmty7 wcgKANcksdgd90cM8DhiHPcn7hUIBIVmIBLqFQhqpMKFohSQSkjbwCAs43beTN0XUjAR N+CQ== X-Gm-Message-State: APt69E2ccw3rd3Pnb1lMouMhnjrHvCIYttC2Rv1SDq5mknnzq+25oTpJ HHnEy30dn09dQyfpB7UAARcWYRXpg8bBEy8/6LK81A== X-Google-Smtp-Source: ADUXVKLUDtfd56BYOke6uKrDSa/5JfqHdpg99iQNM8cjFcGh7iuDhhJkKlGKmII8hK69ROGUxNVRfrZe2R1FVZ821As= X-Received: by 2002:a24:534e:: with SMTP id n75-v6mr5019161itb.138.1527870026127; Fri, 01 Jun 2018 09:20:26 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:c6cc:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 09:20:25 -0700 (PDT) In-Reply-To: References: <1527863526-5494-1-git-send-email-mw@semihalf.com> <1527863526-5494-4-git-send-email-mw@semihalf.com> From: Marcin Wojtas Date: Fri, 1 Jun 2018 18:20:25 +0200 Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Hua Jing , Grzegorz Jaszczyk , David Sniatkiwicz Subject: Re: [platforms PATCH 3/4] Marvell/Armada7k8k: Introduce capsule FW update implementation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 16:20:27 -0000 Content-Type: text/plain; charset="UTF-8" 2018-06-01 18:08 GMT+02:00 Ard Biesheuvel : > On 1 June 2018 at 18:02, Marcin Wojtas wrote: >> Hi Ard, >> >> 2018-06-01 17:32 GMT+02:00 Ard Biesheuvel : >>> On 1 June 2018 at 16:32, Marcin Wojtas wrote: >>>> From: David Sniatkiwicz >>>> >>>> This patch adds necessary code that allows to update >>>> firmware on Armada7k8k platforms, using generic gRT->UpdateCapsule, >>>> i.e. >>>> * PlatformFlashAccessLib implementation to write data to SPI flash >>>> * SystemFirmwareDescriptor for FMP protocol >>>> * SystemFirmwareUpdateConfig to specify binary description >>>> within SystemFirmwareFile >>>> >>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>> Signed-off-by: David Sniatkiwicz >>>> Signed-off-by: Marcin Wojtas >>> >>> Please take the [very recent] changes made in >>> 550de36633fec97d4f7467c02a33b3217f440ae9 into account here. >>> Unfortunately, there is no loop in your code from which you can report >>> progress, but you should at least implement the new entry point. >>> >> >> Actually there is a loop and current % of progress printed when >> updating data in the SPI. >> It is implemented in the SPI flash protocol callback. >> >> https://github.com/tianocore/edk2-platforms/blob/master/Silicon/Marvell/Drivers/Spi/MvSpiFlashDxe/MvSpiFlashDxe.c#L382 >> >> What would you recommend me to do in such case? >> > > You could find a way to pass the callback argument into your SPI flash > protocol method, perhaps by adding a new member to it? Good idea, will try it. Thanks, Marcin