Re: [platforms: PATCH v2 0/6] Armada7k8k ComPhy rework

[Marcin Wojtas <mw@semihalf.com>]

Thanks a lot!
Marcin
czw., 2 sie 2018 o 21:02 Ard Biesheuvel <ard.biesheuvel@linaro.org> napisał(a):
>
> On 26 July 2018 at 09:21, Marcin Wojtas <mw@semihalf.com> wrote:
> > Hi,
> >
> > The second version of the patchset brings minor corrections,
> > that were pointed out during review. Details can be found
> > int the commit logs.
> >
> > The patches are available in the github:
> > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/comphy-upstream-r20180726
> >
> > I'm looking forward to review and any comments/remarks.
> >
> > Best regards,
> > Marcin
> >
> > Changelog:
> > v1 -> v2
> >  * 1/6
> >    - improve commit message
> >    - create dedicated header for externally defined SiP services
> >      ComPhy parameters
> >    - add comments about external definitions
> >
> >  * 2,3,4/6
> >    - s/firmware/ARM-TF/ in the commit messages
> >
> >  * 5,6/6
> >    - swap order without any changes in the patches - in the first
> >      series compilation was broken on 5th and immediately fixed in
> >      the last patch. Now every patch compiles.
> >
> > Grzegorz Jaszczyk (5):
> >   Marvell/Library: ComPhyLib: Configure SATA, SGMII and SFI in ARM-TF
> >   Marvell/Library: ComPhyLib: Configure PCIE in ARM-TF
> >   Marvell/Library: ComPhyLib: Configure RXAUI in ARM-TF
> >   Marvell/Library: ComPhyLib: Configure USB in ARM-TF
> >   Marvell/Library: ComPhyLib: Remove both PHY and PIPE selector config
> >   Marvell/Library: ComPhyLib: Clean up the library after rework
> >
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Pushed as 016d55843a01..9dae9a0c7996
>
> Thanks!
>
> >  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                                              |   23 +-
> >  Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf                                            |    2 +-
> >  Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8kSampleAtResetLib.h |   22 -
> >  Silicon/Marvell/Include/Library/SampleAtResetLib.h                                         |    7 -
> >  Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h                                              |  512 +-----
> >  Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h                                           |   86 +
> >  Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8kSampleAtResetLib.c |   19 -
> >  Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c                                            | 1777 +-------------------
> >  Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c                                              |   41 +-
> >  Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c                                              |  132 --
> >  10 files changed, 170 insertions(+), 2451 deletions(-)
>
> (/me does a little dance after reading this line)
>
> >  create mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h
> >  delete mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c
> >
> > --
> > 2.7.4
> >