From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1EEB1210C5138 for ; Fri, 3 Aug 2018 02:42:10 -0700 (PDT) Received: by mail-io0-x244.google.com with SMTP id w11-v6so4496322iob.2 for ; Fri, 03 Aug 2018 02:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Del61rUE0JR+eyObsocUYYatebuBDfnoB4zzvCaJRF8=; b=ssGissYavjYNLQ8kyhBHaybZJw806d7tNDGQ8ifRXJYGyietNVrI1/EFilR+P4N/VB 9IA5ulbXmGabNJ7MLR75EtuG0WvyfoRtGLm5cyaPOJhTMoastxL52+t6uKqV/S46JwQR 3rDTIPPY8S9jBQGrSkJH6SBJ1lxefji36mYjNeNR+R58sCdB/a4/e2Y3xSuDjFdDw5qJ 5QTiY1j4NL+GEx9FV5WcPWApwUkcIiwLxvVEjmgjNcKIJy1nndjnJp5jBclmqqtTLZit LwM5hzna4MUFKMfdvWeSYVTBrjDvXcGYchkF2xjD8AAqeA0SwcdsxgHLEMbfe7l3SNQC N+UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Del61rUE0JR+eyObsocUYYatebuBDfnoB4zzvCaJRF8=; b=KSEt9Mxucsu4vPq78qcuLu7t8GVgTGoWS8ZI/kEQdyoKWMK/Q12bt+IO/zUa1MAqSq itmBc2v4wBB3IfoX0mM5ihWtYsmOf+iWCA3fdLfrF898NoplrFa0SplnVYNIufwfqWzg 8KCifPwdPTh9M2JTpA/KEcVcMZCV8RX7qrHuBYphxQejQXxqw+tW1xVH5EKR79c+gXeH 2zIdSGlFIFnKZdZXkO8/YUKfo7SGxPBdS+IJF4dRkGSkYyV08PVHfclYvLcxhb2IlE81 NTmFZ8JrjuXdoMHXmJok8V93M4bpbKYIoGZ81PCk6ogx3af7BeKxyLooxOVnQ399brV7 +vNw== X-Gm-Message-State: AOUpUlGnXFGUI3HPBmjXZMk1xRpZqYQtdsRbmgVkKsViFv0CcyP1q2Xo angijFhQft6eL/TIY92761Es0GpCTu5vW7Vho+NW4Q== X-Google-Smtp-Source: AA+uWPyXGECS1b7d3Kr2jQFqZfwXma/CV03xiIQR6sa59iuKeTPBFSNkC61p2yWVRjLGYFn9EslJ9eaqiBqAuzZ9MLQ= X-Received: by 2002:a6b:90c2:: with SMTP id s185-v6mr5547776iod.221.1533289329209; Fri, 03 Aug 2018 02:42:09 -0700 (PDT) MIME-Version: 1.0 References: <1532589696-16902-1-git-send-email-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Fri, 3 Aug 2018 11:41:57 +0200 Message-ID: To: Ard Biesheuvel Cc: edk2-devel-01 , Leif Lindholm , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk Subject: Re: [platforms: PATCH v2 0/6] Armada7k8k ComPhy rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Aug 2018 09:42:10 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks a lot! Marcin czw., 2 sie 2018 o 21:02 Ard Biesheuvel napisa= =C5=82(a): > > On 26 July 2018 at 09:21, Marcin Wojtas wrote: > > Hi, > > > > The second version of the patchset brings minor corrections, > > that were pointed out during review. Details can be found > > int the commit logs. > > > > The patches are available in the github: > > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits= /comphy-upstream-r20180726 > > > > I'm looking forward to review and any comments/remarks. > > > > Best regards, > > Marcin > > > > Changelog: > > v1 -> v2 > > * 1/6 > > - improve commit message > > - create dedicated header for externally defined SiP services > > ComPhy parameters > > - add comments about external definitions > > > > * 2,3,4/6 > > - s/firmware/ARM-TF/ in the commit messages > > > > * 5,6/6 > > - swap order without any changes in the patches - in the first > > series compilation was broken on 5th and immediately fixed in > > the last patch. Now every patch compiles. > > > > Grzegorz Jaszczyk (5): > > Marvell/Library: ComPhyLib: Configure SATA, SGMII and SFI in ARM-TF > > Marvell/Library: ComPhyLib: Configure PCIE in ARM-TF > > Marvell/Library: ComPhyLib: Configure RXAUI in ARM-TF > > Marvell/Library: ComPhyLib: Configure USB in ARM-TF > > Marvell/Library: ComPhyLib: Remove both PHY and PIPE selector config > > Marvell/Library: ComPhyLib: Clean up the library after rework > > > > Reviewed-by: Ard Biesheuvel > > Pushed as 016d55843a01..9dae9a0c7996 > > Thanks! > > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc = | 23 +- > > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf = | 2 +- > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k= 8kSampleAtResetLib.h | 22 - > > Silicon/Marvell/Include/Library/SampleAtResetLib.h = | 7 - > > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h = | 512 +----- > > Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h = | 86 + > > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k= 8kSampleAtResetLib.c | 19 - > > Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c = | 1777 +------------------- > > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c = | 41 +- > > Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c = | 132 -- > > 10 files changed, 170 insertions(+), 2451 deletions(-) > > (/me does a little dance after reading this line) > > > create mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h > > delete mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c > > > > -- > > 2.7.4 > >