From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 07FCC212ABF66 for ; Wed, 13 Jun 2018 00:40:28 -0700 (PDT) Received: by mail-it0-x244.google.com with SMTP id l6-v6so2618969iti.2 for ; Wed, 13 Jun 2018 00:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sXClmYjkRCPw/mSNzLce2AOWYINmJ5aia4WCxqK9bns=; b=Ejq91k4HbPWAuzxlbA23mMw1JMdNG0mm3eoz8AiAZQmBJ0JPp8ygwZTnPo5NwKjkO5 UhzsDwnSAl0wZXoKeqHBfl24yB0Lp6KMzWvjnDpy8VIg7DmW4iytKEgNf6MxGSZUkZZI i6QPT3wMvPslrPW9JRpZ/jcCpwXrdauFZxygT6ncROrhS2WVlnX4pcF4jXFdiAquP3T1 vvzUwrBQMMoWC3bQxnzrnrhQd+SKiMTNQIOKSvF+mUy4xkXM/TEAxu4wPCb/o474AI5d Wy36e5Zrx1mcMDodyyQcb9PK6FBWjYT6f6YKmHj0KnLDEOv8WApT3sfm1TRrU0zELpjt ubQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sXClmYjkRCPw/mSNzLce2AOWYINmJ5aia4WCxqK9bns=; b=JMLtad06mg0e8rN9jrGpezmRFA1K2HQ6GkE8f9gaB8zSHi8r7gI2F+VPMFFhmC2fa2 /iuyojv2OMu4dxeZJD9pR+f7HKjmsdWbnzhzvkDcOQiaHLQ4uGt9xVs2f4sg8FDEFLBU TwsKHEkJCgZU3R+X91RI3lWNPBH3U4tRlTL0HDJPUHoHOgnez3dg9UYfiMmybywREtq5 4sjCxGJ8QTuMLmhvebhTV94GBZnYgW39t3dmOI2Sc2v/5cLhRkh6ijkBs7Z0KAgK/6ld AXyF7g+sCZ1xY3VV2Ordzassca87Ixf1X0zoZk+O/hqf4IQsXJX7CX9bI64Nv/8yDKkT StfQ== X-Gm-Message-State: APt69E3CDj3CA5TYbyy3gHG+0JMAQpnFzM8eUeoViU2ui46IfBWAPKcd 9yArOygIXpKWWsK/lxvmcIpq3VYPzCDcDw3uHn3wUQ== X-Google-Smtp-Source: ADUXVKKEmwKBiyenGV/71Gpi9vZGHpCQoukAbvWwkjdIKEVhLt78nVmyxFAgw79DPypx0/0NgpQ52s5K6VwyWPic0EY= X-Received: by 2002:a24:de0b:: with SMTP id d11-v6mr3847475itg.5.1528875628275; Wed, 13 Jun 2018 00:40:28 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:c6cc:0:0:0:0:0 with HTTP; Wed, 13 Jun 2018 00:40:27 -0700 (PDT) In-Reply-To: <20180612224829.4llfr2wct2d53yax@bivouac.eciton.net> References: <1528472063-1660-1-git-send-email-mw@semihalf.com> <20180612224829.4llfr2wct2d53yax@bivouac.eciton.net> From: Marcin Wojtas Date: Wed, 13 Jun 2018 09:40:27 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Hua Jing , semihalf-dabros-jan , Grzegorz Jaszczyk Subject: Re: [platforms PATCH 00/25] Armada herdware description rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jun 2018 07:40:29 -0000 Content-Type: text/plain; charset="UTF-8" Hi Leif, 2018-06-13 0:48 GMT+02:00 Leif Lindholm : > So, I've made all the comments I was going to be making on this set. > > Patches 3,5-7,13,20-21 are fine as long as you drop pre-existing > Signed-off-by and Reviewed-by, so if you get rid of those you can add > Reviewed-by: Leif Lindholm > when reposting. > > (If any patch apart from the above didn't receive feedback I've > fumbled and please let me know.) > Thanks a lot for your big review effort. I will go over each patch and resend after correction. Best regards, Marcin > Regards, > > Leif > > On Fri, Jun 08, 2018 at 05:33:58PM +0200, Marcin Wojtas wrote: >> Hi, >> >> This big patchset reworks handling of the SoC and Boards' description >> to the final version. Hitherto mechanism of hardcoded structures >> and parsing PCDs inside the drivers was unfortunate - it didn't >> allow to support different SoC families with different number >> of controllers or base addresses. >> >> The main concept is introducing a hardware description layer >> with the new protocol, which is responsible for providing >> data to the consumer platforms drivers. Additionally a new >> SoC and Board description libraries allow to move information >> from overly used PCDs to C code in an organized manner: >> >> ArmadaSoCDescLib + ArmadaBoardDescLib >> (per SoC family) (per Board, in next steps more of description >> | of ComPhy, Mpp and others can go there) >> | | >> | | >> |-> MV_BOARD_DESC <-| >> | >> | >> | >> Driver/Library (e.g. ComPhy, I2c, Pp2Dxe) >> >> Please don't be discouraged by big amount of patches, >> they are sort of repeatable: update protocol, libraries and >> the consumer drivers/libraries until the MvHwDescLib.h >> header could be completely removed. More details can >> be found in the commit logs. >> >> The patches are available in the github: >> https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/boarddesc-upstream-r20180608 >> >> I'm looking forward to review and any comments/remarks. >> >> Best regards, >> Marcin >> >> Marcin Wojtas (21): >> Marvell/Library: Introduce ArmadaBoardDescLib class >> Marvell/Library: UtmiPhyLib: Switch to use MARVELL_BOARD_DESC protocol >> Marvell/Library: RealTimeClockLib: Simplify obtaining base address >> Marvell/Armada7k8k: Extend ArmadaSoCDescLib with PP2 information >> Marvell/Drivers: MvBoardDesc: Extend protocol with PP2 support >> Marvell/Drivers: Pp2Dxe: Switch to use MARVELL_BOARD_DESC protocol >> Marvell/Armada7k8k: Extend ArmadaSoCDescLib with AHCI/SDMMC/XHCI >> Marvell/Drivers: MvBoardDesc: Extend protocol with AHCI/SDMMC/XHCI >> Marvell/Drivers: NonDiscoverable: Switch to use MARVELL_BOARD_DESC >> Marvell/Library: ComPhyLib: Get AHCI data with MARVELL_BOARD_DESC >> Marvell/Armada7k8k: Extend ArmadaSoCDescLib with ComPhy information >> Marvell/Drivers: MvBoardDesc: Extend protocol with COMPHY support >> Marvell/Library: ComPhyLib: Switch library to use MARVELL_BOARD_DESC >> Marvell/Armada7k8k: Extend ArmadaSoCDescLib with MDIO information >> Marvell/Drivers: MvBoardDesc: Extend protocol with MDIO support >> Marvell/Drivers: MvMdioDxe: Enable 64bit addressing >> Marvell/Drivers: MvMdioDxe: Switch driver to use MARVELL_BOARD_DESC >> Marvell/Armada7k8k: Extend ArmadaSoCDescLib with I2C information >> Marvell/Drivers: MvBoardDesc: Extend protocol with I2C support >> Marvell/Drivers: MvI2cDxe: Switch driver to use MARVELL_BOARD_DESC >> Marvell/Drivers: MvPhyDxe: Remove MvHwDescLib.h dependency >> >> jinghua (4): >> Marvell/Library: Introduce ArmadaSoCDescLib class >> Marvell: Introduce MARVELL_BOARD_DESC_PROTOCOL >> Marvell/Drivers: MvBoardDescDxe: Introduce board description driver >> Marvell/Armada7k8k: Enable board description driver compilation >> >> Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc | 2 +- >> Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf | 1 + >> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 + >> Silicon/Marvell/Armada7k8k/Library/Armada7k8kLib/Armada7k8kLib.inf | 2 - >> Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c | 338 ++++++++++++ >> Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf | 37 ++ >> Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.c | 29 +- >> Silicon/Marvell/Armada7k8k/Library/RealTimeClockLib/RealTimeClockLib.inf | 2 +- >> Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c | 573 ++++++++++++++++++++ >> Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h | 59 ++ >> Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf | 70 +++ >> Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 37 +- >> Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf | 1 + >> Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.c | 41 +- >> Silicon/Marvell/Drivers/Net/MvMdioDxe/MvMdioDxe.inf | 1 + >> Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 3 +- >> Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.c | 43 +- >> Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 2 +- >> Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.c | 100 ++-- >> Silicon/Marvell/Drivers/NonDiscoverableDxe/NonDiscoverableDxe.inf | 6 +- >> Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h | 99 ++++ >> Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h | 146 +++++ >> Silicon/Marvell/Include/Library/MvHwDescLib.h | 290 ---------- >> Silicon/Marvell/Include/Library/UtmiPhyLib.h | 2 + >> Silicon/Marvell/Include/Protocol/BoardDesc.h | 118 ++++ >> Silicon/Marvell/Include/Protocol/Mdio.h | 4 +- >> Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c | 50 +- >> Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c | 74 ++- >> Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h | 4 + >> Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf | 6 +- >> Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 65 +-- >> Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 5 + >> Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 9 +- >> Silicon/Marvell/Marvell.dec | 8 +- >> 34 files changed, 1694 insertions(+), 535 deletions(-) >> create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.c >> create mode 100644 Silicon/Marvell/Armada7k8k/Library/Armada7k8kSoCDescLib/Armada7k8kSoCDescLib.inf >> create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.c >> create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.h >> create mode 100644 Silicon/Marvell/Drivers/BoardDesc/MvBoardDescDxe.inf >> create mode 100644 Silicon/Marvell/Include/Library/ArmadaBoardDescLib.h >> create mode 100644 Silicon/Marvell/Include/Library/ArmadaSoCDescLib.h >> delete mode 100644 Silicon/Marvell/Include/Library/MvHwDescLib.h >> create mode 100644 Silicon/Marvell/Include/Protocol/BoardDesc.h >> >> -- >> 2.7.4 >>