Re: [edk2-devel] [edk2-platforms PATCH v2 7/8] Silicon/Marvell: Driver to dump board configuration

["Marcin Wojtas via groups.io" <mw=semihalf.com@groups.io>]

+marcin.s.wojtas@gmail.com

Hi Narinder,


czw., 21 gru 2023 o 01:54 Narinder Dhillon <ndhillon@marvell.com> napisał(a):
>
> From: Narinder Dhillon <ndhillon@marvell.com>
>
> This patch adds an EDK2 shell command to dump board configuration
> device tree.
>
> Signed-off-by: Narinder Dhillon <ndhillon@marvell.com>
> ---
>  .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.c  | 361 ++++++++++++++++++
>  .../Drivers/Fdt/FdtPlatformDxe/FdtPlatform.h  | 102 +++++
>  .../Fdt/FdtPlatformDxe/FdtPlatformDxe.inf     |  60 +++
>  .../Fdt/FdtPlatformDxe/FdtPlatformDxe.uni     | 106 +++++
>  .../Drivers/Fdt/FdtPlatformDxe/README.txt     |  69 ++++
>  .../Drivers/Fdt/FdtPlatformDxe/ShellDumpFdt.c | 283 ++++++++++++++

I think the FDT fixup part and the shell app should be split and the
latter should be rather placed under Silicon/Marvell/Applications/
with a proper .uni file for displaying help instead of the README.txt
and MODULE_TYPE = UEFI_APPLICATION in .inf file.

Is there anything Odyssey-specific in this driver? I was wondering
about using it on Armada/Cn913x.

Thanks,
Marcin


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113730): https://edk2.groups.io/g/devel/message/113730
Mute This Topic: https://groups.io/mt/103292517/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-