From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::22a; helo=mail-io0-x22a.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B024720355202 for ; Thu, 9 Nov 2017 05:42:36 -0800 (PST) Received: by mail-io0-x22a.google.com with SMTP id m81so9876740ioi.13 for ; Thu, 09 Nov 2017 05:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=eukOrf7u6wHS9+OVBglTBbYVWZRoJvO3dfagTeHjgGc=; b=1xtVPwFT451iTuY6pwC5dfux/OVWKKBuNCqem8FL/atKrvrTT2k6MFBnulDsrdaVtA SlWQBiEgcgbOZ45iLI/CapjiufhyTM/8GO3gTsu8fFGAmAHCIi3v5+j33r/ylwEDspAP lwecvA1XxYTI0UxbDmr7hE72WWgFbFX8ZCKnGuDKr2Z6+6BfICRIuC/Y0+G6hxZHYpP3 +zifPxPKnBSpte2MKnn60kZCfeEuD7poTZa3YykAYpi8bBZHMZuhLsO3LWHxqOFpxzVx U03VuvWZmjLftBTQwBt3R10KpJZpL8b1LZeee0RpRVdNXa0NRoxh0v37R4CBZKfw96o9 3yhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=eukOrf7u6wHS9+OVBglTBbYVWZRoJvO3dfagTeHjgGc=; b=KSSGtfkQYLHTvAiAp1s1FLRYzDrpoWWEk/c9GuOCjlrqU6UJwjMaS6tKEZWtRuy8TE rLoZb8CPZCPB8Ls4i1Yaxr+vmtquRWvBJgEJmZapRWP1yD6G39YgNrKjAF+iApUPdSRL y/c8cpoCZzHICurxPxZdFutAEWEI4Nd4HQmtVc1JN9ksM5WF4uCQyTgqvSBEgn72+qzl cTIWGdsMCGlZy/Nw3q4sq/TjhwibZi4r/QOb3ZzBCIlaeJelRG4cixIAwIKrRHMRfoy4 YCjfKuJGfBnfFasDKs5b8moex3Ex1T1hnwM9XpW5XCv2Osj+9ROhLx4URNMgKac/SvQ4 5sUA== X-Gm-Message-State: AJaThX5Apj30r4V+vXVtWqjzViZjsUnP2b6TnArPVMd/3etAg/2/HpY6 cRTNG55XhyiB+Z6ryy3jjsynqz8GJ3OWXkB12efxLw== X-Google-Smtp-Source: ABhQp+SoPopWn9LbKrz9a5VG8437zqEKwugAFeTchtmFRdpcNpREOuN9PT5DUq9KDHewFhsYsyRNMPBlEs9vwSW+qkI= X-Received: by 10.107.68.10 with SMTP id r10mr641775ioa.202.1510235197257; Thu, 09 Nov 2017 05:46:37 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.167.208 with HTTP; Thu, 9 Nov 2017 05:46:36 -0800 (PST) In-Reply-To: <20171109134450.f6lazrh7mr4bht54@bivouac.eciton.net> References: <1509879339-10516-1-git-send-email-mw@semihalf.com> <1509879339-10516-3-git-send-email-mw@semihalf.com> <20171109134450.f6lazrh7mr4bht54@bivouac.eciton.net> From: Marcin Wojtas Date: Thu, 9 Nov 2017 14:46:36 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 2/4] Marvell/Drivers: MvSpiDxe: Enable using driver in RT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Nov 2017 13:42:36 -0000 Content-Type: text/plain; charset="UTF-8" Leif 2017-11-09 14:44 GMT+01:00 Leif Lindholm : > On Sun, Nov 05, 2017 at 11:55:37AM +0100, Marcin Wojtas wrote: >> This patch applies necessary modifications, which allow to use >> MvSpiDxe driver in variable support as a runtime service. >> Its type is modified to DXE_RUNTIME_DRIVER, as well as >> a new callback is introduced as a part of the SpiMasterProtocol. >> It is supposed to configure the memory space for mmio access to >> the host controller registers. Moreover gBS locking usage in >> MvSpiTransfer is limited to the firmware, as the runtime access >> to the flash is protected within the OS. > > Break the commit message up a bit: > --- > This patch applies necessary modifications, which allow to use > MvSpiDxe driver in variable support as a runtime service. > > Its type is modified to DXE_RUNTIME_DRIVER, as well as > a new callback is introduced as a part of the SpiMasterProtocol. > --- > > And then this needs rewording > --- > It is supposed to configure the memory space for mmio access to > the host controller registers. > --- > (Say what it does, not what it should be doing.) > > --- > Moreover gBS locking usage in MvSpiTransfer is limited to the > firmware, as the runtime access to the flash is protected within the > OS. > --- > And "is limited to the firmware". Just because it is used at runtime > does not make it not firmware. I would say something like: > "Apply locking in the driver only during boot services. Once at > runtime, resource protection is handled by the operating system.". > > Also, "Its" -> "The driver's" and "It" -> "The driver". > > Other than that, can you move the Depex addition here from 4/4 please? > > / Sure. Thanks, Marcin