Re: [platforms: PATCH 01/11] Platform/Marvell/Documentation: Refactor PortingGuide

[Marcin Wojtas <mw@semihalf.com>]

2017-09-01 17:45 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
> On Fri, Sep 01, 2017 at 05:08:39PM +0200, Marcin Wojtas wrote:
>> Hi Leif,
>>
>> 2017-09-01 16:36 GMT+02:00 Leif Lindholm <leif.lindholm@linaro.org>:
>> > On Fri, Sep 01, 2017 at 03:08:13PM +0200, Marcin Wojtas wrote:
>> >> From: Nir Erez <nerez@marvell.com>
>> >>
>> >> This patch introduces following improvements to the PortingGuide
>> >> * Replace split documentation with single file
>> >> * Align format to Doxygen constraints
>> >
>> > * Add Build description.
>> > (Comment on that below.)
>> >
>> > Since you are moving things around, I take this as license to
>> > bikeshed:
>> >
>> > I think we should start looking towards separating the development
>> > board and SoC portions, like is done for most other platforms. After
>> > all, the goal is to get additional platforms (not just the EVB).
>> >
>> > Not saying this is something that needs to happen overnight, but it
>> > would make sense to make a start by moving these docs to
>> > Silicon/Marvell/Documentation as part of this patch.
>>
>> I can add it there, no problem. About Silicon vs Platform - I checked
>> the code and basically we'd have to move everything from
>> Platform/Marvell to Silicon/Marvell and leave just subdirectories with
>> board files (dsc, fdf + dtb):
>> Platform/Marvell/Armada70x0Db
>> Platform/Marvell/Armada80x0Db
>> Platform/Marvell/Armada80x0McBin
>> etc.
>> Is it what you mean?
>
> Yeah, exactly. (Although depending on point if view, maybe
> Marvell/Armada80x0McBin should be SolidRun/MacchiatoBin.)

Personally, I'd keep all Marvell boards under Platform/Marvell, so
that not to make a mess, but we can discuss it later of course.

> I'm hoping there could be a lot of sharing of common bits of files in
> generic .dsc.inc/.fdf.inc - both here and under Silicon/Marvell.

On our working branch, there is single dsc.inc and .fdf for all boards
and I think such shareability can be maintained further.

>
>> I'm wondering when will be good moment for this - I'm rebasing 70 OPP
>> patches slowly in my extra time, so maybe after the SPI patchset? Or
>> better after we merge everything to Platform and then do the code
>> shifting? What is your feeling about it?
>
> Well, if I was going to take a hard line on this, that was an option I
> had during the initial import to OpenPlatformPkg. Since I didn't, this
> is very much a "I would be happy to see this happen" kind of thing.
>
> So it's sort of up to you.
>
> But I'll throw in that I am planning to go into hiding for a couple of
> days next week to try and once and for all create some generic config
> fragments that can be reused across all platforms instead of copying
> the same bits along everywhere. So it would make sense to wait with
> any larger interventions until that work is complete.
>

Ok. I have a lot of stuff queued, before adding the new A8040 boards,
so I can proceed with fixes/enhancements, that won't be problematic to
halt in the middle and do the shift.

Thanks,
Marcin