From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DE4AE21EB88C0 for ; Fri, 1 Sep 2017 08:53:36 -0700 (PDT) Received: by mail-io0-x229.google.com with SMTP id i200so3998858ioa.1 for ; Fri, 01 Sep 2017 08:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WYdf/u4ggiOc5qCRU/lzBoJyNAsJzdO4yIU3EdLKlXc=; b=G3daYKjub6KU/yPczbfU4IrGrXuVPM1jeLV9JzQYRUPyhjcKfngGe14A+GqTAQv3P5 rK1NrxHlGsIeJrYF8L+GTEIUv4YK5ik2L8CdBssx9YegPuFklpILhu3f+aC1ugDg/WwO CxtyXzJmb6GuzXarQhGXcTRsLUKlZ2DO+Nm0WXDePv4Z5cjw0s2g1U9ch9nRgjaFXvua 8H0v+jv+FkHAyVlRiZwdmwS2inz/ui+HrWa47BxukHIbLuuBrjij8p558Bm9E43DaI9g OH9bUy0XAsO9XJdKckvvLQLSysZn010L+l9BgMeHpGzTuBg3gxTYRjMw9w40PldaGOKU dxew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WYdf/u4ggiOc5qCRU/lzBoJyNAsJzdO4yIU3EdLKlXc=; b=g9mYcWe6AHp1epc+QepfoeJ1CFe4ItM4iP/bE69jOfrFDv4jMWWgpsBCZyAYCk1xAp 80wbn/XWMdz9G+I62HLBJqkh4aGQYlXWEX5mMM37Ppq+k5MGPLBv6qySvUp5d/TzZf6G xTyPKugoo9eh307h00FL3RkllAMJ31q3KmNutis/NklZdRrk0EZokcY2pmyqQulu9OcM 7gxvPNQT3JxmUuj3e3W4d2cMybe330WkO5Zlo7uEpEMCzP86b3ToM1yWbQkfjPGXIQh2 tW12wEr+KmXS+NRh6JuJeMwCYwnTa+3lp4gLMoKQrLU2qCwda/BdgxlD2R0+sDJ8+2g+ wJyQ== X-Gm-Message-State: AHPjjUgh5BDOv3P3vV53vTjaec6O+AutMCtmw+OFPXAGAZWzLFvWtQEH CA7kBFOX/hRrw3c/dgskRqjA/6ysZosa X-Google-Smtp-Source: ADKCNb7h9vljsYFCdo6N+EpLqswF1cCrJNtRSvcW1DJfBYz7P3rIrdfuNyVmgAh/N6FqfyfxcschsI4OJp5xd9v41wA= X-Received: by 10.107.192.133 with SMTP id q127mr1860438iof.165.1504281380925; Fri, 01 Sep 2017 08:56:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.190.199 with HTTP; Fri, 1 Sep 2017 08:56:20 -0700 (PDT) In-Reply-To: <20170901154515.wcxkzpvrytgnwkqh@bivouac.eciton.net> References: <1504271303-1782-1-git-send-email-mw@semihalf.com> <1504271303-1782-2-git-send-email-mw@semihalf.com> <20170901143622.tk4y5wmpp4q4l34a@bivouac.eciton.net> <20170901154515.wcxkzpvrytgnwkqh@bivouac.eciton.net> From: Marcin Wojtas Date: Fri, 1 Sep 2017 17:56:20 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , Alexander Graf , semihalf-dabros-jan , Nir Erez Subject: Re: [platforms: PATCH 01/11] Platform/Marvell/Documentation: Refactor PortingGuide X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 15:53:37 -0000 Content-Type: text/plain; charset="UTF-8" 2017-09-01 17:45 GMT+02:00 Leif Lindholm : > On Fri, Sep 01, 2017 at 05:08:39PM +0200, Marcin Wojtas wrote: >> Hi Leif, >> >> 2017-09-01 16:36 GMT+02:00 Leif Lindholm : >> > On Fri, Sep 01, 2017 at 03:08:13PM +0200, Marcin Wojtas wrote: >> >> From: Nir Erez >> >> >> >> This patch introduces following improvements to the PortingGuide >> >> * Replace split documentation with single file >> >> * Align format to Doxygen constraints >> > >> > * Add Build description. >> > (Comment on that below.) >> > >> > Since you are moving things around, I take this as license to >> > bikeshed: >> > >> > I think we should start looking towards separating the development >> > board and SoC portions, like is done for most other platforms. After >> > all, the goal is to get additional platforms (not just the EVB). >> > >> > Not saying this is something that needs to happen overnight, but it >> > would make sense to make a start by moving these docs to >> > Silicon/Marvell/Documentation as part of this patch. >> >> I can add it there, no problem. About Silicon vs Platform - I checked >> the code and basically we'd have to move everything from >> Platform/Marvell to Silicon/Marvell and leave just subdirectories with >> board files (dsc, fdf + dtb): >> Platform/Marvell/Armada70x0Db >> Platform/Marvell/Armada80x0Db >> Platform/Marvell/Armada80x0McBin >> etc. >> Is it what you mean? > > Yeah, exactly. (Although depending on point if view, maybe > Marvell/Armada80x0McBin should be SolidRun/MacchiatoBin.) Personally, I'd keep all Marvell boards under Platform/Marvell, so that not to make a mess, but we can discuss it later of course. > I'm hoping there could be a lot of sharing of common bits of files in > generic .dsc.inc/.fdf.inc - both here and under Silicon/Marvell. On our working branch, there is single dsc.inc and .fdf for all boards and I think such shareability can be maintained further. > >> I'm wondering when will be good moment for this - I'm rebasing 70 OPP >> patches slowly in my extra time, so maybe after the SPI patchset? Or >> better after we merge everything to Platform and then do the code >> shifting? What is your feeling about it? > > Well, if I was going to take a hard line on this, that was an option I > had during the initial import to OpenPlatformPkg. Since I didn't, this > is very much a "I would be happy to see this happen" kind of thing. > > So it's sort of up to you. > > But I'll throw in that I am planning to go into hiding for a couple of > days next week to try and once and for all create some generic config > fragments that can be reused across all platforms instead of copying > the same bits along everywhere. So it would make sense to wait with > any larger interventions until that work is complete. > Ok. I have a lot of stuff queued, before adding the new A8040 boards, so I can proceed with fixes/enhancements, that won't be problematic to halt in the middle and do the shift. Thanks, Marcin