From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 964832116370B for ; Mon, 8 Oct 2018 06:29:04 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id w2-v6so9604890ioc.1 for ; Mon, 08 Oct 2018 06:29:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=DIxpHSb+RBm7V1I3HyOr2LyENZwFYwmsuUsSJR8t8AA=; b=z9PqWJr2xdkVvvRYMWysfpHKtjNI9nHtdteTxzwQfy8W4GiotVOiEtk5IHu57MWQDK RWzDy0CFo8Jv8NY9Qa7wvE/vJOg8EK2/JiWbcASN8E1JCKgnOHprkkSkQgBaS1VcJYMg IwoLDt9YZCd5pTxcmk/jDHz0KIAxzq9FmYVgylbQY4h4lZtDL8fHZEbB4klKkgSwmjSV nk9C5dBmht53QyKrtXfbNl0YmidNu2fjGhiZeaQn/RYaqeQ1EYXd26CuIj17ediCYh6U GutAF6O/TLHQp1a5u70XMoXD0YQAAMnPr617lzIlOOpJ8rHENVfFAhCiDdyDN+PCcaMp u8Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=DIxpHSb+RBm7V1I3HyOr2LyENZwFYwmsuUsSJR8t8AA=; b=LwXrsVM64eY9sNIBoAlyQhQlMO1vZN4XM5tTrmNSojEPL5r7OlltBEUfxQSXvXlUAB cltqx60dDZM4bOEzg6zMX+YE88bBcZJxbiNpbVD2poc9bpLGdDhXv3TdZM7M7yd+HbCb rwpHPjmu8RPkWAsdyhmauqgL5S3i58P61XEGn5HL4KjAkVidJDDos/rTJbruGqiDYuIM QcUvHhIElqQkRcS5feMMheFII5w1KF9JtBDMNxAM3KFT+PHpsVt8LTvXyO7lRkVzX4z2 xjrPQ+Vz/M6T1E5zbSPW+VjKtYqMOaEowVgrj8R0qvDA97gDVhXPIP0KY4yVpVSyaEOa mCvg== X-Gm-Message-State: ABuFfog6QylWUY5F2CyiJbW4MfOiE47femrV355G0yP4F+ON7oZ++b0J Z/a9kTfpGICr+0ENWAusJAyri4yhjrp8mx/I6a2JZA== X-Google-Smtp-Source: ACcGV63hyVCNcyqcTBxWFBHeQ4G4srmkJspg+bMEz6elDigDdK8HlGyA3LLQgb9dYdcZxA8OXDDtgQKquPrm/PW4PK8= X-Received: by 2002:a5e:c643:: with SMTP id s3-v6mr16121217ioo.108.1539005343823; Mon, 08 Oct 2018 06:29:03 -0700 (PDT) MIME-Version: 1.0 References: <1538745968-22526-1-git-send-email-mw@semihalf.com> <1538745968-22526-6-git-send-email-mw@semihalf.com> In-Reply-To: From: Marcin Wojtas Date: Mon, 8 Oct 2018 15:28:52 +0200 Message-ID: To: Ard Biesheuvel Cc: edk2-devel-01 , Leif Lindholm , hao.a.wu@intel.com, nadavh@marvell.com, "jsd@semihalf.com" , Tomasz Michalec Subject: Re: [platforms: PATCH v2 5/7] Marvell/Armada80x0Db: Introduce board description library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Oct 2018 13:29:04 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ard, pon., 8 pa=C5=BA 2018 o 14:52 Ard Biesheuvel na= pisa=C5=82(a): > > On 5 October 2018 at 15:26, Marcin Wojtas wrote: > > From: Tomasz Michalec > > > > This patch implements ArmadaBoarDescLib library for > > Armada8040 Development Board and add to it ArmadaBoardDescSdMmcGet > > function with description of connected Xenon host controllers. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Marcin Wojtas > > --- > > Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc = | 3 + > > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoa= rdDescLib.inf | 34 ++++++++++ > > Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0DbBoa= rdDescLib.c | 66 ++++++++++++++++++++ > > 3 files changed, 103 insertions(+) > > create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDesc= Lib/Armada80x0DbBoardDescLib.inf > > create mode 100644 Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDesc= Lib/Armada80x0DbBoardDescLib.c > > > > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc b/Platform/= Marvell/Armada80x0Db/Armada80x0Db.dsc > > index 92e2dc8..42f7bd3 100644 > > --- a/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc > > @@ -54,6 +54,9 @@ > > [Components.AARCH64] > > Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0Db.inf > > > > +[LibraryClasses.common] > > + ArmadaBoardDescLib|Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDe= scLib/Armada80x0DbBoardDescLib.inf > > + > > ######################################################################= ########## > > # > > # Pcd Section - list of all EDK II PCD Entries defined by this Platfor= m > > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Arm= ada80x0DbBoardDescLib.inf b/Platform/Marvell/Armada80x0Db/Armada80x0DbBoard= DescLib/Armada80x0DbBoardDescLib.inf > > new file mode 100644 > > index 0000000..2d39d96 > > --- /dev/null > > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0= DbBoardDescLib.inf > > @@ -0,0 +1,34 @@ > > +## @file > > +# > > +# Copyright (C) 2018, Marvell International Ltd. and its affiliates > > +# > > +# This program and the accompanying materials are licensed and made a= vailable > > +# under the terms and conditions of the BSD License which accompanies= this > > +# distribution. The full text of the license may be found at > > +# http://opensource.org/licenses/bsd-license.php > > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASI= S, > > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS O= R > > +# IMPLIED. > > +# > > +# > > +## > > + > > +[Defines] > > + INF_VERSION =3D 0x0001001A > > + BASE_NAME =3D Armada80x0DbBoardDescLib > > + FILE_GUID =3D fee9e874-1481-4b4f-9882-966bd0d13= 10f > > + MODULE_TYPE =3D BASE > > + VERSION_STRING =3D 1.0 > > + LIBRARY_CLASS =3D ArmadaBoardDescLib > > + > > +[Sources] > > + Armada80x0DbBoardDescLib.c > > + > > +[Packages] > > + MdeModulePkg/MdeModulePkg.dec > > + MdePkg/MdePkg.dec > > + Silicon/Marvell/Marvell.dec > > + > > +[LibraryClasses] > > + DebugLib > > + IoLib > > diff --git a/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Arm= ada80x0DbBoardDescLib.c b/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDe= scLib/Armada80x0DbBoardDescLib.c > > new file mode 100644 > > index 0000000..00d696d > > --- /dev/null > > +++ b/Platform/Marvell/Armada80x0Db/Armada80x0DbBoardDescLib/Armada80x0= DbBoardDescLib.c > > @@ -0,0 +1,66 @@ > > +/** > > +* > > +* Copyright (C) 2018, Marvell International Ltd. and its affiliates. > > +* > > +* This program and the accompanying materials are licensed and made a= vailable > > +* under the terms and conditions of the BSD License which accompanies= this > > +* distribution. The full text of the license may be found at > > +* http://opensource.org/licenses/bsd-license.php > > +* > > +* THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASI= S, > > +* WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS O= R IMPLIED. > > +* > > +**/ > > + > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +// > > +// Order of devices in SdMmcDescTemplate has to be in par with ArmadaS= oCDescLib > > +// > > +STATIC > > +MV_BOARD_SDMMC_DESC mSdMmcDescTemplate[] =3D { > > + { /* eMMC 0xF06E0000 */ > > + 0, /* SOC will be filled by MvBoardDescDxe */ > > + 0, /* SdMmcDevCount will be filled by MvBoardDescDxe */ > > + TRUE, /* Xenon1v8Enabled */ > > + TRUE, /* Xenon8BitBusEnabled */ > > + TRUE, /* XenonSlowModeEnabled */ > > + 0x40, /* XenonTuningStepDivisor */ > > + EmbeddedSlot /* SlotType */ > > + }, > > + { /* SD/MMC 0xF2780000 */ > > + 0, /* SOC will be filled by MvBoardDescDxe */ > > + 0, /* SdMmcDevCount will be filled by MvBoardDescDxe */ > > + FALSE, /* Xenon1v8Enabled */ > > + FALSE, /* Xenon8BitBusEnabled */ > > + FALSE, /* XenonSlowModeEnabled */ > > + 0x19, /* XenonTuningStepDivisor */ > > + EmbeddedSlot /* SlotType */ > > Isn't the SD removable on MacchiatoBin? Or are we not able to support > that in UEFI? > > UEFI CardDetect routine does not support CD via GPIO. On MacchiatoBin, in case we define SD as 'RemovableSlot', it remains undetected. Best regards, Marcin