From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c06::230; helo=mail-io0-x230.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 61CC621F3C1AE for ; Tue, 10 Oct 2017 07:41:43 -0700 (PDT) Received: by mail-io0-x230.google.com with SMTP id h70so5408436ioi.4 for ; Tue, 10 Oct 2017 07:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fU4V7NaE1XnSwjO+bKJtHjyfABUDUCHJUSCLGnUGkVY=; b=2SyfjNjAIkGdDmLmtv8YNnOoq6RLOSdPvyAQsZKAIxK38SCzfS7GdFEAZD1ZFEMgMJ 5vJzwBNQSRlX63cxfsDYlONJ/UF0YXP9yF7S71ZOpBt/0PSE/ylhouo218SHzk3zaB2/ F5JUXp0649Dm7J6r2h6133MIfbNps0zJ0ibmFSuLsXhCP9YcmzV1hnRASkRATAapZP8V qXg33EHFSZ7Ax7zVKtpQhpssCLOv6NYXm+/oJqnGTLVnV1AgoEJBKvjfsAup5wWhrZtp esvJHKnx8GPOK0UJK136kKdXfMGoebp6kOJTtEB8YFvUbIo/sxLJ+Wzh8M0x0qfUW35s pRPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fU4V7NaE1XnSwjO+bKJtHjyfABUDUCHJUSCLGnUGkVY=; b=Bg7nBXS4MvKhlX5jhZl28m54XVQUB0w11cwNSFkMRIh6H76PowwDFiR/p2EY1FOkMI On4b/GnTWLj2GECAWIGUCP4UA5H+UwzkEq/VdDaUAqlsouaH7YEfIxYwJTrRoBaCO2oO VhW/5Ory149sTET/rPGGIoKRMSULasSEzGkL8Hh5lcujS6IvQgNfAcPJ/uitlcn9IFZz vVJBQz5dMbY6s/ijKTEqhPnNMeRNIpX7IUdzxfs/1MI0aBDoRBKlW5eQcoYurc1+G1+6 /eF/Wo+jGIZjH4x4agIx1PTQeIhbJt/dFQzx/Z7tELcjhlXl/iJX/slZ3MqY5tg0U31o VXwA== X-Gm-Message-State: AMCzsaUsGP49BADVnWClu4/X1YCXDuhkGNxrR31vhimhusiil2webls0 SolUHK4IHCy+p7kQOL5X1rdiCkBWrC8prS+96v6oJQ== X-Google-Smtp-Source: AOwi7QAnLa6BrmAOJXWUWFQLSaJb04UOkHlkp+te0RgUk9t3+WaeoBtswJK/uVV9r/ssZ630ngP/+GrrHGeYVUEbtck= X-Received: by 10.107.171.7 with SMTP id u7mr16415768ioe.21.1507646710680; Tue, 10 Oct 2017 07:45:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.157.141 with HTTP; Tue, 10 Oct 2017 07:45:10 -0700 (PDT) In-Reply-To: <20171010143715.w4glyje3pw24kvsm@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-2-git-send-email-mw@semihalf.com> <20171010143715.w4glyje3pw24kvsm@bivouac.eciton.net> From: Marcin Wojtas Date: Tue, 10 Oct 2017 16:45:10 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 14:41:43 -0000 Content-Type: text/plain; charset="UTF-8" Hi Leif, 2017-10-10 16:37 GMT+02:00 Leif Lindholm : > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: >> In order to enable modification of dynamic PCD's for the libraries >> and DXE drivers, this patch introduces new driver. It is >> executed prior to other drivers. Mpp, ComPhy and Utmi libraries >> initialization were moved from PrePi stage to DXE. >> >> To force the correct driver dispatch sequence, introduce a protocol GUID >> and install the protocol as a NULL protocol when PlatInitDxe executes. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas >> Signed-off-by: Ard Biesheuvel > > What does Ard's Signed-off-by signify here? > (I know the authorship on some of these is a bit blurred, since you've > been working together, but I'd like to be clear.) These were the lines, introducing/installing protocol GUID stuff. It was in a small separate patch, but I squashed it into bigger one. > >> --- >> Platform/Marvell/Armada/Armada.dsc.inc | 3 ++ >> Platform/Marvell/Armada/Armada70x0.fdf | 5 +++ >> Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c | 44 ++++++++++++++++++++ >> Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf | 44 ++++++++++++++++++++ >> Platform/Marvell/Armada/Library/Armada70x0Lib/Armada70x0Lib.c | 11 ----- >> Platform/Marvell/Marvell.dec | 5 +++ >> 6 files changed, 101 insertions(+), 11 deletions(-) >> >> diff --git a/Platform/Marvell/Armada/Armada.dsc.inc b/Platform/Marvell/Armada/Armada.dsc.inc >> index 89fb7e7..417bb0c 100644 >> --- a/Platform/Marvell/Armada/Armada.dsc.inc >> +++ b/Platform/Marvell/Armada/Armada.dsc.inc >> @@ -378,6 +378,9 @@ >> ArmPkg/Drivers/TimerDxe/TimerDxe.inf >> ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf >> >> + # Platform Initialization >> + Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf >> + >> # Platform drivers >> Platform/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.inf >> MdeModulePkg/Bus/I2c/I2cDxe/I2cDxe.inf >> diff --git a/Platform/Marvell/Armada/Armada70x0.fdf b/Platform/Marvell/Armada/Armada70x0.fdf >> index c861e78..763d76a 100644 >> --- a/Platform/Marvell/Armada/Armada70x0.fdf >> +++ b/Platform/Marvell/Armada/Armada70x0.fdf >> @@ -89,6 +89,11 @@ FvNameGuid = 5eda4200-2c5f-43cb-9da3-0baf74b1b30c >> >> INF MdeModulePkg/Core/Dxe/DxeMain.inf >> >> + # >> + # Platform Initialization >> + # >> + INF Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.inf >> + >> # PI DXE Drivers producing Architectural Protocols (EFI Services) >> INF ArmPkg/Drivers/CpuDxe/CpuDxe.inf >> INF ArmPkg/Drivers/ArmGic/ArmGicDxe.inf >> diff --git a/Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c b/Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c >> new file mode 100644 >> index 0000000..919454b >> --- /dev/null >> +++ b/Platform/Marvell/Armada/Drivers/PlatInitDxe/PlatInitDxe.c >> @@ -0,0 +1,44 @@ >> +/** @file >> + Copyright (C) Marvell International Ltd. and its affiliates > > We normally need a year here as well. > If Ard has co-authored parts, I guess we should have Linaro copyright > notice on affected files as well. I have no problem with that, if you find it appropriate, given my explanation above. > > Content of the patch is fine. > Ok, thanks! Marcin