From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF539211B5A57 for ; Tue, 15 Jan 2019 02:06:35 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id p197so3634699itp.0 for ; Tue, 15 Jan 2019 02:06:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=47hSuhuWzUgY/fNhf+IR5sL18QUthxaxSomh658NOmE=; b=lFzWhlxhrTLUxZJ73aRzv72d3AOkdhhZzQ2n9DMZFmzDoJ84WXtOGXqCmmebT1/HIe 7mPyPH+d9ew1+wGv9lo+n1+hXN4+tWoTvAj5QrOlWR7vRV9CfEzb83jVPhWv/SzzL7fH iHQPIMxiC8nK0jQOLwP+IyAXJP4LboVb+djQ6h91SN1tFw4EyprB7bOVEvR5opTsAR0c /25A/vuQtO6B0OxWi+r3h9VGRBuWwapsSJXVsPdnihMWVEVRQmRlRHKZI5dGlvhaPirG w+1a/IyE97aSaWNJW90ZW41Z4S8P9G+Rs+0CBrOgDNXqfDJXHbwjR/SN7BVBwKuYuToK NUpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=47hSuhuWzUgY/fNhf+IR5sL18QUthxaxSomh658NOmE=; b=ZIlPPl0WqN+59Lpt8Dy1wYZh2tm9er6+o+STtpOKaACDCj88wu9VRowvQ5Qh9p3sWU 7+1xpF8yhrMsvnoQdCmbzHSay5pH2PA5oOalk+69DqDWk9dcJ2y9+Fx96WnrZcRLUH+H 63sXTVdk+CcNKlKVWBZJm/xbQ1yQNK8C/UXTWhO5FC7bn0MWed2wKPVWVLkm6X0l+1UR NUH68N+9/a3HlPbgiUXrTsXfRplygQn5Iawj1C1BwWo0mqr0p4zSBXttJ4dxhYnXyEdX +qVHjEm0KlQutzLBuzl7qxzQomZbZdea6q9VuYEmJpRJdzplVeKjUiKS3wuT+E5/ua6q tf+Q== X-Gm-Message-State: AJcUukfMjkw3D9iMvToPqVV7sJFsDJSEhHotnSyrcgxETSWkWtwrlxm6 cWZEr/j7USYEuArcrUqcrDnk30SbFuLCyMX4LOJZEYqh X-Google-Smtp-Source: ALg8bN5Z80lbFtrafuSt5gCIblzcVL7ZOiWs7LM16/l8D0ZOtV+M9aFBekyV9553IPa5UOIKv9vrjeojn1cUDhMDe3E= X-Received: by 2002:a24:7b90:: with SMTP id q138mr1965620itc.37.1547546794945; Tue, 15 Jan 2019 02:06:34 -0800 (PST) MIME-Version: 1.0 References: <1547084679-29597-1-git-send-email-mw@semihalf.com> <1547084679-29597-9-git-send-email-mw@semihalf.com> <20190114233235.5tlm7vqiy677wag4@bivouac.eciton.net> <20190115100433.5wjsy6c6etgltscr@bivouac.eciton.net> In-Reply-To: <20190115100433.5wjsy6c6etgltscr@bivouac.eciton.net> From: Marcin Wojtas Date: Tue, 15 Jan 2019 11:06:25 +0100 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, "jsd@semihalf.com" , Grzegorz Jaszczyk , Kostya Porotchkin Subject: Re: [platforms: PATCH v2 08/12] Marvell/Drivers: MvGpioDxe: Introduce platform GPIO driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 10:06:35 -0000 X-List-Received-Date: Tue, 15 Jan 2019 10:06:35 -0000 X-List-Received-Date: Tue, 15 Jan 2019 10:06:35 -0000 X-List-Received-Date: Tue, 15 Jan 2019 10:06:35 -0000 X-List-Received-Date: Tue, 15 Jan 2019 10:06:35 -0000 X-List-Received-Date: Tue, 15 Jan 2019 10:06:35 -0000 X-List-Received-Date: Tue, 15 Jan 2019 10:06:35 -0000 X-List-Received-Date: Tue, 15 Jan 2019 10:06:35 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable wt., 15 sty 2019 o 11:04 Leif Lindholm napisa=C5= =82(a): > > On Tue, Jan 15, 2019 at 07:19:04AM +0100, Marcin Wojtas wrote: > > > > + if (MmioRead32 (BaseAddress + MV_GPIO_OUT_EN_REG) & (1 << GpioPi= n)) { > > > > + *Mode =3D GPIO_MODE_INPUT; > > > > + } else { > > > > + if (MmioRead32 (BaseAddress + MV_GPIO_DATA_IN_REG) & (1 << Gpi= oPin)) { > > > > + *Mode =3D GPIO_MODE_OUTPUT_1; > > > > + } else { > > > > + *Mode =3D GPIO_MODE_OUTPUT_0; > > > > > > Ah, right, it's the change to EMBEDDED_GPIO that means we have two > > > output modes to return instead of just input or output. > > > Could I just ask that you're a bit more explicit about such things in > > > the cover letter? Would have saved me a couple of minutes of head > > > scratching. > > > > Well, in the cover letter I wrote: > > "The biggest change is dropping custom GPIO protocol and start using > > the generic EMBEDDED_GPIO with all its types." > > > > And in the commit log of both drivers: > > "The new driver implements a generic EMBEDDED_GPIO protocol." > > > > Wasn't it explicit enough? :) > > I mean, it's fine - you've technically given all the information > needed to deduce that. But it does sort of imply that the reader knows > all EDK2 interfaces by heart. And I'm not quite there. > Ok, sorry for not being specific enough. Best regards, Marcin