* [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev
@ 2019-09-09 15:53 Patryk Duda
2019-09-10 6:23 ` Marcin Wojtas
2019-09-28 22:51 ` Leif Lindholm
0 siblings, 2 replies; 4+ messages in thread
From: Patryk Duda @ 2019-09-09 15:53 UTC (permalink / raw)
To: devel; +Cc: leif.lindholm, ard.biesheuvel, mw, jsd, Patryk Duda
This patch fixes missing MdioIndex copying during initialization.
This bug appeared as inability to communicate with PHY connected
to MDIO other than first.
Signed-off-by: Patryk Duda <pdk@semihalf.com>
---
Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
index 6cdef42391..2d2aad7e38 100644
--- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
+++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
@@ -419,8 +419,12 @@ MvPhyInit (
PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE));
PhyDev->Addr = PhySmiAddresses[PhyIndex];
PhyDev->Connection = PhyConnection;
- DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n",
- PhyDev->Addr, PhyConnection));
+ PhyDev->MdioIndex = MdioIndex;
+ DEBUG ((DEBUG_INFO,
+ "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n",
+ PhyDev->MdioIndex,
+ PhyDev->Addr,
+ PhyConnection));
*OutPhyDev = PhyDev;
DeviceIds = PcdGetPtr (PcdPhyDeviceIds);
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev
2019-09-09 15:53 [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev Patryk Duda
@ 2019-09-10 6:23 ` Marcin Wojtas
2019-09-27 15:11 ` Patryk Duda
2019-09-28 22:51 ` Leif Lindholm
1 sibling, 1 reply; 4+ messages in thread
From: Marcin Wojtas @ 2019-09-10 6:23 UTC (permalink / raw)
To: Patryk Duda
Cc: edk2-devel-groups-io, Leif Lindholm, Ard Biesheuvel,
jsd@semihalf.com
pon., 9 wrz 2019 o 17:53 Patryk Duda <pdk@semihalf.com> napisał(a):
>
> This patch fixes missing MdioIndex copying during initialization.
> This bug appeared as inability to communicate with PHY connected
> to MDIO other than first.
>
> Signed-off-by: Patryk Duda <pdk@semihalf.com>
> ---
> Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> index 6cdef42391..2d2aad7e38 100644
> --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> @@ -419,8 +419,12 @@ MvPhyInit (
> PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE));
> PhyDev->Addr = PhySmiAddresses[PhyIndex];
> PhyDev->Connection = PhyConnection;
> - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n",
> - PhyDev->Addr, PhyConnection));
> + PhyDev->MdioIndex = MdioIndex;
> + DEBUG ((DEBUG_INFO,
> + "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n",
> + PhyDev->MdioIndex,
> + PhyDev->Addr,
> + PhyConnection));
> *OutPhyDev = PhyDev;
>
> DeviceIds = PcdGetPtr (PcdPhyDeviceIds);
> --
Tested-by: Marcin Wojtas <mw@semihalf.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev
2019-09-10 6:23 ` Marcin Wojtas
@ 2019-09-27 15:11 ` Patryk Duda
0 siblings, 0 replies; 4+ messages in thread
From: Patryk Duda @ 2019-09-27 15:11 UTC (permalink / raw)
To: Marcin Wojtas
Cc: edk2-devel-groups-io, Leif Lindholm, Ard Biesheuvel,
jsd@semihalf.com
[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]
Hi,
Do you have any remarks to this patch?
Best Regards,
Patryk
wt., 10 wrz 2019 o 08:24 Marcin Wojtas <mw@semihalf.com> napisał(a):
> pon., 9 wrz 2019 o 17:53 Patryk Duda <pdk@semihalf.com> napisał(a):
> >
> > This patch fixes missing MdioIndex copying during initialization.
> > This bug appeared as inability to communicate with PHY connected
> > to MDIO other than first.
> >
> > Signed-off-by: Patryk Duda <pdk@semihalf.com>
> > ---
> > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++--
> > 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> > index 6cdef42391..2d2aad7e38 100644
> > --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> > +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> > @@ -419,8 +419,12 @@ MvPhyInit (
> > PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE));
> > PhyDev->Addr = PhySmiAddresses[PhyIndex];
> > PhyDev->Connection = PhyConnection;
> > - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n",
> > - PhyDev->Addr, PhyConnection));
> > + PhyDev->MdioIndex = MdioIndex;
> > + DEBUG ((DEBUG_INFO,
> > + "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n",
> > + PhyDev->MdioIndex,
> > + PhyDev->Addr,
> > + PhyConnection));
> > *OutPhyDev = PhyDev;
> >
> > DeviceIds = PcdGetPtr (PcdPhyDeviceIds);
> > --
>
> Tested-by: Marcin Wojtas <mw@semihalf.com>
>
[-- Attachment #2: Type: text/html, Size: 2266 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev
2019-09-09 15:53 [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev Patryk Duda
2019-09-10 6:23 ` Marcin Wojtas
@ 2019-09-28 22:51 ` Leif Lindholm
1 sibling, 0 replies; 4+ messages in thread
From: Leif Lindholm @ 2019-09-28 22:51 UTC (permalink / raw)
To: Patryk Duda; +Cc: devel, ard.biesheuvel, mw, jsd
On Mon, Sep 09, 2019 at 05:53:10PM +0200, Patryk Duda wrote:
> This patch fixes missing MdioIndex copying during initialization.
> This bug appeared as inability to communicate with PHY connected
> to MDIO other than first.
>
> Signed-off-by: Patryk Duda <pdk@semihalf.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as e4d3ddd7a51b.
Thanks!
> ---
> Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> index 6cdef42391..2d2aad7e38 100644
> --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c
> @@ -419,8 +419,12 @@ MvPhyInit (
> PhyDev = AllocateZeroPool (sizeof (PHY_DEVICE));
> PhyDev->Addr = PhySmiAddresses[PhyIndex];
> PhyDev->Connection = PhyConnection;
> - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n",
> - PhyDev->Addr, PhyConnection));
> + PhyDev->MdioIndex = MdioIndex;
> + DEBUG ((DEBUG_INFO,
> + "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n",
> + PhyDev->MdioIndex,
> + PhyDev->Addr,
> + PhyConnection));
> *OutPhyDev = PhyDev;
>
> DeviceIds = PcdGetPtr (PcdPhyDeviceIds);
> --
> 2.16.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-28 22:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-09 15:53 [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev Patryk Duda
2019-09-10 6:23 ` Marcin Wojtas
2019-09-27 15:11 ` Patryk Duda
2019-09-28 22:51 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox