From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@semihalf-com.20150623.gappssmtp.com header.s=20150623 header.b=nAvJLyv9; spf=none, err=SPF record not found (domain: semihalf.com, ip: 209.85.160.195, mailfrom: mw@semihalf.com) Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by groups.io with SMTP; Mon, 09 Sep 2019 23:24:05 -0700 Received: by mail-qt1-f195.google.com with SMTP id r5so19444730qtd.0 for ; Mon, 09 Sep 2019 23:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Pe6wgpGr/7XZdNVPxEcz0+J6g2gs9KrDmNCzJgPMcZs=; b=nAvJLyv9bLfEkGGAWZjrOcuYnNo0TpBPLcIqwwCtvZbYvgO7gGr3cUHWhLE6JgyPZ8 37v9feMgJw7oKxIcerelr682YeT0nsZ3ySSNK2LRAYuTk8OeJclrSEVijRJPYA6hyRfS ERky8HSMuUSPLA7cysqoR2boxhhRhCIHYhW4s43Df5vYdvImT+yhGs0AirRhz57/rgjz S1S2W6bms1Osxg9M9ycyPUycJcM8aiOiqin4mxmdVwYywoxX44n2Wv6tc9gWOiUkcBLc HUN7jQVSCBfFDWvUNffIxMlFpuV7QsqLoZvkKks9oRop+5j+wvZQJPgzKxCKfa+72X5O e7FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Pe6wgpGr/7XZdNVPxEcz0+J6g2gs9KrDmNCzJgPMcZs=; b=g6Q0IuYvIURTU9dWUW52GYU8TR235cixwX51Vnes7anh/IMTOPFLcKceDLZqYHRSMQ LcuFvj0AWCIyAEuanajlS29tgZesSs3Ka5RKcrkevCgAaE4BeFiDF7YpTU/n3A18cb4i c9aZialCylBvLCa3ITmoxbU+wAezhPyuab66qOVPp7ux937arrKPvnb6T7Bzv6nYxe4X ArzL4z5gEXNEpTY284ksyFbldDU00WHosQrnCJmRTZWdEdKgSoA1mgs2s8NTDmQ8c9+O sxNpAMViKzPo+8M8xQJkLZ/k1ZN19D22mLqPa7fagggcdjsv7zGO3qvj3+R2UPZ3Bpww /bTQ== X-Gm-Message-State: APjAAAVa737Cj9UIzwOy+zTpgWX1Vq4AkcappGYHrk6TQ95h94XL7bQ7 nXFetqomfQDENXLh2xPR17Yqg78CSFzQpLSIX3jXtQ== X-Google-Smtp-Source: APXvYqzVavCBXN3CxZ1olICGBsa7cOy8k6qfWVdBNTZezKJfuO7wIl2HwPKeQlkSjlvlWlq8pIZj9Kv9fWf+HPjxqSs= X-Received: by 2002:a0c:8ec5:: with SMTP id y5mr8990356qvb.194.1568096643866; Mon, 09 Sep 2019 23:24:03 -0700 (PDT) MIME-Version: 1.0 References: <20190909155310.30427-1-pdk@semihalf.com> In-Reply-To: <20190909155310.30427-1-pdk@semihalf.com> From: "Marcin Wojtas" Date: Tue, 10 Sep 2019 08:23:52 +0200 Message-ID: Subject: Re: [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev To: Patryk Duda Cc: edk2-devel-groups-io , Leif Lindholm , Ard Biesheuvel , "jsd@semihalf.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable pon., 9 wrz 2019 o 17:53 Patryk Duda napisa=C5=82(a): > > This patch fixes missing MdioIndex copying during initialization. > This bug appeared as inability to communicate with PHY connected > to MDIO other than first. > > Signed-off-by: Patryk Duda > --- > Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c b/Silicon/Ma= rvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > index 6cdef42391..2d2aad7e38 100644 > --- a/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > +++ b/Silicon/Marvell/Drivers/Net/MvPhyDxe/MvPhyDxe.c > @@ -419,8 +419,12 @@ MvPhyInit ( > PhyDev =3D AllocateZeroPool (sizeof (PHY_DEVICE)); > PhyDev->Addr =3D PhySmiAddresses[PhyIndex]; > PhyDev->Connection =3D PhyConnection; > - DEBUG((DEBUG_INFO, "MvPhyDxe: PhyAddr is %d, connection %d\n", > - PhyDev->Addr, PhyConnection)); > + PhyDev->MdioIndex =3D MdioIndex; > + DEBUG ((DEBUG_INFO, > + "MvPhyDxe: MdioIndex is %d, PhyAddr is %d, connection %d\n", > + PhyDev->MdioIndex, > + PhyDev->Addr, > + PhyConnection)); > *OutPhyDev =3D PhyDev; > > DeviceIds =3D PcdGetPtr (PcdPhyDeviceIds); > -- Tested-by: Marcin Wojtas