From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5A96821A00AC9 for ; Tue, 4 Jul 2017 04:45:39 -0700 (PDT) Received: by mail-it0-x22a.google.com with SMTP id k192so70300454ith.1 for ; Tue, 04 Jul 2017 04:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MRfj1cav6Ps8pDJJIGVGinYvQWZZ42HR6ESGArmblKk=; b=lwmvyerahcuxqne5QTkyWGgBE5kPnicmKRYwZ1qrP+/Mh70UPMDkCHz0b0r8CNALfN Zb7BO0RNNOEgdY77YPM0xMqMYqHJxg+NkwJ0dKEyxOn6SF3zYnpl431EJdIKLY5NV8qf FVZ+tFtXVDFADc5L5I6l8XPbQuPD0faTK/FFeFu/yEE9laQ0IxTnhKmI8lhZELkMm+lB DkrkN7YCnuU1boH+jHcvn2bZjXogiyTZ3EA1WdjZyvScUhigxg0gjHCKjow/S1lzIDUl AyyqC2cZWIMf6ialtl8hW/0qS3Krl+InaS7urXgpy0CrMO/ogyH8+vcvVBwsd2uoctgN EmDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MRfj1cav6Ps8pDJJIGVGinYvQWZZ42HR6ESGArmblKk=; b=p2f5kbPdokjIsoj0iVOaR4LLVLB4juiWPnnQWnaCjWHVzUy1J5rcUxnV1+DOBtiV/1 0pHsF0w5gV9HwKowuB+prZYwEj1yXd9Vh6bOOhCXcYRwkOwGPMPkkZvU+QdurfqLIUzI RSIq6U0NXVQ0mb4WfbPmf0RNIH4ZrUdDGgIhk/YpKfsImSquQO+x4s2BJKN56LT2yTyI 1xCCpaAuKRkKYDPOKekJ03juVSHF86CTjd+w62SPFfHRongRs5QvZ7jqQovorvwEuHxV oo/YYtXlFzKV/+5DvIT0jiYiS+y1kQ/DDt7a2a9ANht7O8KBXZcUKNy7UTHXAKCVVmab RTCQ== X-Gm-Message-State: AIVw111fMW+NKc88XX2OZ/XvuctCjDlgbWTcEhmMNVnpceOe+5ZoYQEE is6RtKvu25PQFXzhYbElcu3OGSOimxva X-Received: by 10.36.127.87 with SMTP id r84mr11707347itc.10.1499168836893; Tue, 04 Jul 2017 04:47:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.151.16 with HTTP; Tue, 4 Jul 2017 04:47:16 -0700 (PDT) In-Reply-To: <20170704114126.GN26676@bivouac.eciton.net> References: <20170704110017.32042-1-ard.biesheuvel@linaro.org> <20170704114126.GN26676@bivouac.eciton.net> From: Marcin Wojtas Date: Tue, 4 Jul 2017 13:47:16 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel Subject: Re: [PATCH] Platforms/Marvell: switch to generic ResetSystemRuntimeDxe X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 11:45:39 -0000 Content-Type: text/plain; charset="UTF-8" 2017-07-04 13:41 GMT+02:00 Leif Lindholm : > On Tue, Jul 04, 2017 at 01:19:10PM +0200, Marcin Wojtas wrote: >> 2017-07-04 13:10 GMT+02:00 Ard Biesheuvel : >> > On 4 July 2017 at 12:04, Marcin Wojtas wrote: >> >> Hi, >> >> >> >> 2017-07-04 13:00 GMT+02:00 Ard Biesheuvel : >> >>> Switch to the generic implementation of the ResetSystem() runtime >> >>> service call, which is preferred over the one in EmbeddedPkg. This >> >>> involves selecting another DXE runtime driver, and morphing the >> >>> existing EfiResetSystemLib implementation into a ResetSystemLib one >> >>> (which is what the generic driver depends on for platform glue) >> >>> >> >>> Contributed-under: TianoCore Contribution Agreement 1.0 >> >>> Signed-off-by: Ard Biesheuvel >> >>> --- >> >>> Platforms/Marvell/Armada/Armada.dsc.inc | 4 +- >> >>> Platforms/Marvell/Armada/Armada70x0.fdf | 2 +- >> >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.c | 110 ++++++++++++++------ >> >>> Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf | 7 +- >> >>> 4 files changed, 87 insertions(+), 36 deletions(-) >> >>> >> >>> diff --git a/Platforms/Marvell/Armada/Armada.dsc.inc b/Platforms/Marvell/Armada/Armada.dsc.inc >> >>> index 475fc6d05379..32eaa2942564 100644 >> >>> --- a/Platforms/Marvell/Armada/Armada.dsc.inc >> >>> +++ b/Platforms/Marvell/Armada/Armada.dsc.inc >> >>> @@ -94,7 +94,7 @@ >> >>> # Reset and Time libraries >> >>> EfiTimeBaseLib|OpenPlatformPkg/Library/EfiTimeBaseLib/EfiTimeBaseLib.inf >> >>> RealTimeClockLib|OpenPlatformPkg/Platforms/Marvell/Armada/Library/RealTimeClockLib/RealTimeClockLib.inf >> >>> - EfiResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf >> >>> + ResetSystemLib|OpenPlatformPkg/Platforms/Marvell/Library/ResetSystemLib/MvResetSystemLib.inf >> >> >> >> Isn't it better to switch to generic PSCI: >> >> EfiResetSystemLib|ArmPkg/Library/ArmPsciResetSystemLib/ArmPsciResetSystemLib.inf >> >> and remove MvResetSystemLib whatsoever? >> >> >> > >> > Yes. But Leif tells me that 7040 does not support PSCI? >> >> Leif, where do you have this information from? > > From the source code in OpenPlatformPkg, which does not use it and the > documentation that does not mention it. Ok, long time ago in early SoC revision, we PSCI was indeed broken and later, we were not aware of the ArmPsciResetSystemLib existence:) On the WIP branch, we have a replacement commit: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commit/b3fe877fe7207475ba293a1fc9b0a5c8f873d2c9 which will be submitted of course. Best regards, Marcin > > If this is incorrect, please submit patches to make the code in the > tree reflect reality. > > / > Leif