From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id ADFA321E62BA7 for ; Fri, 1 Sep 2017 02:46:32 -0700 (PDT) Received: by mail-io0-x232.google.com with SMTP id 81so13140608ioj.5 for ; Fri, 01 Sep 2017 02:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=53rMXPyVqmoPYwaI/gonplPdgWXAXM9gtNw8HiOMoqY=; b=Bo6tq8/E2ignBu96RtrpnNWkEUmsXVSihGgdhlpgurgxJXlT7SMjcH45TlmhdDiYpy 9ZasTufKbKP0yeVJ25QMyFrUDRrBt9ksHSKDKzjdgZiO6A502fmhuSfnYCepJtmxP9uQ 7wLQCH26014kCGF3m3Cf1GTfmJ3Bbm7FU7pvqgoziUP6vFLphbCnZDa3qE4aDneQXAT+ BuExlMA7uDWK9HWmUnsAAP862kmbt+Mg2xeLZVdd86cdm8uljzpUr12Tuyf6/dhT2cDU zOMfI0oXxaPDzqFQK0kwxq4ZMqdgSmoXpTrZEUEGd75VLW+K3qOoqkgfWv+ElpZIt3rr SScw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=53rMXPyVqmoPYwaI/gonplPdgWXAXM9gtNw8HiOMoqY=; b=APbIZYJpYlHMl0lD/rIIjKnIwlyMAT+kwcw1vQ4rae67LOYZbKvPF3Oz7z6WwHh0J2 0vJku9arrvIOjpaRUrqak8wGq6o5YN9yxsyCv5J7Tqy9fD6K+dOcariK+c6Q5v8CKdTb a+4VETUisPxGhgdgKgXJ3cg0EER/gPSzQsN7ueKTWFv8t+EtzSd1CmgcyxJ5JpaDwvBs x1XkG3eBuvbgD3FfPOudX0pcYTxCmSW+382UrTD/n9bXae3ststfuvSAtBsdPcKfNtdJ V5VwiF1m0W86i6a8cmKLUJMQ5Z/aQmA8bXpPmY3EYxeL6pDZ7I3wvpN8ehTYpc2FXD9P vXmw== X-Gm-Message-State: AHPjjUje8m7JoHTRva8cCAkXXz7xljgCwv9GJr5ZDXa4zlTIC71vWcVc l+8W/JoWVwR6ZW2eHWodkjyE0EFLTBzI X-Google-Smtp-Source: ADKCNb4M98P6XehPhjvZjS0c48tyzPApLq+jLGqqzSf8QadrGhR7FO41n8Gl5jrT3p7JI2gFZAGnIDTl9ScjWNkXQUE= X-Received: by 10.36.12.69 with SMTP id 66mr67631itn.58.1504259356472; Fri, 01 Sep 2017 02:49:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.190.199 with HTTP; Fri, 1 Sep 2017 02:49:15 -0700 (PDT) In-Reply-To: References: <1504233451-6455-1-git-send-email-mw@semihalf.com> <1504233451-6455-3-git-send-email-mw@semihalf.com> From: Marcin Wojtas Date: Fri, 1 Sep 2017 11:49:15 +0200 Message-ID: To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , Alexander Graf , =?UTF-8?B?SmFuIETEhWJyb8Wb?= Subject: Re: [platforms: PATCH 2/7] Drivers/Net/Pp2Dxe: Add SFI support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 09:46:33 -0000 Content-Type: text/plain; charset="UTF-8" 2017-09-01 11:40 GMT+02:00 Ard Biesheuvel : > On 1 September 2017 at 10:39, Marcin Wojtas wrote: >> Hi Ard, >> >> 2017-09-01 11:26 GMT+02:00 Ard Biesheuvel : >>> >>> On 1 September 2017 at 03:37, Marcin Wojtas wrote: >>> > Since now SerDes can be properly configured to support 10G >>> > link, add this feature to the Armada 7k/8k network driver >>> > as well. This patch extends low-level configuration routines >>> > with SFI additions, which required two new fields in >>> > PP2DXE_PORT structure (XpcsBase and MpcsBase). >>> > >>> > Contributed-under: TianoCore Contribution Agreement 1.0 >>> > Signed-off-by: Marcin Wojtas >>> >>> If you need to resend this, please fix your indentation: either >>> >>> Status = Function(xxx, xxx, >>> xxx, xxx, etc); >>> >>> (two spaces indentation relative to the function name) >>> >>> or >>> >>> Status = Function (xxx, >>> xxx, >>> xxx, >>> etc); >>> >>> Other than that >>> >> >> In 5.2.2.4 of https://edk2-docs.gitbooks.io/edk-ii-c-coding-standards-specification/content/5_source_files/52_spacing.html#52-spacing >> there's indeed 2 spaces of indentation relative to function name, but >> shouldn't correct multiline call look following: >> >> Status = Function ( >> aaa, >> bbb >> ); >> ? >> > > > There was a lot of discussion about this (unfortunately), but putting > the function name and the closing parenthesis on a separate line is > really not necessary. Would following be acceptable? Status = Function ( aaa, bbb); If yes, I can modify calls in v2 (need to update contributed-under version). It seems that above indentation policy was agreed, see: https://bugzilla.tianocore.org/show_bug.cgi?id=425