From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::231; helo=mail-it0-x231.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6E06C21EA15D5 for ; Fri, 6 Oct 2017 12:23:20 -0700 (PDT) Received: by mail-it0-x231.google.com with SMTP id f187so255120itb.1 for ; Fri, 06 Oct 2017 12:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=l/om79TYaxLmLGz2NsQ0KQk8dP3fx7ucGZb6r2P/bnY=; b=Mt25q/RaaVbPL7PFDBgrzFpIXsNtsNS/JNY6MPP80lU9nhhzNvqQ05SL5wQ3bEpppM f5D7pJ8z48Ycw8BgumgHSeRBhqN0GRk7Uud8YWCqb7bSYFN1Cn6Mki/wQwwFIfCpOmF0 7q4GS2LxjNB35xSpDFxL7q/6hsTNvFogWG+ceTSEmGgNuU+n5qdAehEunQRq935rzXPi 8dYPS4zd7zQ6slKquuOqm6pStqSSchhbadG5nEoMQTXCTlbAJKfqbnm/oPf6uEps7DYQ WVPuidg4/cpElmYqODCuOqhOhBbpd8fL+k9/84LlPsBxR6f4q6TNY8MoLSWGjAp8LHcN PZQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=l/om79TYaxLmLGz2NsQ0KQk8dP3fx7ucGZb6r2P/bnY=; b=W306aL7vkR6og72Z1exEuyCAk16D9WuXVQVYK9lMhqdHgntQ39GmR2x32prD3EIcpR UMtRq0QQBTmKPwRGlp7DZ33kGoSfIsIKcHgmta95eGHwbGOkMgo2FV7OF2twBBgtg837 9EAnKLCucaXDClWEKqEGS7b45yJp87uL78Cwv0AmqPCJjx0yr3Baz+2Une6qEOYD5TWJ B9MJfpFRgRP9LJ0IjOk0FxiqdiBPgP7b66NDpm7QcvCHuPIu+jSIe5gqMGl/GDug7bC5 tIHZGzNCjMNB+QfUuOMa3LxfjV2AYvVXtyJJCDoUwDRgGYTUE7SBV6vI2zk1tQYmn0JP eknA== X-Gm-Message-State: AMCzsaXfq+Pr3dWSqGnIVP3OPCXq7GLEj4BN1nBfDL4xz5WsF9QV4+U9 O9W2WDj+lvqHtfcZB2CSp2JT4iWw0vJ5McbYKxoiJA== X-Google-Smtp-Source: AOwi7QC/N/i+9NGNswNqMBZPAUKGGeQu1cgBvysjkpgbZDbhwuzc1aOyTJyx8ZWkQ2/4hcPomXRyFlX/zxY8KUjPOGo= X-Received: by 10.36.90.19 with SMTP id v19mr4077122ita.30.1507318003799; Fri, 06 Oct 2017 12:26:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.157.141 with HTTP; Fri, 6 Oct 2017 12:26:43 -0700 (PDT) In-Reply-To: <20171006155743.f4sdanashx4htwbq@bivouac.eciton.net> References: <1507276278-3608-1-git-send-email-mw@semihalf.com> <1507276278-3608-4-git-send-email-mw@semihalf.com> <20171006155743.f4sdanashx4htwbq@bivouac.eciton.net> From: Marcin Wojtas Date: Fri, 6 Oct 2017 21:26:43 +0200 Message-ID: To: Leif Lindholm Cc: edk2-devel-01 , Ard Biesheuvel , nadavh@marvell.com, Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 3/5] Marvell/Library: UtmiLib: Move devices description to MvHwDescLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2017 19:23:20 -0000 Content-Type: text/plain; charset="UTF-8" 2017-10-06 17:57 GMT+02:00 Leif Lindholm : > On Fri, Oct 06, 2017 at 09:51:16AM +0200, Marcin Wojtas wrote: >> This patch introduces UTMI description, using the new structures >> and template in MvHwDescLib. This change enables more flexible >> addition of multiple CP with UTMI PHY's and also significantly >> reduces amount of used PCD's for that purpose. Update PortingGuide >> documentation accordingly. >> >> This patch replaces string-based description of Utmi on >> Armada 70x0 DB with new, reduced format. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marcin Wojtas >> --- >> Platform/Marvell/Armada/Armada70x0.dsc | 7 +- >> Platform/Marvell/Include/Library/MvHwDescLib.h | 47 ++++++ >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 149 ++++++++++---------- >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.h | 1 - >> Platform/Marvell/Library/UtmiPhyLib/UtmiPhyLib.inf | 11 +- >> Platform/Marvell/Marvell.dec | 7 +- >> Silicon/Marvell/Documentation/PortingGuide.txt | 30 ++-- >> 7 files changed, 142 insertions(+), 110 deletions(-) >> >> diff --git a/Platform/Marvell/Armada/Armada70x0.dsc b/Platform/Marvell/Armada/Armada70x0.dsc >> index d9d126d..04bdf7c 100644 >> --- a/Platform/Marvell/Armada/Armada70x0.dsc >> +++ b/Platform/Marvell/Armada/Armada70x0.dsc >> @@ -111,11 +111,8 @@ >> gMarvellTokenSpaceGuid.PcdChip0ComPhySpeeds|{ 0x1, 0x6, 0xA, 0x6, 0x6, 0x6 } >> >> #UtmiPhy >> - gMarvellTokenSpaceGuid.PcdUtmiPhyCount|2 >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUsbCfg|L"0xF2440420;0xF2440420" >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiCfg|L"0xF2440440;0xF2440444" >> - gMarvellTokenSpaceGuid.PcdUtmiPhyRegUtmiUnit|L"0xF2580000;0xF2581000" >> - gMarvellTokenSpaceGuid.PcdUtmiPhyUtmiPort|L"0x0;0x1" >> + gMarvellTokenSpaceGuid.PcdUtmiControllers|{ 0x1, 0x1 } >> + gMarvellTokenSpaceGuid.PcdUtmiPortType|{ 0x0, 0x1 } > > Like for 1/5, could we have some entries under a [Define] in a .inc > (reasonably the same .inc)? > Ok. Any preferences in terms of the name of such file? Unless we can just put it into Armada.dsc.inc... Best regards, Marcin