From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::241; helo=mail-it0-x241.google.com; envelope-from=mw@semihalf.com; receiver=edk2-devel@lists.01.org Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 99C032097E25F for ; Mon, 30 Jul 2018 09:36:48 -0700 (PDT) Received: by mail-it0-x241.google.com with SMTP id e14-v6so115610itf.1 for ; Mon, 30 Jul 2018 09:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=s0sEa7VHAc8Vwm0B7mE/I7ZVudJjKghXXSjncz0oWUI=; b=ATXYfzwmacMTyQYUvW75GU/lGc8JtM3sa+3pBioZ9MPVvgiF6mynB2PJY2MBxDIcD4 Ib+oSeFhbrvIxFM4+scEREjLURkM79xG6tO01g5vYGqqbK0qX5zoYMxGCXFBXS78974p YKV4jo8CmHNg2j97HA9CDNeHqY+Il4zK4F0LOh+AgfXv7NJ4GyZMhcTfBdoJI3guitm9 YgO9rvZqFnqC0C3noCsurSEX9N7H8rUrZ9HxTY0iyW6EccfSf82vCNOuMaxoYMc47nyn +IzyKsztwgf336/sFyD3SHipms5YBaVD7eOSotDpanqFKHr6BwZXU7+4/9oF9zb/nqnJ AWDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=s0sEa7VHAc8Vwm0B7mE/I7ZVudJjKghXXSjncz0oWUI=; b=p1YLcosFNhUbop+qhzY3x1zrRkIAqx0mkYwjv50+kxxWyY36YGPF02X768ftb6LWSt FCzmgNKcsZNsgM+7vdCIRCJ/mf9PjA1j1jUnV3gc0LdVLv4ZSYNktdb8JtgvFgt5s+E9 PwX3WwPWpWj+znmjrD9R5T7RZWrNaqKKTWwJ2XytowIPpdnlvgNQzPkMl2x5hwqCW1AR rn0UKT1XKcQzYs+1i6W2qtyjgQFtRZJEbIIKP8UofABxLojkEgb+Gpn8QEFvGi5WEzkv Nao8wb8wNn5pGfYKqpA/UTe5DRdGZFTny3e6TEGM0qSCsaM96STZLYc+Zv0KyQErl7rE ZXgg== X-Gm-Message-State: AOUpUlEoYUPNSFDfgVwnIJqxb2Zlg+B48doAR/4KA8cl9doRJxUqktg+ haaSXLYAgsKOsOe+LugV9GJ4n3F5Hw5bYTPIF6Yn0Q== X-Google-Smtp-Source: AAOMgpewpFFRE0ymGQ8rddu2m0vqft7eV2kSTev1dLo9PVDEhUHIMo04SxzylePCOkZs5PfhVBJyloGC/khN68TSIaE= X-Received: by 2002:a02:b687:: with SMTP id i7-v6mr17175711jam.55.1532968607347; Mon, 30 Jul 2018 09:36:47 -0700 (PDT) MIME-Version: 1.0 References: <1532589696-16902-1-git-send-email-mw@semihalf.com> In-Reply-To: <1532589696-16902-1-git-send-email-mw@semihalf.com> From: Marcin Wojtas Date: Mon, 30 Jul 2018 18:36:36 +0200 Message-ID: To: Ard Biesheuvel Cc: nadavh@marvell.com, edk2-devel-01 , "jsd@semihalf.com" , Grzegorz Jaszczyk , Leif Lindholm Subject: Re: [platforms: PATCH v2 0/6] Armada7k8k ComPhy rework X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 16:36:48 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Ard, Do you have any objections to the v2 patchset? Best regards, Marcin czw., 26 lip 2018 o 09:21 Marcin Wojtas napisa=C5=82(a): > > Hi, > > The second version of the patchset brings minor corrections, > that were pointed out during review. Details can be found > int the commit logs. > > The patches are available in the github: > https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/c= omphy-upstream-r20180726 > > I'm looking forward to review and any comments/remarks. > > Best regards, > Marcin > > Changelog: > v1 -> v2 > * 1/6 > - improve commit message > - create dedicated header for externally defined SiP services > ComPhy parameters > - add comments about external definitions > > * 2,3,4/6 > - s/firmware/ARM-TF/ in the commit messages > > * 5,6/6 > - swap order without any changes in the patches - in the first > series compilation was broken on 5th and immediately fixed in > the last patch. Now every patch compiles. > > Grzegorz Jaszczyk (5): > Marvell/Library: ComPhyLib: Configure SATA, SGMII and SFI in ARM-TF > Marvell/Library: ComPhyLib: Configure PCIE in ARM-TF > Marvell/Library: ComPhyLib: Configure RXAUI in ARM-TF > Marvell/Library: ComPhyLib: Configure USB in ARM-TF > Marvell/Library: ComPhyLib: Remove both PHY and PIPE selector config > Marvell/Library: ComPhyLib: Clean up the library after rework > > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc = | 23 +- > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.inf = | 2 +- > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8k= SampleAtResetLib.h | 22 - > Silicon/Marvell/Include/Library/SampleAtResetLib.h = | 7 - > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.h = | 512 +----- > Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h = | 86 + > Silicon/Marvell/Armada7k8k/Library/Armada7k8kSampleAtResetLib/Armada7k8k= SampleAtResetLib.c | 19 - > Silicon/Marvell/Library/ComPhyLib/ComPhyCp110.c = | 1777 +------------------- > Silicon/Marvell/Library/ComPhyLib/ComPhyLib.c = | 41 +- > Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c = | 132 -- > 10 files changed, 170 insertions(+), 2451 deletions(-) > create mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhySipSvc.h > delete mode 100644 Silicon/Marvell/Library/ComPhyLib/ComPhyMux.c > > -- > 2.7.4 >