Re: [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes

[Steve Capper <steve.capper@linaro.org>]

On 12 April 2018 at 11:09, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> On 12 April 2018 at 02:55, Laszlo Ersek <lersek@redhat.com> wrote:
>> Repo:   https://github.com/lersek/edk2.git
>> Branch: depex_fixes
>>
>> ArmVirtQemu boots again, it just took a few more patches than I expected
>> :)
>>
>> Some of these patches will have to be ported to edk2-platforms, I think.
>>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Cc: Leif Lindholm <leif.lindholm@linaro.org>
>> Cc: Steve Capper <steve.capper@linaro.org>
>> Cc: Supreeth Venkatesh <Supreeth.Venkatesh@arm.com>
>>
>> Thanks,
>> Laszlo
>>
>> Laszlo Ersek (10):
>>   Omap35xxPkg/InterruptDxe: replace CPU Arch Protocol depex with notify
>>   ArmPkg/ArmGicDxe: annotate protocol usage in "ArmGicDxe.inf"
>>   ArmPkg/CpuDxe: order CpuDxe after ArmGicDxe via protocol depex
>>   EmbeddedPkg: introduce NvVarStoreFormattedLib
>>   ArmPlatformPkg/NorFlashDxe: initialize varstore headers eagerly
>>   ArmPlatformPkg/NorFlashDxe: cue the variable driver with
>>     NvVarStoreFormatted
>>   ArmPlatformPkg/NorFlashDxe: depend on gEfiCpuArchProtocolGuid
>>   ArmPlatformPkg/PL031RealTimeClockLib: depend on
>>     gEfiCpuArchProtocolGuid
>>   ArmVirtPkg/PlatformHasAcpiDtDxe: depend on
>>     gEfiVariableArchProtocolGuid
>>   ArmVirtPkg/ArmVirtQemu: hook NvVarStoreFormattedLib into
>>     VariableRuntimeDxe
>>
>
> Laszlo,
>
> Thanks a lot for taking care of this. I am glad we finally got rid of
> the BEFORE depex in the NOR flash driver, which has been problematic
> for years.
>
> For the series,
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> but please allow some time for Leif to chime in as well.
>
> Thanks,
> Ard.
>
>
>

Hi Laszlo,
Thanks for this!

I've booted with both DEBUG and RELEASE configurations on an FVP model
using this series.
I built this on Debian Stretch (using the AArch64 cross compiler).

In order to test on FVP (which is defined in edk2-platforms), I made a
simple modification to:
edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc
(Basically mirroring what you did in patch #10)

FWIW, feel free to add:
Tested-by: Steve Capper <steve.capper@linaro.org>

Cheers,
--
Steve