From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4003:c0f::243; helo=mail-ot0-x243.google.com; envelope-from=steve.capper@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-ot0-x243.google.com (mail-ot0-x243.google.com [IPv6:2607:f8b0:4003:c0f::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F1B31226CD7BD for ; Thu, 12 Apr 2018 06:39:03 -0700 (PDT) Received: by mail-ot0-x243.google.com with SMTP id 23-v6so6008606otj.0 for ; Thu, 12 Apr 2018 06:39:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=j6BbYNBOcxv4DVSX9lEAU5WSE8ZMtN6xhvynpfi+BXM=; b=BYDwJDddTTq4KZO3xAfoAnZ2QiRHuvCbN9d7089T0d4Ig3IQSVjqB4395J7GWdjclm 3CbN6QANgrmsE+kk0rhAId7nqV8UL2LfQKHas9oJiyqtKIvq/9pwJHpInrcJMd7gVD7f 9ujWkVq1BQHXYqPEeuX5GFBAC6/kgGlB9H5H4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=j6BbYNBOcxv4DVSX9lEAU5WSE8ZMtN6xhvynpfi+BXM=; b=rNU3fNjpHHr1Tv1vSQqD7qQ5jEveUd2Mi28UE4mJ232oufqikwZVX0mZ+h40bSBZeT uy2spOHnHPN+ELrXMLrCYlV7Wb8zc8kbjUYaWLMQdr3tkkJeFt57z8/Av5VJalGt5I5B kjOcocaujluzuUKf3+gMML6YSReUU3BumvbOit80JQdP7ugj1/rALDEW4DfaloObZRwZ cZ9396CX7kWm/K743n+ZT6/tml0NhgPHTO0c2Uemh0QO8aRxVjZEgxOMs10obD4uGY2o NEdLXBbDvcnS8gy4m3wrerozCDGzpKpmNAmnSKoqepoh8UKStMppyoP/PBbVYKeTgsYR Smcw== X-Gm-Message-State: ALQs6tDkz4oBQgO8414b0KR8cO27zTdGbqxOkIxlufMyaR4z20cCK7cv UaDFojsHSmuIiK4WcTbGsn3mngpHY5ng+imMniGkvw== X-Google-Smtp-Source: AIpwx48q1gsMIAa4d79vKo4Xcc+f203NEZHqrXTMbB7Hoc7/9vjFlH2kWvjFe+KyhyNEvNhW/uj2O1EkBHuPIMI+SF4= X-Received: by 2002:a9d:6057:: with SMTP id v23-v6mr700836otj.362.1523540343101; Thu, 12 Apr 2018 06:39:03 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a9d:3c2:0:0:0:0:0 with HTTP; Thu, 12 Apr 2018 06:39:02 -0700 (PDT) In-Reply-To: References: <20180412005540.26651-1-lersek@redhat.com> From: Steve Capper Date: Thu, 12 Apr 2018 14:39:02 +0100 Message-ID: To: Ard Biesheuvel Cc: Laszlo Ersek , "edk2-devel@lists.01.org" , Leif Lindholm , Supreeth Venkatesh Subject: Re: [PATCH 00/10] ArmPkg, ArmPlatformPkg, ArmVirtPkg, EmbeddedPkg, Omap35xxPkg: depex fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 13:39:04 -0000 Content-Type: text/plain; charset="UTF-8" On 12 April 2018 at 11:09, Ard Biesheuvel wrote: > On 12 April 2018 at 02:55, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: depex_fixes >> >> ArmVirtQemu boots again, it just took a few more patches than I expected >> :) >> >> Some of these patches will have to be ported to edk2-platforms, I think. >> >> Cc: Ard Biesheuvel >> Cc: Leif Lindholm >> Cc: Steve Capper >> Cc: Supreeth Venkatesh >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (10): >> Omap35xxPkg/InterruptDxe: replace CPU Arch Protocol depex with notify >> ArmPkg/ArmGicDxe: annotate protocol usage in "ArmGicDxe.inf" >> ArmPkg/CpuDxe: order CpuDxe after ArmGicDxe via protocol depex >> EmbeddedPkg: introduce NvVarStoreFormattedLib >> ArmPlatformPkg/NorFlashDxe: initialize varstore headers eagerly >> ArmPlatformPkg/NorFlashDxe: cue the variable driver with >> NvVarStoreFormatted >> ArmPlatformPkg/NorFlashDxe: depend on gEfiCpuArchProtocolGuid >> ArmPlatformPkg/PL031RealTimeClockLib: depend on >> gEfiCpuArchProtocolGuid >> ArmVirtPkg/PlatformHasAcpiDtDxe: depend on >> gEfiVariableArchProtocolGuid >> ArmVirtPkg/ArmVirtQemu: hook NvVarStoreFormattedLib into >> VariableRuntimeDxe >> > > Laszlo, > > Thanks a lot for taking care of this. I am glad we finally got rid of > the BEFORE depex in the NOR flash driver, which has been problematic > for years. > > For the series, > > Reviewed-by: Ard Biesheuvel > > but please allow some time for Leif to chime in as well. > > Thanks, > Ard. > > > Hi Laszlo, Thanks for this! I've booted with both DEBUG and RELEASE configurations on an FVP model using this series. I built this on Debian Stretch (using the AArch64 cross compiler). In order to test on FVP (which is defined in edk2-platforms), I made a simple modification to: edk2-platforms/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc (Basically mirroring what you did in patch #10) FWIW, feel free to add: Tested-by: Steve Capper Cheers, -- Steve