Re: [PATCH v5 0/4] Introduce CLANG38 toolchain in edk2

["Carsey, Jaben" <jaben.carsey@intel.com>]

For both changes in ShellPkg. 

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Shi, Steven
> Sent: Wednesday, August 03, 2016 2:43 AM
> To: edk2-devel@lists.01.org; Gao, Liming <liming.gao@intel.com>; Carsey,
> Jaben <jaben.carsey@intel.com>
> Cc: afish@apple.com; Kinney, Michael D <michael.d.kinney@intel.com>;
> ard.biesheuvel@linaro.org
> Subject: [PATCH v5 0/4] Introduce CLANG38 toolchain in edk2
> Importance: High
> 
> Please review my new commits in public branch:
> https://github.com/shijunjing/edk2/commits/llvm_v5
> 
> The difference from
> V4(https://github.com/shijunjing/edk2/commits/llvm_v4):
> 1. Remove the GCC5 path prefix for binutils objcopy, because a clang user
> may not set GCC5_BIN.
> 2. Follow GCC5 to disable the LTO for ASLCC flags.
> 3. Add CLANG38 in the "Supported Tool Chains" part.
> 
> The difference from
> V2(https://github.com/shijunjing/edk2/commits/llvm_v2):
> 1. Seperate the CLANG38 from the other two toolchains (GCC5,
> CLANGSCAN38), and only focus on CLANG38 in this serial.
> 2. Base on current GCC5 in edk2 to enhance the CLANG38.
> 3. Seperate the GenFW new relocation types support patch from this serial,
> and I will send it later in new serial.
> 4. Add EFIAPI for UefiShellCommandLib function.
> 
> Test pass platforms: OVMF (OvmfPkgIa32.dsc, OvmfPkgX64.dsc and
> OvmfPkgIa32X64.dsc).
> Test compiler and linker version: LLVM 3.8, GNU ld 2.26.
> 
> Example steps to use the CLANG38 tool chain to build OVMF platform:
> 1. Download and extract the llvm 3.8.0 Pre-Built Binaries from
> http://www.llvm.org/releases/ (e.g.
> http://www.llvm.org/releases/3.8.0/clang+llvm-3.8.0-x86_64-linux-gnu-
> ubuntu-16.04.tar.xz and extract it as ~/clang38).
> 2. Copy LLVMgold.so from
> https://github.com/shijunjing/edk2/blob/llvm/BaseTools/Bin/LLVMgold.so
> to above clang lib folder (e.g.~/clang38/lib/LLVMgold.so)
> 3. Install new version linker with plugin support (e.g. ld 2.26 in GNU Binutils
> 2.26 or Ubuntu16.04)
> $ cd edk2
> $ export CLANG38_BIN=path/to/your/clang38/ (e.g. export
> CLANG38_BIN=~/clang38/bin/)
> $ source edksetup.sh
> $ make -C BaseTools/Source/C
> $ build -t CLANG38 -a X64 -p OvmfPkg/OvmfPkgX64.dsc -n 5 -b DEBUG -
> DDEBUG_ON_SERIAL_PORT
> $ cd edk2/Build/OvmfX64/DEBUG_CLANG38/FV
> $ qemu-system-x86_64.exe -bios OVMF.fd -serial file:serial.log -m 4096 -hda
> fat:.
> 
> 
> Shi, Steven (4):
>   BaseTools-Conf:Remove short dash in ar flag for LLVM
>   BaseTools-Conf:Introduce CLANG38 new toolchain for x86
>   ShellPkg-UefiShellTftpCommandLib: Replace compiler builtin
>   ShellPkg-UefiShellCommandLib: Add EFIAPI in VA_List library function
> 
>  BaseTools/Conf/build_rule.template                 |  2 +-
>  BaseTools/Conf/tools_def.template                  | 87
> ++++++++++++++++++++++
>  .../Library/UefiShellCommandLib/ConsistMapping.c   |  1 +
>  ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c    |  2 +-
>  4 files changed, 90 insertions(+), 2 deletions(-)
>  mode change 100644 => 100755 BaseTools/Conf/build_rule.template
>  mode change 100644 => 100755 BaseTools/Conf/tools_def.template
>  mode change 100644 => 100755
> ShellPkg/Library/UefiShellCommandLib/ConsistMapping.c
>  mode change 100644 => 100755
> ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c
> 
> --
> 2.7.4