[PATCH] ShellPkg SmbiosView: Show "SocketDesignation" instead of "Socket" for Type 4

[PATCH] ShellPkg SmbiosView: Show "SocketDesignation" instead of "Socket" for Type 4

[Star Zeng]

It is to make the info shown more aligned with SMBIOS spec.

Cc: Amy Chan <amy.chan@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Jaben Carsey <jaben.carsey@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index 3f99dc4825dc..7e17b69d5afa 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -1,7 +1,7 @@
 /** @file
   Module for clarifying the content of the smbios structure element information.
 
-  Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2005 - 2016, Intel Corporation. All rights reserved.<BR>
   (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR>  
   (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
   This program and the accompanying materials
@@ -399,7 +399,7 @@ SmbiosPrintStructure (
   // Processor Information (Type 4)
   //
   case 4:
-    PRINT_PENDING_STRING (Struct, Type4, Socket);
+    PRINT_SMBIOS_STRING (Struct, Struct->Type4->Socket, SocketDesignation)
     DisplayProcessorType (Struct->Type4->ProcessorType, Option);
     if (AE_SMBIOS_VERSION (0x2, 0x6) && (Struct->Hdr->Length > 0x28) &&
         (Struct->Type4->ProcessorFamily == 0xFE)) {
-- 
2.8.1.windows.1

Re: [PATCH] ShellPkg SmbiosView: Show "SocketDesignation" instead of "Socket" for Type 4

[Carsey, Jaben]

Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>

> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, August 5, 2016 2:02 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Chan, Amy <amy.chan@intel.com>; Ni,
> Ruiyu <ruiyu.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> Subject: [PATCH] ShellPkg SmbiosView: Show "SocketDesignation" instead of
> "Socket" for Type 4
> Importance: High
> 
> It is to make the info shown more aligned with SMBIOS spec.
> 
> Cc: Amy Chan <amy.chan@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 ++-
> -
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index 3f99dc4825dc..7e17b69d5afa 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -1,7 +1,7 @@
>  /** @file
>    Module for clarifying the content of the smbios structure element information.
> 
> -  Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2005 - 2016, Intel Corporation. All rights
> + reserved.<BR>
>    (C) Copyright 2014 Hewlett-Packard Development Company, L.P.<BR>
>    (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
>    This program and the accompanying materials @@ -399,7 +399,7 @@
> SmbiosPrintStructure (
>    // Processor Information (Type 4)
>    //
>    case 4:
> -    PRINT_PENDING_STRING (Struct, Type4, Socket);
> +    PRINT_SMBIOS_STRING (Struct, Struct->Type4->Socket,
> + SocketDesignation)
>      DisplayProcessorType (Struct->Type4->ProcessorType, Option);
>      if (AE_SMBIOS_VERSION (0x2, 0x6) && (Struct->Hdr->Length > 0x28) &&
>          (Struct->Type4->ProcessorFamily == 0xFE)) {
> --
> 2.8.1.windows.1