From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by ml01.01.org (Postfix) with ESMTP id 7FA8C1A1DF5 for ; Fri, 5 Aug 2016 10:20:33 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP; 05 Aug 2016 10:20:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,474,1464678000"; d="scan'208";a="151266049" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 05 Aug 2016 10:20:33 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 5 Aug 2016 10:20:33 -0700 Received: from fmsmsx103.amr.corp.intel.com ([169.254.2.120]) by FMSMSX119.amr.corp.intel.com ([169.254.14.93]) with mapi id 14.03.0248.002; Fri, 5 Aug 2016 10:20:32 -0700 From: "Carsey, Jaben" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Chan, Amy" , "Ni, Ruiyu" , "Carsey, Jaben" Thread-Topic: [PATCH] ShellPkg SmbiosView: Show "SocketDesignation" instead of "Socket" for Type 4 Thread-Index: AQHR7vgJWc5HcUNB3EqImm5KEVXPMaA6nWMg Date: Fri, 5 Aug 2016 17:20:32 +0000 Message-ID: References: <1470387703-22276-1-git-send-email-star.zeng@intel.com> In-Reply-To: <1470387703-22276-1-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] ShellPkg SmbiosView: Show "SocketDesignation" instead of "Socket" for Type 4 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Aug 2016 17:20:33 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Jaben Carsey > -----Original Message----- > From: Zeng, Star > Sent: Friday, August 5, 2016 2:02 AM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Chan, Amy ; Ni, > Ruiyu ; Carsey, Jaben > Subject: [PATCH] ShellPkg SmbiosView: Show "SocketDesignation" instead of > "Socket" for Type 4 > Importance: High >=20 > It is to make the info shown more aligned with SMBIOS spec. >=20 > Cc: Amy Chan > Cc: Ruiyu Ni > Cc: Jaben Carsey > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 4 += +- > - > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > index 3f99dc4825dc..7e17b69d5afa 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c > @@ -1,7 +1,7 @@ > /** @file > Module for clarifying the content of the smbios structure element info= rmation. >=20 > - Copyright (c) 2005 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2005 - 2016, Intel Corporation. All rights > + reserved.
> (C) Copyright 2014 Hewlett-Packard Development Company, L.P.
> (C) Copyright 2015 Hewlett Packard Enterprise Development LP
> This program and the accompanying materials @@ -399,7 +399,7 @@ > SmbiosPrintStructure ( > // Processor Information (Type 4) > // > case 4: > - PRINT_PENDING_STRING (Struct, Type4, Socket); > + PRINT_SMBIOS_STRING (Struct, Struct->Type4->Socket, > + SocketDesignation) > DisplayProcessorType (Struct->Type4->ProcessorType, Option); > if (AE_SMBIOS_VERSION (0x2, 0x6) && (Struct->Hdr->Length > 0x28) && > (Struct->Type4->ProcessorFamily =3D=3D 0xFE)) { > -- > 2.8.1.windows.1