From: "Carsey, Jaben" <jaben.carsey@intel.com>
To: Abdul Lateef Attar <abdul-lateef.attar@hpe.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>
Subject: Re: [PATCH] ShellPkg: pci -i -_e to print next capability
Date: Wed, 7 Sep 2016 17:38:29 +0000 [thread overview]
Message-ID: <CB6E33457884FA40993F35157061515C54A44ED9@FMSMSX103.amr.corp.intel.com> (raw)
In-Reply-To: <3ac3b70ae8a01c19a82b09787879b351b71d4763.1472819042.git.abdul-lateef.attar@hpe.com>
Change Looks good. Can you please clarify the commit message on why to change -_e type?
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Abdul Lateef Attar
> Sent: Monday, September 05, 2016 11:34 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH] ShellPkg: pci -i -_e to print next capability
> Importance: High
>
> According to PCI spec the next AER capability is relative to
> the beginning of PCI configuration space. Hence substract the
> base offset to get the next capability.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Abdul Lateef Attar <abdul-lateef.attar@hpe.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
> index 337495e..664c22b 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
> @@ -2370,7 +2370,7 @@ PCI_CONFIG_SPACE *mConfigSpace = NULL;
> STATIC CONST SHELL_PARAM_ITEM ParamList[] = {
> {L"-s", TypeValue},
> {L"-i", TypeFlag},
> - {L"-_e", TypeFlag},
> + {L"-_e", TypeValue},
> {NULL, TypeMax}
> };
>
> @@ -5914,7 +5914,7 @@ PciExplainPciExpress (
> // Advance to the next item if it exists
> //
> if (ExtHdr->NextCapabilityOffset != 0) {
> - ExtHdr = (PCI_EXP_EXT_HDR*)((UINT8*)ExRegBuffer + ExtHdr-
> >NextCapabilityOffset);
> + ExtHdr = (PCI_EXP_EXT_HDR*)((UINT8*)ExRegBuffer + ExtHdr-
> >NextCapabilityOffset - EFI_PCIE_CAPABILITY_BASE_OFFSET);
> } else {
> break;
> }
> --
> 2.7.4
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-09-07 17:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 6:34 [PATCH] ShellPkg: pci -i -_e to print next capability Abdul Lateef Attar
2016-09-07 17:38 ` Carsey, Jaben [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CB6E33457884FA40993F35157061515C54A44ED9@FMSMSX103.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox